1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
|
(function() {
"use strict";
load("jstests/libs/fixture_helpers.js"); // For FixtureHelpers
load("jstests/aggregation/extras/utils.js"); // For assertErrorCode() and assertArrayEq().
const collName = "jstests_aggregation_add";
const coll = db["collName"];
coll.drop();
const $x = "$x"; // fieldpath to "block" constant folding
/**
* Verify constant folding with explain output.
* @param {(number | number[])[]} input Input arithmetic parameters, optionally nested deeply.
* @param {number[] | number} expectedOutput Expected output parameters after constant folding, or a
* scalar if the operation was calculated statically.
* @param {string} message error message
* @returns true if the explain output matches expectedOutput, and an assertion failure otherwise.
*/
function assertConstantFoldingResultForOp(op, input, expectedOutput, message) {
const buildExpressionFromArguments = (arr, op) => {
if (Array.isArray(arr)) {
return {[op]: arr.map(elt => buildExpressionFromArguments(elt, op))};
} else if (typeof arr === 'string' || arr instanceof String) {
return arr;
} else {
return {$const: arr};
}
};
const expected = buildExpressionFromArguments(expectedOutput, op);
let processedPipeline = getExplainedPipelineFromAggregation(db, db[collName], [
{$group: {_id: buildExpressionFromArguments(input, op), sum: {$sum: 1}}},
]);
assert(processedPipeline[0] && processedPipeline[0].$group)
assert.eq(processedPipeline[0].$group._id, expected, message);
return true;
}
function assertConstantFoldingResults(input, addOutput, multiplyOutput, message) {
assertConstantFoldingResultForOp("$add", input, addOutput, message);
assertConstantFoldingResultForOp("$multiply", input, multiplyOutput, message);
}
/*
// Totally fold constants.
assertConstantFoldingResults([1, 2, 3], 6, 6, "All constants should fold.");
assertConstantFoldingResults(
[[1, 2], 3, 4, 5], 15, 120, "Nested operations with all constants should be folded away.");
// Left-associative test cases.
assertConstantFoldingResults([1, 2, $x],
[3, $x],
[2, $x],
"Constants should fold left-to-right before the first non-constant.");
assertConstantFoldingResults(
[$x, 1, 2],
[$x, 1, 2],
[$x, 1, 2],
"Constants should not fold left-to-right after the first non-constant.");
assertConstantFoldingResults(
[1, $x, 2], [1, $x, 2], [1, $x, 2], "Constants should not fold across non-constants.");
assertConstantFoldingResults([5, 2, $x, 3, 4],
[7, $x, 3, 4],
[10, $x, 3, 4],
"Constants should fold up until a non-constant.");
assertConstantFoldingResults([$x, 1, 2, 3],
[$x, 1, 2, 3],
[$x, 1, 2, 3],
"Non-constant at start of operand list blocks folding constants.");
// Non-optimized comparisons -- make sure that non-optimized pipelines will give the same result as
// optimized ones.
// This is a regression test for BF-24149.
coll.insert({_id: 0, v: NumberDecimal("917.6875119062092")});
coll.insert({_id: 1, v: NumberDecimal("927.3345924210555")});
const pipeline = [
{$group: {_id: {$multiply: [-3.14159265859, "$v", -314159255]}, sum: {$sum: 1}}},
];
const result = coll.aggregate(pipeline).toArray();
assertArrayEq({
actual: result,
expected: [
{"_id": NumberDecimal("915242528741.9469524422272990976000"), "sum": 1},
{"_id": NumberDecimal("905721242210.0453137831269007622941"), "sum": 1}
]
});
*/
function assertPipelineCorrect(pipeline, v) {
let optimizedResults = coll.aggregate(pipeline).toArray();
db.adminCommand({
configureFailPoint: 'disablePipelineOptimization',
mode: 'alwaysOn',
})
let unoptimizedResults = coll.aggregate(pipeline).toArray();
db.adminCommand({
configureFailPoint: 'disablePipelineOptimization',
mode: 'off',
})
assertArrayEq({
actual: unoptimizedResults,
expected: optimizedResults,
extraErrorMsg: tojson({pipeline, v})
});
}
/**
* Randomized, property-based test of the left-to-right constant folding optimization. The purpose
* of folding left-to-right is to preserve the same order-of-operations during ahead-of-time
* constant folding that occurs during runtime execution.
*
* Given:
* - A random list of numbers of any type
* - A fieldpath reference placed at a random location in the list of numbers
* - A pipeline that performs an arithmetic operation over the list of arguments (fieldpath +
* numbers)
* Prove:
* - The arithmetic operation produces the exact same result with and without optimizations.
* @param {options} options
*/
function runRandomizedPropertyTest({op, min, max}) {
// Function to generate random numbers of float, long, double, and NumberDecimal (with different
// probabilities).
const generateNumber = () => {
const r = Math.random() * (max - min) + min;
const t = Math.random();
if (t < 0.7) {
return r;
}
if (t < 0.85) {
return NumberInt(Math.round(r));
}
if (t < 0.99) {
return NumberLong(Math.round(r));
}
return NumberDecimal(String(r));
};
const generateNumberList = (length) => Array.from({length}, () => generateNumber(min, max));
const numbers = generateNumberList(10)
// Place a fieldpath reference randomly within the list of numbers to produce an argument list.
const pos = Math.floor(numbers.length * Math.random());
const args = [].concat(numbers.slice(0, pos), ["$v"], numbers.slice(pos));
const pipeline = [{
$group: {
_id: {[op]: args},
sum: {$sum: 1},
},
}];
coll.drop();
const v = generateNumber();
coll.insert({v});
assertPipelineCorrect(pipeline, v);
}
for (let i = 0; i < 100; i++) {
// runRandomizedPropertyTest({op: "$add", min: -314159255, max: 314159255});
runRandomizedPropertyTest({op: "$multiply", min: -31415, max: 31415});
}
// coll.drop();
// const v = NumberLong(-165920709);
// coll.insert({v});
// const failingPipeline = [{
// "$group": {
// "_id": {
// "$add": [
// -127634651.75010383,
// -42470286.927390575,
// NumberInt(-23124488),
// -307746827.02983755,
// 16356215.01332593,
// -150531428.49670622,
// NumberInt(-226364290),
// 181297936.56230265,
// "$v",
// 109560746.75857013,
// 136774220.7681843
// ]
// },
// "sum": {"$sum": 1}
// }
// }];
// const makePipeline = (id) => [{"$group": {"_id": id, "sum": {"$sum": 1}}}];
// print("DAVISDEBUG unfolded addition")
// printjson(getExplainedPipelineFromAggregation(
// db,
// coll,
// makePipeline({
// $add: [
// -127634651.75010383,
// -42470286.927390575,
// NumberInt(-23124488),
// -307746827.02983755,
// 16356215.01332593,
// -150531428.49670622,
// NumberInt(-226364290),
// 181297936.56230265,
// NumberLong(-165920709), // $v
// // 109560746.75857013,
// // 136774220.7681843
// 246334967.52675444 // sum of two constants above this
// ]
// }),
// ));
// print("DAVISDEBUG folded addition")
// printjson(getExplainedPipelineFromAggregation(
// db,
// coll,
// makePipeline({
// $add: [
// {"$const": -680217820.6284096},
// NumberLong(-165920709), // $v
// // {"$const": 109560746.75857013},
// // {"$const": 136774220.7681843}
// {"$const": 246334967.52675444} // sum of two constants above this
// ]
// }),
// ));
})();
|
