1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
/**
* Tests running the delete command with a hint on a time-series collection.
* @tags: [
* assumes_no_implicit_collection_creation_after_drop,
* does_not_support_stepdowns,
* does_not_support_transactions,
* # $currentOp can't run with a readConcern other than 'local'.
* assumes_read_concern_unchanged,
* # This test only synchronizes deletes on the primary.
* assumes_read_preference_unchanged,
* # Fail points in this test do not exist on mongos.
* assumes_against_mongod_not_mongos,
* uses_parallel_shell,
* ]
*/
(function() {
"use strict";
load("jstests/libs/curop_helpers.js");
load("jstests/libs/feature_flag_util.js");
load('jstests/libs/parallel_shell_helpers.js');
if (!FeatureFlagUtil.isEnabled(db, "TimeseriesUpdatesAndDeletes")) {
jsTestLog("Skipping test because the time-series updates and deletes feature flag is disabled");
return;
}
const timeFieldName = "time";
const metaFieldName = "tag";
const collName = 't';
const dbName = jsTestName();
const collNamespace = dbName + '.' + collName;
const validateDeleteIndex = (docsToInsert,
expectedRemainingDocs,
expectedNRemoved,
deleteQuery,
indexes,
expectedPlan,
{expectedErrorCode = null} = {}) => {
const testDB = db.getSiblingDB(dbName);
const awaitTestDelete = startParallelShell(funWithArgs(
function(docsToInsert,
expectedRemainingDocs,
expectedNRemoved,
deleteQuery,
indexes,
timeFieldName,
metaFieldName,
collName,
dbName,
expectedErrorCode) {
const testDB = db.getSiblingDB(dbName);
const coll = testDB.getCollection(collName);
assert.commandWorked(testDB.createCollection(
coll.getName(),
{timeseries: {timeField: timeFieldName, metaField: metaFieldName}}));
assert.commandWorked(coll.createIndexes(indexes));
assert.commandWorked(coll.insert(docsToInsert));
assert.commandWorked(testDB.adminCommand(
{configureFailPoint: "hangBeforeChildRemoveOpFinishes", mode: "alwaysOn"}));
const res = expectedErrorCode
? assert.commandFailedWithCode(
testDB.runCommand({delete: coll.getName(), deletes: deleteQuery}),
expectedErrorCode)
: assert.commandWorked(
testDB.runCommand({delete: coll.getName(), deletes: deleteQuery}));
assert.eq(res["n"], expectedNRemoved);
assert.docEq(coll.find({}, {_id: 0}).toArray(), expectedRemainingDocs);
assert(coll.drop());
},
docsToInsert,
expectedRemainingDocs,
expectedNRemoved,
deleteQuery,
indexes,
timeFieldName,
metaFieldName,
collName,
dbName,
expectedErrorCode));
for (let childCount = 0; childCount < deleteQuery.length; ++childCount) {
const childCurOp =
waitForCurOpByFailPoint(testDB, collNamespace, "hangBeforeChildRemoveOpFinishes")[0];
// Assert the plan uses the expected index.
if (!expectedErrorCode) {
assert.eq(childCurOp['planSummary'], expectedPlan);
}
assert.commandWorked(testDB.adminCommand(
{configureFailPoint: "hangBeforeChildRemoveOpIsPopped", mode: "alwaysOn"}));
assert.commandWorked(testDB.adminCommand(
{configureFailPoint: "hangBeforeChildRemoveOpFinishes", mode: "off"}));
waitForCurOpByFailPoint(testDB, collNamespace, "hangBeforeChildRemoveOpIsPopped");
// Enable the hangBeforeChildRemoveOpFinishes fail point if this is not the last child.
if (childCount + 1 < deleteQuery.length) {
assert.commandWorked(testDB.adminCommand(
{configureFailPoint: "hangBeforeChildRemoveOpFinishes", mode: "alwaysOn"}));
}
assert.commandWorked(testDB.adminCommand(
{configureFailPoint: "hangBeforeChildRemoveOpIsPopped", mode: "off"}));
}
// Wait for testDelete to finish.
awaitTestDelete();
};
const objA = {
[timeFieldName]: ISODate(),
"measurement": {"A": "cpu"},
[metaFieldName]: {a: "A"}
};
const objB = {
[timeFieldName]: ISODate(),
"measurement": {"A": "cpu"},
[metaFieldName]: {b: "B"}
};
const objC = {
[timeFieldName]: ISODate(),
"measurement": {"A": "cpu"},
[metaFieldName]: {c: "C"}
};
// Query using a $natural hint.
validateDeleteIndex([objA, objB, objC],
[objB, objC],
1,
[{q: {[metaFieldName]: {a: "A"}}, limit: 0, hint: {$natural: 1}}],
[{[metaFieldName]: 1}],
"COLLSCAN");
validateDeleteIndex([objA, objB, objC],
[objB, objC],
1,
[{q: {[metaFieldName]: {a: "A"}}, limit: 0, hint: {$natural: -1}}],
[{[metaFieldName]: 1}],
"COLLSCAN");
// Query using the metaField index as a hint.
validateDeleteIndex([objA, objB, objC],
[objB, objC],
1,
[{q: {[metaFieldName]: {a: "A"}}, limit: 0, hint: {[metaFieldName]: 1}}],
[{[metaFieldName]: 1}],
"IXSCAN { meta: 1 }");
// Query on a collection with a compound index using the timeField and metaField indexes as
// hints.
validateDeleteIndex(
[objA, objB, objC],
[objB, objC],
1,
[{q: {[metaFieldName]: {a: "A"}}, limit: 0, hint: {[timeFieldName]: 1, [metaFieldName]: 1}}],
[{[timeFieldName]: 1, [metaFieldName]: 1}],
"IXSCAN { control.min.time: 1, control.max.time: 1, meta: 1 }");
// Query on a collection with a compound index using the timeField and metaField indexes as
// hints
validateDeleteIndex(
[objA, objB, objC],
[objA, objC],
1,
[{q: {[metaFieldName]: {b: "B"}}, limit: 0, hint: {[timeFieldName]: -1, [metaFieldName]: 1}}],
[{[timeFieldName]: -1, [metaFieldName]: 1}],
"IXSCAN { control.max.time: -1, control.min.time: -1, meta: 1 }");
// Query on a collection with a compound index using the timeField and metaField index names
// as hints.
validateDeleteIndex([objA, objB, objC],
[objA, objC],
1,
[{
q: {[metaFieldName]: {b: "B"}},
limit: 0,
hint: timeFieldName + "_1_" + metaFieldName + "_1"
}],
[{[timeFieldName]: 1, [metaFieldName]: 1}],
"IXSCAN { control.min.time: 1, control.max.time: 1, meta: 1 }");
// Query on a collection with multiple indexes using the timeField index as a hint.
validateDeleteIndex([objA, objB, objC],
[objA, objB],
1,
[{q: {[metaFieldName]: {c: "C"}}, limit: 0, hint: {[timeFieldName]: 1}}],
[{[metaFieldName]: -1}, {[timeFieldName]: 1}],
"IXSCAN { control.min.time: 1, control.max.time: 1 }");
// Query on a collection with multiple indexes using an invalid index name.
validateDeleteIndex([objA, objB, objC],
[objA, objB, objC],
0,
[{q: {[metaFieldName]: {c: "C"}}, limit: 0, hint: "test_hint"}],
[{[metaFieldName]: -1}, {[timeFieldName]: 1}],
"IXSCAN { control.min.time: 1, control.max.time: 1 }",
{expectedErrorCode: ErrorCodes.BadValue});
// Query on a collection with multiple indexes using an invalid index spec.
validateDeleteIndex([objA, objB, objC],
[objA, objB, objC],
0,
[{q: {[metaFieldName]: {c: "C"}}, limit: 0, hint: {"test_hint": 1}}],
[{[metaFieldName]: -1}, {[timeFieldName]: 1}],
"IXSCAN { control.min.time: 1, control.max.time: 1 }",
{expectedErrorCode: ErrorCodes.BadValue});
})();
|
