summaryrefslogtreecommitdiff
path: root/jstests/core/txns/transactions_block_ddl.js
blob: 0d6c4d1aa56f1a28483a72ee8e84210f3f6abe16 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
// Test that open transactions block DDL operations on the involved collections.
// @tags: [uses_transactions]
(function() {
    "use strict";

    load("jstests/libs/parallelTester.js");  // for ScopedThread.

    const dbName = "transactions_block_ddl";
    const collName = "transactions_block_ddl";
    const otherDBName = "transactions_block_ddl_other";
    const otherCollName = "transactions_block_ddl_other";
    const testDB = db.getSiblingDB(dbName);

    const session = testDB.getMongo().startSession({causalConsistency: false});
    const sessionDB = session.getDatabase(dbName);
    const sessionColl = sessionDB[collName];

    /**
     * Tests that DDL operations block on transactions and fail when their maxTimeMS expires.
     */
    function testTimeout(cmdDBName, ddlCmd) {
        // Setup.
        sessionDB.runCommand({drop: collName, writeConcern: {w: "majority"}});
        assert.commandWorked(sessionColl.createIndex({b: 1}, {name: "b_1"}));

        session.startTransaction();
        assert.commandWorked(sessionColl.insert({a: 5, b: 6}));
        assert.commandFailedWithCode(
            testDB.getSiblingDB(cmdDBName).runCommand(Object.assign({}, ddlCmd, {maxTimeMS: 500})),
            ErrorCodes.ExceededTimeLimit);
        assert.commandWorked(session.commitTransaction_forTesting());
    }

    /**
     * Tests that DDL operations block on transactions but can succeed once the transaction commits.
     */
    function testSuccessOnTxnCommit(cmdDBName, ddlCmd, currentOpFilter) {
        // Setup.
        sessionDB.runCommand({drop: collName, writeConcern: {w: "majority"}});
        assert.commandWorked(sessionColl.createIndex({b: 1}, {name: "b_1"}));

        session.startTransaction();
        assert.commandWorked(sessionColl.insert({a: 5, b: 6}));
        let thread = new ScopedThread(function(testData, cmdDBName, ddlCmd) {
            TestData = testData;
            return db.getSiblingDB(cmdDBName).runCommand(ddlCmd);
        }, TestData, cmdDBName, ddlCmd);
        thread.start();
        // Wait for the DDL operation to have pending locks.
        assert.soon(
            function() {
                // Note that we cannot use the $currentOp agg stage because it acquires locks
                // (SERVER-35289).
                return testDB.currentOp({$and: [currentOpFilter, {waitingForLock: true}]})
                           .inprog.length === 1;
            },
            function() {
                return "Failed to find DDL command in currentOp output: " +
                    tojson(testDB.currentOp().inprog);
            });
        assert.commandWorked(session.commitTransaction_forTesting());
        thread.join();
        assert.commandWorked(thread.returnData());
    }

    // Test 'drop'.
    const dropCmd = {drop: collName, writeConcern: {w: "majority"}};
    testTimeout(dbName, dropCmd);
    testSuccessOnTxnCommit(dbName, dropCmd, {"command.drop": collName});

    // Test 'dropDatabase'.
    // We cannot run testTimeout() for dropDatabase, since dropDatabase does not respect maxTimeMS
    // TODO SERVER-35290: Run testTimeout() for dropDatabase.
    const dropDatabaseCmd = {dropDatabase: 1, writeConcern: {w: "majority"}};
    testSuccessOnTxnCommit(dbName, dropDatabaseCmd, {"command.dropDatabase": 1});

    // Test 'renameCollection' in the same database.
    testDB.runCommand({drop: otherCollName, writeConcern: {w: "majority"}});
    const renameCollectionCmdSameDB = {
        renameCollection: sessionColl.getFullName(),
        to: dbName + "." + otherCollName,
        writeConcern: {w: "majority"}
    };
    testTimeout("admin", renameCollectionCmdSameDB);
    testSuccessOnTxnCommit("admin",
                           renameCollectionCmdSameDB,
                           {"command.renameCollection": sessionColl.getFullName()});

    // Test 'renameCollection' across databases.
    testDB.getSiblingDB(otherDBName)
        .runCommand({drop: otherCollName, writeConcern: {w: "majority"}});
    const renameCollectionCmdDifferentDB = {
        renameCollection: sessionColl.getFullName(),
        to: otherDBName + "." + otherCollName,
        writeConcern: {w: "majority"}
    };
    testTimeout("admin", renameCollectionCmdDifferentDB);
    testSuccessOnTxnCommit("admin",
                           renameCollectionCmdDifferentDB,
                           {"command.renameCollection": sessionColl.getFullName()});

    // Test 'createIndexes'. The transaction will insert a document that has a field 'a'.
    const createIndexesCmd = {
        createIndexes: collName,
        indexes: [{key: {a: 1}, name: "a_1"}],
        writeConcern: {w: "majority"}
    };
    testTimeout(dbName, createIndexesCmd);
    testSuccessOnTxnCommit(dbName, createIndexesCmd, {"command.createIndexes": collName});

    // Test 'dropIndexes'. The setup creates an index on {b: 1} called 'b_1'. The transaction will
    // insert a document that has a field 'b'.
    const dropIndexesCmd = {dropIndexes: collName, index: "b_1", writeConcern: {w: "majority"}};
    testTimeout(dbName, dropIndexesCmd);
    testSuccessOnTxnCommit(dbName, dropIndexesCmd, {"command.dropIndexes": collName});
    session.endSession();
}());