1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
|
// @tags: [
// assumes_superuser_permissions,
// requires_non_retryable_commands,
// requires_non_retryable_writes,
// ]
/**
* Tests that invalid view definitions in system.views do not impact valid commands on existing
* collections.
*/
(function() {
"use strict";
const isMongos = db.runCommand({isdbgrid: 1}).isdbgrid;
function runTest(badViewDefinition) {
let viewsDB = db.getSiblingDB("invalid_system_views");
assert.commandWorked(viewsDB.dropDatabase());
// Create a regular collection, then insert an invalid view into system.views.
assert.writeOK(viewsDB.collection.insert({x: 1}));
assert.commandWorked(viewsDB.runCommand({create: "collection2"}));
assert.commandWorked(viewsDB.runCommand({create: "collection3"}));
assert.commandWorked(viewsDB.collection.createIndex({x: 1}));
assert.writeOK(viewsDB.system.views.insert(badViewDefinition),
"failed to insert " + tojson(badViewDefinition));
// Test that a command involving views properly fails with a views-specific error code.
assert.commandFailedWithCode(
viewsDB.runCommand({listCollections: 1}),
ErrorCodes.InvalidViewDefinition,
"listCollections should have failed in the presence of an invalid view");
// Helper function to create a message to use if an assertion fails.
function makeErrorMessage(msg) {
return msg +
" should work on a valid, existing collection, despite the presence of bad views" +
" in system.views";
}
if (!isMongos) {
// Commands that run on existing regular collections should not be impacted by the
// presence of invalid views. However, applyOps doesn't work on mongos.
assert.commandWorked(
db.adminCommand( //
{
applyOps:
[{op: "c", ns: "invalid_system_views.$cmd", o: {drop: "collection3"}}]
}),
makeErrorMessage("applyOps"));
}
assert.writeOK(viewsDB.collection.insert({y: "baz"}), makeErrorMessage("insert"));
assert.writeOK(viewsDB.collection.update({y: "baz"}, {$set: {y: "qux"}}),
makeErrorMessage("update"));
assert.writeOK(viewsDB.collection.remove({y: "baz"}), makeErrorMessage("remove"));
assert.commandWorked(
viewsDB.runCommand({findAndModify: "collection", query: {x: 1}, update: {x: 2}}),
makeErrorMessage("findAndModify with update"));
assert.commandWorked(
viewsDB.runCommand({findAndModify: "collection", query: {x: 2}, remove: true}),
makeErrorMessage("findAndModify with remove"));
const lookup = {
$lookup: {from: "collection2", localField: "_id", foreignField: "_id", as: "match"}
};
assert.commandWorked(
viewsDB.runCommand({aggregate: "collection", pipeline: [lookup], cursor: {}}),
makeErrorMessage("aggregate with $lookup"));
const graphLookup = {
$graphLookup: {
from: "collection2",
startWith: "$_id",
connectFromField: "_id",
connectToField: "_id",
as: "match"
}
};
assert.commandWorked(
viewsDB.runCommand({aggregate: "collection", pipeline: [graphLookup], cursor: {}}),
makeErrorMessage("aggregate with $graphLookup"));
assert.commandWorked(viewsDB.runCommand({dropIndexes: "collection", index: "x_1"}),
makeErrorMessage("dropIndexes"));
assert.commandWorked(viewsDB.collection.createIndex({x: 1}),
makeErrorMessage("createIndexes"));
assert.commandWorked(viewsDB.collection.reIndex(), makeErrorMessage("reIndex"));
const storageEngine = jsTest.options().storageEngine;
if (isMongos || storageEngine === "ephemeralForTest" || storageEngine === "inMemory") {
print("Not testing compact command on mongos or ephemeral storage engine");
} else {
assert.commandWorked(viewsDB.runCommand({compact: "collection", force: true}),
makeErrorMessage("compact"));
}
assert.commandWorked(
viewsDB.runCommand({collMod: "collection", validator: {x: {$type: "string"}}}),
makeErrorMessage("collMod"));
const renameCommand = {
renameCollection: "invalid_system_views.collection",
to: "invalid_system_views.collection2",
dropTarget: true
};
assert.commandWorked(viewsDB.adminCommand(renameCommand),
makeErrorMessage("renameCollection"));
assert.commandWorked(viewsDB.runCommand({drop: "collection2"}), makeErrorMessage("drop"));
// Drop the offending view so that the validate hook succeeds.
assert.writeOK(viewsDB.system.views.remove(badViewDefinition));
}
runTest(
{_id: "invalid_system_views.badViewStringPipeline", viewOn: "collection", pipeline: "bad"});
runTest({
_id: "invalid_system_views.badViewEmptyObjectPipeline",
viewOn: "collection",
pipeline: {}
});
runTest(
{_id: "invalid_system_views.badViewNumericalPipeline", viewOn: "collection", pipeline: 7});
runTest({
_id: "invalid_system_views.badViewArrayWithIntegerPipeline",
viewOn: "collection",
pipeline: [1]
});
runTest({
_id: "invalid_system_views.badViewArrayWithEmptyArrayPipeline",
viewOn: "collection",
pipeline: [[]]
});
runTest({_id: 7, viewOn: "collection", pipeline: []});
runTest({_id: "invalid_system_views.embedded\0null", viewOn: "collection", pipeline: []});
runTest({_id: "invalidNotFullyQualifiedNs", viewOn: "collection", pipeline: []});
runTest({_id: "invalid_system_views.missingViewOnField", pipeline: []});
}());
|
