1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
|
/**
* When two concurrent identical upsert operations are performed, for which a unique index exists on
* the query values, it is possible that they will both attempt to perform an insert with one of
* the two failing on the unique index constraint. This test confirms that the failed insert will be
* retried, resulting in an update.
*
* @tags: [requires_replication]
*/
(function() {
"use strict";
load("jstests/libs/curop_helpers.js"); // For waitForCurOpByFailPoint().
const rst = new ReplSetTest({nodes: 1});
rst.startSet();
rst.initiate();
const testDB = rst.getPrimary().getDB("test");
const adminDB = testDB.getSiblingDB("admin");
const collName = "upsert_duplicate_key_retry_findAndModify";
const testColl = testDB.getCollection(collName);
testDB.runCommand({drop: collName});
function performUpsert() {
// This function is called from startParallelShell(), so closed-over variables will not be
// available. We must re-obtain the value of 'testColl' in the function body.
const testColl =
db.getMongo().getDB("test").getCollection("upsert_duplicate_key_retry_findAndModify");
testColl.findAndModify({query: {x: 3}, update: {$inc: {y: 1}}, upsert: true});
}
assert.commandWorked(testColl.createIndex({x: 1}, {unique: true}));
// Will hang upsert operations just prior to performing an insert.
assert.commandWorked(testDB.adminCommand(
{configureFailPoint: "hangBeforeFindAndModifyPerformsUpdate", mode: "alwaysOn"}));
const awaitUpdate1 = startParallelShell(performUpsert, rst.ports[0]);
const awaitUpdate2 = startParallelShell(performUpsert, rst.ports[0]);
// Query current operations until 2 matching operations are found.
assert.soon(() => {
const curOps = waitForCurOpByFailPointNoNS(adminDB, "hangBeforeFindAndModifyPerformsUpdate");
return curOps.length === 2;
});
assert.commandWorked(testDB.adminCommand(
{configureFailPoint: "hangBeforeFindAndModifyPerformsUpdate", mode: "off"}));
awaitUpdate1();
awaitUpdate2();
const cursor = testColl.find({}, {_id: 0});
assert.eq(cursor.next(), {x: 3, y: 2});
assert(!cursor.hasNext(), cursor.toArray());
// Confirm that oplog entries exist for both insert and update operation.
const oplogColl = testDB.getSiblingDB("local").getCollection("oplog.rs");
assert.eq(
1,
oplogColl.find({"op": "i", "ns": "test.upsert_duplicate_key_retry_findAndModify"}).itcount());
assert.eq(
1,
oplogColl.find({"op": "u", "ns": "test.upsert_duplicate_key_retry_findAndModify"}).itcount());
//
// Confirm DuplicateKey error for cases that should not be retried.
//
assert.commandWorked(testDB.runCommand({drop: collName}));
assert.commandWorked(testColl.createIndex({x: 1}, {unique: true}));
// DuplicateKey error on replacement-style upsert, where the unique index key value to be
// written does not match the value of the query predicate.
assert.commandWorked(testColl.insert({_id: 1, 'a': 12345}));
assert.throws(function() {
testColl.findAndModify({query: {x: 3}, update: {}, upsert: true});
}, []);
// DuplicateKey error on update-style upsert, where the unique index key value to be written
// does not match the value of the query predicate.
assert.commandWorked(testColl.remove({}));
assert.commandWorked(testColl.insert({x: 3}));
assert.commandWorked(testColl.insert({x: 4}));
assert.throws(function() {
testColl.findAndModify({query: {x: 3}, update: {$inc: {x: 1}}, upsert: true});
}, []);
rst.stopSet();
})();
|
