1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
|
/**
* Copyright 2017 MongoDB Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* As a special exception, the copyright holders give permission to link the
* code of portions of this program with the OpenSSL library under certain
* conditions as described in each individual source file and distribute
* linked combinations including the program with the OpenSSL library. You
* must comply with the GNU Affero General Public License in all respects for
* all of the code used other than as permitted herein. If you modify file(s)
* with this exception, you may extend this exception to your version of the
* file(s), but you are not obligated to do so. If you do not wish to do so,
* delete this exception statement from your version. If you delete this
* exception statement from all source files in the program, then also delete
* it in the license file.
*/
#include "mongo/db/repl/replication_consistency_markers_impl.h"
#include "mongo/platform/basic.h"
#include "mongo/db/client.h"
#include "mongo/db/concurrency/d_concurrency.h"
#include "mongo/db/concurrency/write_conflict_exception.h"
#include "mongo/db/db_raii.h"
#include "mongo/db/dbhelpers.h"
#include "mongo/db/namespace_string.h"
#include "mongo/db/operation_context.h"
#include "mongo/db/repl/replication_coordinator.h"
#include "mongo/db/repl/replication_coordinator_mock.h"
#include "mongo/db/repl/storage_interface_impl.h"
#include "mongo/db/service_context_d_test_fixture.h"
#include "mongo/db/storage/recovery_unit_noop.h"
#include "mongo/stdx/memory.h"
#include "mongo/unittest/unittest.h"
#include "mongo/util/assert_util.h"
#include "mongo/util/mongoutils/str.h"
namespace {
using namespace mongo;
using namespace mongo::repl;
/**
* Generates a unique namespace from the test registration agent.
*/
template <typename T>
NamespaceString makeNamespace(const T& t, const std::string& suffix = "") {
return NamespaceString(std::string("local." + t.getSuiteName() + "_" + t.getTestName())
.substr(0, NamespaceString::MaxNsCollectionLen - suffix.length()) +
suffix);
}
/**
* Returns min valid document.
*/
BSONObj getMinValidDocument(OperationContext* opCtx, const NamespaceString& minValidNss) {
return writeConflictRetry(opCtx, "getMinValidDocument", minValidNss.ns(), [opCtx, minValidNss] {
Lock::DBLock dblk(opCtx, minValidNss.db(), MODE_IS);
Lock::CollectionLock lk(opCtx->lockState(), minValidNss.ns(), MODE_IS);
BSONObj mv;
if (Helpers::getSingleton(opCtx, minValidNss.ns().c_str(), mv)) {
return mv;
}
return mv;
});
}
/**
* Returns oplog truncate after point document.
*/
BSONObj getOplogTruncateAfterPointDocument(OperationContext* opCtx,
const NamespaceString& oplogTruncateAfterPointNss) {
return writeConflictRetry(
opCtx,
"getOplogTruncateAfterPointDocument",
oplogTruncateAfterPointNss.ns(),
[opCtx, oplogTruncateAfterPointNss] {
Lock::DBLock dblk(opCtx, oplogTruncateAfterPointNss.db(), MODE_IS);
Lock::CollectionLock lk(opCtx->lockState(), oplogTruncateAfterPointNss.ns(), MODE_IS);
BSONObj mv;
if (Helpers::getSingleton(opCtx, oplogTruncateAfterPointNss.ns().c_str(), mv)) {
return mv;
}
return mv;
});
}
/**
* Returns checkpoint timestamp document.
*/
BSONObj getCheckpointTimestampDocument(OperationContext* opCtx,
const NamespaceString& checkpointTimestampNss) {
return writeConflictRetry(
opCtx,
"getCheckpointTimestampDocument",
checkpointTimestampNss.ns(),
[opCtx, checkpointTimestampNss] {
Lock::DBLock dblk(opCtx, checkpointTimestampNss.db(), MODE_IS);
Lock::CollectionLock lk(opCtx->lockState(), checkpointTimestampNss.ns(), MODE_IS);
BSONObj mv;
if (Helpers::getSingleton(opCtx, checkpointTimestampNss.ns().c_str(), mv)) {
return mv;
}
return mv;
});
}
class ReplicationConsistencyMarkersTest : public ServiceContextMongoDTest {
protected:
OperationContext* getOperationContext() {
return _opCtx.get();
}
StorageInterface* getStorageInterface() {
return _storageInterface.get();
}
private:
void setUp() override {
ServiceContextMongoDTest::setUp();
_createOpCtx();
auto replCoord = stdx::make_unique<ReplicationCoordinatorMock>(getServiceContext());
ReplicationCoordinator::set(getServiceContext(), std::move(replCoord));
_storageInterface = stdx::make_unique<StorageInterfaceImpl>();
}
void tearDown() override {
_opCtx.reset(nullptr);
_storageInterface.reset();
ServiceContextMongoDTest::tearDown();
}
void _createOpCtx() {
_opCtx = cc().makeOperationContext();
}
ServiceContext::UniqueOperationContext _opCtx;
std::unique_ptr<StorageInterfaceImpl> _storageInterface;
};
/**
* Recovery unit that tracks if waitUntilDurable() is called.
*/
class RecoveryUnitWithDurabilityTracking : public RecoveryUnitNoop {
public:
bool waitUntilDurable() override;
bool waitUntilDurableCalled = false;
};
bool RecoveryUnitWithDurabilityTracking::waitUntilDurable() {
waitUntilDurableCalled = true;
return RecoveryUnitNoop::waitUntilDurable();
}
TEST_F(ReplicationConsistencyMarkersTest, InitialSyncFlag) {
auto minValidNss = makeNamespace(_agent, "minValid");
auto oplogTruncateAfterPointNss = makeNamespace(_agent, "oplogTruncateAfterPoint");
auto checkpointTimestampNss = makeNamespace(_agent, "checkpointTimestamp");
ReplicationConsistencyMarkersImpl consistencyMarkers(
getStorageInterface(), minValidNss, oplogTruncateAfterPointNss, checkpointTimestampNss);
auto opCtx = getOperationContext();
consistencyMarkers.initializeMinValidDocument(opCtx);
// Initial sync flag should be unset after initializing a new storage engine.
ASSERT_FALSE(consistencyMarkers.getInitialSyncFlag(opCtx));
// Setting initial sync flag should affect getInitialSyncFlag() result.
consistencyMarkers.setInitialSyncFlag(opCtx);
ASSERT_TRUE(consistencyMarkers.getInitialSyncFlag(opCtx));
// Check min valid document using storage engine interface.
auto minValidDocument = getMinValidDocument(opCtx, minValidNss);
ASSERT_TRUE(minValidDocument.hasField(MinValidDocument::kInitialSyncFlagFieldName));
ASSERT_TRUE(minValidDocument.getBoolField(MinValidDocument::kInitialSyncFlagFieldName));
// Clearing initial sync flag should affect getInitialSyncFlag() result.
consistencyMarkers.clearInitialSyncFlag(opCtx);
ASSERT_FALSE(consistencyMarkers.getInitialSyncFlag(opCtx));
}
TEST_F(ReplicationConsistencyMarkersTest, GetMinValidAfterSettingInitialSyncFlagWorks) {
auto minValidNss = makeNamespace(_agent, "minValid");
auto oplogTruncateAfterPointNss = makeNamespace(_agent, "oplogTruncateAfterPoint");
auto checkpointTimestampNss = makeNamespace(_agent, "checkpointTimestamp");
ReplicationConsistencyMarkersImpl consistencyMarkers(
getStorageInterface(), minValidNss, oplogTruncateAfterPointNss, checkpointTimestampNss);
auto opCtx = getOperationContext();
consistencyMarkers.initializeMinValidDocument(opCtx);
// Initial sync flag should be unset after initializing a new storage engine.
ASSERT_FALSE(consistencyMarkers.getInitialSyncFlag(opCtx));
// Setting initial sync flag should affect getInitialSyncFlag() result.
consistencyMarkers.setInitialSyncFlag(opCtx);
ASSERT_TRUE(consistencyMarkers.getInitialSyncFlag(opCtx));
ASSERT(consistencyMarkers.getMinValid(opCtx).isNull());
ASSERT(consistencyMarkers.getAppliedThrough(opCtx).isNull());
ASSERT(consistencyMarkers.getOplogTruncateAfterPoint(opCtx).isNull());
}
TEST_F(ReplicationConsistencyMarkersTest, ReplicationConsistencyMarkers) {
auto minValidNss = makeNamespace(_agent, "minValid");
auto oplogTruncateAfterPointNss = makeNamespace(_agent, "oplogTruncateAfterPoint");
auto checkpointTimestampNss = makeNamespace(_agent, "checkpointTimestamp");
ReplicationConsistencyMarkersImpl consistencyMarkers(
getStorageInterface(), minValidNss, oplogTruncateAfterPointNss, checkpointTimestampNss);
auto opCtx = getOperationContext();
consistencyMarkers.initializeMinValidDocument(opCtx);
// MinValid boundaries should all be null after initializing a new storage engine.
ASSERT(consistencyMarkers.getMinValid(opCtx).isNull());
ASSERT(consistencyMarkers.getAppliedThrough(opCtx).isNull());
ASSERT(consistencyMarkers.getOplogTruncateAfterPoint(opCtx).isNull());
ASSERT(consistencyMarkers.getCheckpointTimestamp(opCtx).isNull());
// Setting min valid boundaries should affect getMinValid() result.
OpTime startOpTime({Seconds(123), 0}, 1LL);
OpTime endOpTime({Seconds(456), 0}, 1LL);
consistencyMarkers.setAppliedThrough(opCtx, startOpTime);
consistencyMarkers.setMinValid(opCtx, endOpTime);
consistencyMarkers.setOplogTruncateAfterPoint(opCtx, endOpTime.getTimestamp());
consistencyMarkers.writeCheckpointTimestamp(opCtx, endOpTime.getTimestamp());
ASSERT_EQ(consistencyMarkers.getAppliedThrough(opCtx), startOpTime);
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), endOpTime);
ASSERT_EQ(consistencyMarkers.getOplogTruncateAfterPoint(opCtx), endOpTime.getTimestamp());
ASSERT_EQ(consistencyMarkers.getCheckpointTimestamp(opCtx), endOpTime.getTimestamp());
// setMinValid always changes minValid, but setMinValidToAtLeast only does if higher.
consistencyMarkers.setMinValid(opCtx, startOpTime); // Forcibly lower it.
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), startOpTime);
consistencyMarkers.setMinValidToAtLeast(opCtx, endOpTime); // Higher than current (sets it).
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), endOpTime);
consistencyMarkers.setMinValidToAtLeast(opCtx, startOpTime); // Lower than current (no-op).
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), endOpTime);
// Check min valid document using storage engine interface.
auto minValidDocument = getMinValidDocument(opCtx, minValidNss);
ASSERT_TRUE(minValidDocument.hasField(MinValidDocument::kAppliedThroughFieldName));
ASSERT_TRUE(minValidDocument[MinValidDocument::kAppliedThroughFieldName].isABSONObj());
ASSERT_EQUALS(startOpTime,
unittest::assertGet(OpTime::parseFromOplogEntry(
minValidDocument[MinValidDocument::kAppliedThroughFieldName].Obj())));
ASSERT_EQUALS(endOpTime, unittest::assertGet(OpTime::parseFromOplogEntry(minValidDocument)));
// Check oplog truncate after point document.
auto oplogTruncateAfterPointDocument =
getOplogTruncateAfterPointDocument(opCtx, oplogTruncateAfterPointNss);
ASSERT_EQUALS(endOpTime.getTimestamp(),
oplogTruncateAfterPointDocument
[OplogTruncateAfterPointDocument::kOplogTruncateAfterPointFieldName]
.timestamp());
// Check checkpoint timestamp document.
auto checkpointTimestampDocument =
getCheckpointTimestampDocument(opCtx, checkpointTimestampNss);
ASSERT_EQUALS(
endOpTime.getTimestamp(),
checkpointTimestampDocument[CheckpointTimestampDocument::kCheckpointTimestampFieldName]
.timestamp());
// Recovery unit will be owned by "opCtx".
RecoveryUnitWithDurabilityTracking* recoveryUnit = new RecoveryUnitWithDurabilityTracking();
opCtx->setRecoveryUnit(recoveryUnit, OperationContext::kNotInUnitOfWork);
// Set min valid without waiting for the changes to be durable.
OpTime endOpTime2({Seconds(789), 0}, 1LL);
consistencyMarkers.setMinValid(opCtx, endOpTime2);
consistencyMarkers.clearAppliedThrough(opCtx, {});
ASSERT_EQUALS(consistencyMarkers.getAppliedThrough(opCtx), OpTime());
ASSERT_EQUALS(consistencyMarkers.getMinValid(opCtx), endOpTime2);
ASSERT_FALSE(recoveryUnit->waitUntilDurableCalled);
}
TEST_F(ReplicationConsistencyMarkersTest, SetMinValidOnPVChange) {
auto minValidNss = makeNamespace(_agent, "minValid");
auto oplogTruncateAfterPointNss = makeNamespace(_agent, "oplogTruncateAfterPoint");
auto checkpointTimestampNss = makeNamespace(_agent, "checkpointTimestamp");
ReplicationConsistencyMarkersImpl consistencyMarkers(
getStorageInterface(), minValidNss, oplogTruncateAfterPointNss, checkpointTimestampNss);
auto opCtx = getOperationContext();
consistencyMarkers.initializeMinValidDocument(opCtx);
auto advanceAndCheckMinValidOpTime = [&](OpTime advanceTo, OpTime expected) {
consistencyMarkers.setMinValidToAtLeast(opCtx, advanceTo);
ASSERT_EQUALS(expected, consistencyMarkers.getMinValid(opCtx));
};
// Set minValid in PV 1.
OpTime startOpTime({Seconds(20), 0}, 1LL);
advanceAndCheckMinValidOpTime(startOpTime, startOpTime);
// In rollback, minValid is when the date becomes consistent and never goes back.
OpTime rollbackOpTime({Seconds(10), 0}, 1LL);
advanceAndCheckMinValidOpTime(rollbackOpTime, startOpTime);
// Writes arrive, so minValid advances.
OpTime opTime1({Seconds(30), 0}, 1LL);
advanceAndCheckMinValidOpTime(opTime1, opTime1);
// A new term starts and oplog diverges, so the timestamp is lower.
OpTime newTermOpTime({Seconds(20), 0}, 2LL);
advanceAndCheckMinValidOpTime(newTermOpTime, newTermOpTime);
// We should never advance minValid to a lower term, but verify it never goes back even if the
// timestamp is higher.
OpTime invalidOpTime({Seconds(80), 0}, 1LL);
advanceAndCheckMinValidOpTime(invalidOpTime, newTermOpTime);
// PV downgrade to PV0
OpTime downgradeOpTime({Seconds(50), 0}, -1LL);
advanceAndCheckMinValidOpTime(downgradeOpTime, downgradeOpTime);
// Writes arrive in PV0.
OpTime opTime2({Seconds(60), 0}, -1LL);
advanceAndCheckMinValidOpTime(opTime2, opTime2);
// PV upgrade again.
OpTime upgradeOpTime({Seconds(70), 0}, 0LL);
advanceAndCheckMinValidOpTime(upgradeOpTime, upgradeOpTime);
}
TEST_F(ReplicationConsistencyMarkersTest, OplogTruncateAfterPointUpgrade) {
auto minValidNss = makeNamespace(_agent, "minValid");
auto oplogTruncateAfterPointNss = makeNamespace(_agent, "oplogTruncateAfterPoint");
auto checkpointTimestampNss = makeNamespace(_agent, "checkpointTimestamp");
ReplicationConsistencyMarkersImpl consistencyMarkers(
getStorageInterface(), minValidNss, oplogTruncateAfterPointNss, checkpointTimestampNss);
auto opCtx = getOperationContext();
Timestamp time1(Seconds(123), 0);
Timestamp time2(Seconds(456), 0);
OpTime minValidTime(Timestamp(789), 2);
// Insert the old oplogDeleteFromPoint and make sure getOplogTruncateAfterPoint() returns it.
ASSERT_OK(getStorageInterface()->createCollection(opCtx, minValidNss, {}));
ASSERT_OK(getStorageInterface()->insertDocument(
opCtx,
minValidNss,
TimestampedBSONObj{BSON("_id" << OID::gen() << MinValidDocument::kMinValidTimestampFieldName
<< minValidTime.getTimestamp()
<< MinValidDocument::kMinValidTermFieldName
<< minValidTime.getTerm()
<< MinValidDocument::kOldOplogDeleteFromPointFieldName
<< time1),
Timestamp(0)},
OpTime::kUninitializedTerm));
consistencyMarkers.initializeMinValidDocument(opCtx);
// Set the feature compatibility version to 3.6.
serverGlobalParams.featureCompatibility.setVersion(
ServerGlobalParams::FeatureCompatibility::Version::kFullyUpgradedTo36);
// Check that we see no oplog truncate after point in FCV 3.6.
ASSERT(consistencyMarkers.getOplogTruncateAfterPoint(opCtx).isNull());
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), minValidTime);
// Set the feature compatibility version to 3.4.
serverGlobalParams.featureCompatibility.setVersion(
ServerGlobalParams::FeatureCompatibility::Version::kFullyDowngradedTo34);
// Check that we see the old oplog delete from point in FCV 3.4.
ASSERT_EQ(consistencyMarkers.getOplogTruncateAfterPoint(opCtx), time1);
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), minValidTime);
// Check that the minValid document has the oplog delete from point.
auto minValidDocument = getMinValidDocument(opCtx, minValidNss);
ASSERT_TRUE(minValidDocument.hasField(MinValidDocument::kOldOplogDeleteFromPointFieldName));
consistencyMarkers.removeOldOplogDeleteFromPointField(opCtx);
// Check that the minValid document does not have the oplog delete from point.
minValidDocument = getMinValidDocument(opCtx, minValidNss);
ASSERT_FALSE(minValidDocument.hasField(MinValidDocument::kOldOplogDeleteFromPointFieldName));
// Check that after removing the old oplog delete from point, that we do not see the oplog
// truncate after point in FCV 3.4.
ASSERT(consistencyMarkers.getOplogTruncateAfterPoint(opCtx).isNull());
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), minValidTime);
// Set the feature compatibility version to 3.6.
serverGlobalParams.featureCompatibility.setVersion(
ServerGlobalParams::FeatureCompatibility::Version::kFullyUpgradedTo36);
// Check that after removing the old oplog delete from point, that we do not see the oplog
// truncate after point in FCV 3.6.
ASSERT(consistencyMarkers.getOplogTruncateAfterPoint(opCtx).isNull());
ASSERT_EQ(consistencyMarkers.getMinValid(opCtx), minValidTime);
// Check that we can set the oplog truncate after point.
consistencyMarkers.setOplogTruncateAfterPoint(opCtx, time2);
ASSERT_EQ(consistencyMarkers.getOplogTruncateAfterPoint(opCtx), time2);
}
} // namespace
|