1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
|
/**
* Copyright (C) 2018-present MongoDB, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the Server Side Public License, version 1,
* as published by MongoDB, Inc.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* Server Side Public License for more details.
*
* You should have received a copy of the Server Side Public License
* along with this program. If not, see
* <http://www.mongodb.com/licensing/server-side-public-license>.
*
* As a special exception, the copyright holders give permission to link the
* code of portions of this program with the OpenSSL library under certain
* conditions as described in each individual source file and distribute
* linked combinations including the program with the OpenSSL library. You
* must comply with the Server Side Public License in all respects for
* all of the code used other than as permitted herein. If you modify file(s)
* with this exception, you may extend this exception to your version of the
* file(s), but you are not obligated to do so. If you do not wish to do so,
* delete this exception statement from your version. If you delete this
* exception statement from all source files in the program, then also delete
* it in the license file.
*/
#include "mongo/platform/basic.h"
#include "mongo/db/update/object_replace_node.h"
#include "mongo/bson/mutable/algorithm.h"
#include "mongo/bson/mutable/mutable_bson_test_utils.h"
#include "mongo/db/json.h"
#include "mongo/db/logical_clock.h"
#include "mongo/db/update/update_node_test_fixture.h"
#include "mongo/unittest/unittest.h"
namespace mongo {
namespace {
using ObjectReplaceNodeTest = UpdateNodeTest;
using mongo::mutablebson::Element;
using mongo::mutablebson::countChildren;
TEST_F(ObjectReplaceNodeTest, Noop) {
auto obj = fromjson("{a: 1, b: 2}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{a: 1, b: 2}"));
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_TRUE(result.noop);
ASSERT_FALSE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{a: 1, b: 2}"), doc);
ASSERT_TRUE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, ShouldNotCreateIdIfNoIdExistsAndNoneIsSpecified) {
auto obj = fromjson("{a: 1, b: 2}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{c: 1, d: 2}"));
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{a: 1, b: 2}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{a: 1, b: 2}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, ShouldPreserveIdOfExistingDocumentIfIdNotSpecified) {
auto obj = fromjson("{a: 1, b: 2}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0, c: 1, d: 2}"));
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{_id: 0, a: 1, b: 2}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{_id: 0, a: 1, b: 2}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, ShouldSucceedWhenImmutableIdIsNotModified) {
auto obj = fromjson("{_id: 0, a: 1, b: 2}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0, c: 1, d: 2}"));
addImmutablePath("_id");
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{_id: 0, a: 1, b: 2}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{_id: 0, a: 1, b: 2}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, IdTimestampNotModified) {
auto obj = fromjson("{_id: Timestamp(0,0)}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{}"));
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{_id: Timestamp(0,0)}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{_id: Timestamp(0,0)}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, NonIdTimestampsModified) {
auto obj = fromjson("{a: Timestamp(0,0), b: Timestamp(0,0)}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{}"));
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(doc.root().countChildren(), 2U);
auto elemA = doc.root()["a"];
ASSERT_TRUE(elemA.ok());
ASSERT_EQUALS(elemA.getType(), BSONType::bsonTimestamp);
ASSERT_NOT_EQUALS(0U, elemA.getValueTimestamp().getSecs());
ASSERT_NOT_EQUALS(0U, elemA.getValueTimestamp().getInc());
auto elemB = doc.root()["b"];
ASSERT_TRUE(elemB.ok());
ASSERT_EQUALS(elemB.getType(), BSONType::bsonTimestamp);
ASSERT_NOT_EQUALS(0U, elemB.getValueTimestamp().getSecs());
ASSERT_NOT_EQUALS(0U, elemB.getValueTimestamp().getInc());
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(doc, getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, ComplexDoc) {
auto obj = fromjson("{a: 1, b: [0, 1, 2], c: {d: 1}}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{a: 1, b: [0, 2, 2], e: []}"));
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{a: 1, b: [0, 1, 2], c: {d: 1}}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{a: 1, b: [0, 1, 2], c: {d: 1}}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, CannotRemoveImmutablePath) {
auto obj = fromjson("{_id: 0, c: 1}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0, a: {b: 1}}"));
addImmutablePath("a.b");
ASSERT_THROWS_CODE_AND_WHAT(node.apply(getApplyParams(doc.root())),
AssertionException,
ErrorCodes::ImmutableField,
"After applying the update, the 'a.b' (required and immutable) "
"field was found to have been removed --{ _id: 0, a: { b: 1 } }");
}
TEST_F(ObjectReplaceNodeTest, IdFieldIsNotRemoved) {
auto obj = fromjson("{a: 1}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0, b: 1}"));
addImmutablePath("_id");
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{_id: 0, a: 1}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{_id: 0, a: 1}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, CannotReplaceImmutablePathWithArrayField) {
auto obj = fromjson("{_id: 0, a: [{b: 1}]}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0, a: {b: 1}}"));
addImmutablePath("a.b");
ASSERT_THROWS_CODE_AND_WHAT(node.apply(getApplyParams(doc.root())),
AssertionException,
ErrorCodes::NotSingleValueField,
"After applying the update to the document, the (immutable) field "
"'a.b' was found to be an array or array descendant.");
}
TEST_F(ObjectReplaceNodeTest, CannotMakeImmutablePathArrayDescendant) {
auto obj = fromjson("{_id: 0, a: [1]}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0, a: {'0': 1}}"));
addImmutablePath("a.0");
ASSERT_THROWS_CODE_AND_WHAT(node.apply(getApplyParams(doc.root())),
AssertionException,
ErrorCodes::NotSingleValueField,
"After applying the update to the document, the (immutable) field "
"'a.0' was found to be an array or array descendant.");
}
TEST_F(ObjectReplaceNodeTest, CannotModifyImmutablePath) {
auto obj = fromjson("{_id: 0, a: {b: 2}}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0, a: {b: 1}}"));
addImmutablePath("a.b");
ASSERT_THROWS_CODE_AND_WHAT(node.apply(getApplyParams(doc.root())),
AssertionException,
ErrorCodes::ImmutableField,
"After applying the update, the (immutable) field 'a.b' was found "
"to have been altered to b: 2");
}
TEST_F(ObjectReplaceNodeTest, CannotModifyImmutableId) {
auto obj = fromjson("{_id: 1}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{_id: 0}"));
addImmutablePath("_id");
ASSERT_THROWS_CODE_AND_WHAT(node.apply(getApplyParams(doc.root())),
AssertionException,
ErrorCodes::ImmutableField,
"After applying the update, the (immutable) field '_id' was found "
"to have been altered to _id: 1");
}
TEST_F(ObjectReplaceNodeTest, CanAddImmutableField) {
auto obj = fromjson("{a: {b: 1}}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{c: 1}"));
addImmutablePath("a.b");
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{a: {b: 1}}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{a: {b: 1}}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, CanAddImmutableId) {
auto obj = fromjson("{_id: 0}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{c: 1}"));
addImmutablePath("_id");
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{_id: 0}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{_id: 0}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, CannotCreateDollarPrefixedNameWhenValidateForStorageIsTrue) {
auto obj = fromjson("{a: {b: 1, $bad: 1}}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{}"));
ASSERT_THROWS_CODE_AND_WHAT(
node.apply(getApplyParams(doc.root())),
AssertionException,
ErrorCodes::DollarPrefixedFieldName,
"The dollar ($) prefixed field '$bad' in 'a.$bad' is not valid for storage.");
}
TEST_F(ObjectReplaceNodeTest, CanCreateDollarPrefixedNameWhenValidateForStorageIsFalse) {
auto obj = fromjson("{a: {b: 1, $bad: 1}}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{}"));
setValidateForStorage(false);
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{a: {b: 1, $bad: 1}}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
ASSERT_EQUALS(fromjson("{a: {b: 1, $bad: 1}}"), getLogDoc());
}
TEST_F(ObjectReplaceNodeTest, NoLogBuilder) {
auto obj = fromjson("{a: 1}");
ObjectReplaceNode node(obj);
mutablebson::Document doc(fromjson("{b: 1}"));
setLogBuilderToNull();
auto result = node.apply(getApplyParams(doc.root()));
ASSERT_FALSE(result.noop);
ASSERT_TRUE(result.indexesAffected);
ASSERT_EQUALS(fromjson("{a: 1}"), doc);
ASSERT_FALSE(doc.isInPlaceModeEnabled());
}
} // namespace
} // namespace mongo
|