summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelipe Borges <felipeborges@gnome.org>2021-05-26 10:57:43 +0200
committerFelipe Borges <felipeborges@gnome.org>2021-05-26 15:12:16 +0200
commit0b7a7f95f84f775be38e5533a37f93567fba2b59 (patch)
tree227573f0699e2b4903968449dfdec106fafbe1c2
parent59ca11451b536937b29bbcbb8d5745275d0b94ca (diff)
downloadnautilus-0b7a7f95f84f775be38e5533a37f93567fba2b59.tar.gz
application: Stop updating previewer on windows focus
It is a very specific corner case when the previewer (sushi) is being used alongside multiple windows of Nautilus. This causes a race condition when the change of active-window notification arrives out of order with the check for the previewer "Visible" property, making the update process loop when previewing videos. Fixes #1823
-rw-r--r--src/nautilus-application.c15
1 files changed, 0 insertions, 15 deletions
diff --git a/src/nautilus-application.c b/src/nautilus-application.c
index 73153f548..5deae5cc9 100644
--- a/src/nautilus-application.c
+++ b/src/nautilus-application.c
@@ -1261,20 +1261,6 @@ update_previewer_selection (NautilusApplication *self,
}
static void
-on_application_active_window_changed (NautilusApplication *self,
- GParamSpec *pspec,
- gpointer user_data)
-{
- GtkWindow *window;
-
- window = gtk_application_get_active_window (GTK_APPLICATION (self));
- if (NAUTILUS_IS_WINDOW (window))
- {
- update_previewer_selection (self, NAUTILUS_WINDOW (window));
- }
-}
-
-static void
on_application_shutdown (GApplication *application,
gpointer user_data)
{
@@ -1358,7 +1344,6 @@ nautilus_application_startup_common (NautilusApplication *self)
nautilus_profile_end (NULL);
- g_signal_connect (self, "notify::active-window", G_CALLBACK (on_application_active_window_changed), NULL);
g_signal_connect (self, "shutdown", G_CALLBACK (on_application_shutdown), NULL);
g_signal_connect_object (gtk_icon_theme_get_default (),