diff options
| author | Ondrej Holy <oholy@redhat.com> | 2020-11-04 08:24:08 +0000 |
|---|---|---|
| committer | Ondrej Holy <oholy@redhat.com> | 2020-11-18 09:00:59 +0000 |
| commit | d94c25becda80c6d6b88bb84e585613439d0d317 (patch) | |
| tree | ab62fd04a2ea3e3278c13cfac5d51cb5fc9833ff | |
| parent | 10db2d539709e34df9bc739a0fd1056bdc764b85 (diff) | |
| download | nautilus-d94c25becda80c6d6b88bb84e585613439d0d317.tar.gz | |
batch-rename-utilities: Fix dialog crashes
The batch rename dialog crashes when it is opened for a second time.
This is because the TrackerSparqlConnection object is unreffed after
the first use. However, nautilus_tracker_get_miner_fs_connection
documentation clearly says that the returned should not be unreffed
because it is globally shared singleton. Let's remove the problematic
g_object_unref statement to fix the crashes.
https://gitlab.gnome.org/GNOME/nautilus/-/issues/1651
(cherry picked from commit 50edb805d2181a723a099ea09e27f325ad0864a4)
| -rw-r--r-- | src/nautilus-batch-rename-utilities.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/nautilus-batch-rename-utilities.c b/src/nautilus-batch-rename-utilities.c index 0412a172e..49b9813ed 100644 --- a/src/nautilus-batch-rename-utilities.c +++ b/src/nautilus-batch-rename-utilities.c @@ -1150,7 +1150,6 @@ check_metadata_for_selection (NautilusBatchRenameDialog *dialog, batch_rename_dialog_query_callback, query_data); - g_object_unref (connection); g_string_free (query, TRUE); } |