summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorErnestas Kulik <ernestask@src.gnome.org>2016-11-05 21:08:36 +0200
committerCarlos Soriano <csoriano@gnome.org>2016-12-10 00:30:06 +0100
commit60ed383d127fe91f0ee9b7e5c656843908db8558 (patch)
treeab61d13fb478df7dc2ed35f026e32eeb79c1bb13
parent5a37fea5d3811239ef49a7c4bb7e384946a11508 (diff)
downloadnautilus-60ed383d127fe91f0ee9b7e5c656843908db8558.tar.gz
file: create filtered file lists in correct order
nautilus_file_list_filter() creates lists in the wrong order, causing files activation to occur in the same fashion. This is caused by double reversal of the file list when filtering files. https://bugzilla.gnome.org/show_bug.cgi?id=773988
-rw-r--r--src/nautilus-file.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/nautilus-file.c b/src/nautilus-file.c
index 7509f1ca9..c21f525b8 100644
--- a/src/nautilus-file.c
+++ b/src/nautilus-file.c
@@ -4121,15 +4121,13 @@ nautilus_file_list_filter (GList *files,
{
GList *filtered = NULL;
GList *l;
- GList *last;
GList *reversed;
*failed = NULL;
/* Avoid using g_list_append since it's O(n) */
reversed = g_list_copy (files);
reversed = g_list_reverse (reversed);
- last = g_list_last (reversed);
- for (l = last; l != NULL; l = l->prev)
+ for (l = reversed; l != NULL; l = l->next)
{
if (filter_function (l->data, user_data))
{