diff options
author | Maciej Stachowiak <mstachow@src.gnome.org> | 2000-09-03 17:04:55 +0000 |
---|---|---|
committer | Maciej Stachowiak <mstachow@src.gnome.org> | 2000-09-03 17:04:55 +0000 |
commit | 62e426c199b2e21df7f9b4909abc965786037a94 (patch) | |
tree | 7d104cd9def8bfc4435587d40f9459bcf869f537 | |
parent | 72fb6ec09e47b35cb28c0a6cef922580fa903129 (diff) | |
download | nautilus-62e426c199b2e21df7f9b4909abc965786037a94.tar.gz |
Added bug numbers for FIXMEs
* components/services/install/lib/eazel-install-protocols.c:
(eazel_install_fetch_package):
* components/services/login/nautilus-view/nautilus-login-view.c:
(nautilus_login_view_initialize):
* components/services/summary/nautilus-view/nautilus-summary-view.c
: (authn_cb_succeeded), (authn_cb_failed), (login_button_cb),
(nautilus_summary_view_initialize):
* components/tree/libmain.c: (tree_shlib_object_destroyed):
* components/tree/nautilus-tree-view.c:
* libnautilus-extensions/nautilus-link.c: (make_local_path):
* libnautilus-extensions/nautilus-search-bar-criterion.c:
(make_emblem_value_menu):
* src/file-manager/fm-directory-view.c:
(add_open_with_gtk_menu_item):
* src/nautilus-search-bar-criterion.c: (make_emblem_value_menu),
(emblems_changed_callback):
Added bug numbers for FIXMEs
-rw-r--r-- | ChangeLog | 21 | ||||
-rw-r--r-- | components/services/install/lib/eazel-install-protocols.c | 3 | ||||
-rw-r--r-- | components/services/login/nautilus-view/nautilus-login-view.c | 5 | ||||
-rw-r--r-- | components/services/summary/nautilus-summary-view.c | 8 | ||||
-rw-r--r-- | components/services/summary/nautilus-view/nautilus-summary-view.c | 8 | ||||
-rw-r--r-- | components/tree/libmain.c | 2 | ||||
-rw-r--r-- | components/tree/nautilus-tree-view.c | 12 | ||||
-rw-r--r-- | libnautilus-extensions/nautilus-link.c | 2 | ||||
-rw-r--r-- | libnautilus-extensions/nautilus-search-bar-criterion.c | 2 | ||||
-rw-r--r-- | libnautilus-private/nautilus-link.c | 2 | ||||
-rw-r--r-- | libnautilus-private/nautilus-search-bar-criterion.c | 2 | ||||
-rw-r--r-- | src/file-manager/fm-directory-view.c | 4 | ||||
-rw-r--r-- | src/nautilus-search-bar-criterion.c | 4 |
13 files changed, 53 insertions, 22 deletions
@@ -1,3 +1,24 @@ +2000-09-03 Maciej Stachowiak <mjs@eazel.com> + + * components/services/install/lib/eazel-install-protocols.c: + (eazel_install_fetch_package): + * components/services/login/nautilus-view/nautilus-login-view.c: + (nautilus_login_view_initialize): + * components/services/summary/nautilus-view/nautilus-summary-view.c + : (authn_cb_succeeded), (authn_cb_failed), (login_button_cb), + (nautilus_summary_view_initialize): + * components/tree/libmain.c: (tree_shlib_object_destroyed): + * components/tree/nautilus-tree-view.c: + * libnautilus-extensions/nautilus-link.c: (make_local_path): + * libnautilus-extensions/nautilus-search-bar-criterion.c: + (make_emblem_value_menu): + * src/file-manager/fm-directory-view.c: + (add_open_with_gtk_menu_item): + * src/nautilus-search-bar-criterion.c: (make_emblem_value_menu), + (emblems_changed_callback): + + Added bug numbers for FIXMEs + 2000-09-03 Pavel Cisler <pavel@eazel.com> * libnautilus-extensions/nautilus-directory-notify.h: diff --git a/components/services/install/lib/eazel-install-protocols.c b/components/services/install/lib/eazel-install-protocols.c index ae088e4b3..016bc5508 100644 --- a/components/services/install/lib/eazel-install-protocols.c +++ b/components/services/install/lib/eazel-install-protocols.c @@ -527,8 +527,7 @@ eazel_install_fetch_package (EazelInstall *service, #ifndef EAZEL_INSTALL_SLIM md5_get_digest_from_file (package, md5); /* - FIXME: bugzilla.eazel.c 2241 - until we get the md5 set in the xml parse, don't md5 check it + FIXME bugzilla.eazel.com 2241: until we get the md5 set in the xml parse, don't md5 check it if (strncmp (package->md5, md5, 16)!=0) { g_warning (_("MD5 mismatch, package may be compromised")); diff --git a/components/services/login/nautilus-view/nautilus-login-view.c b/components/services/login/nautilus-view/nautilus-login-view.c index 17a36771d..447ecc6a2 100644 --- a/components/services/login/nautilus-view/nautilus-login-view.c +++ b/components/services/login/nautilus-view/nautilus-login-view.c @@ -418,7 +418,10 @@ nautilus_login_view_initialize (NautilusLoginView *view) CORBA_exception_init (&ev); view->details->user_control = (EazelProxy_UserControl) oaf_activate_from_id (IID_EAZELPROXY, 0, NULL, &ev); if ( CORBA_NO_EXCEPTION != ev._major ) { - /* FIXME user should be warned that Ammonite may not be installed */ + /* FIXME bugzilla.eazel.com 2740: user should be + * warned that Ammonite may not be installed + */ + g_warning ("Couldn't instantiate eazel-proxy"); view->details->user_control = CORBA_OBJECT_NIL; } diff --git a/components/services/summary/nautilus-summary-view.c b/components/services/summary/nautilus-summary-view.c index bf0f392d1..a1a346c87 100644 --- a/components/services/summary/nautilus-summary-view.c +++ b/components/services/summary/nautilus-summary-view.c @@ -464,7 +464,7 @@ authn_cb_succeeded (const EazelProxy_User *user, gpointer state, CORBA_Environme view->details->pending_operation = Pending_None; gtk_widget_set_sensitive (view->details->login_button, TRUE); - /* FIXME-- what now? */ + /* FIXME bugzilla.eazel.com 2743: what now? */ g_message ("Login succeeded"); @@ -483,7 +483,7 @@ authn_cb_failed (const EazelProxy_User *user, const EazelProxy_AuthnFailInfo *in view->details->pending_operation = Pending_None; gtk_widget_set_sensitive (view->details->login_button, TRUE); - /* FIXME-- what now? */ + /* FIXME bugzilla.eazel.com 2744: what now? */ g_message ("Login FAILED"); @@ -534,7 +534,7 @@ login_button_cb (GtkWidget *button, NautilusSummaryView *view) if (CORBA_NO_EXCEPTION != ev._major) { g_warning ("Exception during EazelProxy login"); - /* FIXME cleanup after fail here */ + /* FIXME bugzilla.eazel.com 2745: cleanup after fail here */ } g_free (user_name); @@ -671,7 +671,7 @@ nautilus_summary_view_initialize (NautilusSummaryView *view) view->details->user_control = (EazelProxy_UserControl) oaf_activate_from_id (IID_EAZELPROXY, 0, NULL, &ev); if ( CORBA_NO_EXCEPTION != ev._major ) { - /* FIXME user should be warned that Ammonite may not be installed */ + /* FIXME bugzilla.eazel.com 2740: user should be warned that Ammonite may not be installed */ g_warning ("Couldn't instantiate eazel-proxy\n"); view->details->user_control = CORBA_OBJECT_NIL; } diff --git a/components/services/summary/nautilus-view/nautilus-summary-view.c b/components/services/summary/nautilus-view/nautilus-summary-view.c index bf0f392d1..a1a346c87 100644 --- a/components/services/summary/nautilus-view/nautilus-summary-view.c +++ b/components/services/summary/nautilus-view/nautilus-summary-view.c @@ -464,7 +464,7 @@ authn_cb_succeeded (const EazelProxy_User *user, gpointer state, CORBA_Environme view->details->pending_operation = Pending_None; gtk_widget_set_sensitive (view->details->login_button, TRUE); - /* FIXME-- what now? */ + /* FIXME bugzilla.eazel.com 2743: what now? */ g_message ("Login succeeded"); @@ -483,7 +483,7 @@ authn_cb_failed (const EazelProxy_User *user, const EazelProxy_AuthnFailInfo *in view->details->pending_operation = Pending_None; gtk_widget_set_sensitive (view->details->login_button, TRUE); - /* FIXME-- what now? */ + /* FIXME bugzilla.eazel.com 2744: what now? */ g_message ("Login FAILED"); @@ -534,7 +534,7 @@ login_button_cb (GtkWidget *button, NautilusSummaryView *view) if (CORBA_NO_EXCEPTION != ev._major) { g_warning ("Exception during EazelProxy login"); - /* FIXME cleanup after fail here */ + /* FIXME bugzilla.eazel.com 2745: cleanup after fail here */ } g_free (user_name); @@ -671,7 +671,7 @@ nautilus_summary_view_initialize (NautilusSummaryView *view) view->details->user_control = (EazelProxy_UserControl) oaf_activate_from_id (IID_EAZELPROXY, 0, NULL, &ev); if ( CORBA_NO_EXCEPTION != ev._major ) { - /* FIXME user should be warned that Ammonite may not be installed */ + /* FIXME bugzilla.eazel.com 2740: user should be warned that Ammonite may not be installed */ g_warning ("Couldn't instantiate eazel-proxy\n"); view->details->user_control = CORBA_OBJECT_NIL; } diff --git a/components/tree/libmain.c b/components/tree/libmain.c index eb67f897c..825f43791 100644 --- a/components/tree/libmain.c +++ b/components/tree/libmain.c @@ -39,7 +39,7 @@ static void tree_shlib_object_destroyed (GtkObject *object) { - /* FIXME: oaf_plugin_unuse can't possibly work! this sucks */ + /* FIXME bugzilla.eazel.com 2736: oaf_plugin_unuse can't possibly work! this sucks */ #if 0 oaf_plugin_unuse (gtk_object_get_user_data (object)); #endif diff --git a/components/tree/nautilus-tree-view.c b/components/tree/nautilus-tree-view.c index 822d79a61..8162b1e43 100644 --- a/components/tree/nautilus-tree-view.c +++ b/components/tree/nautilus-tree-view.c @@ -939,8 +939,16 @@ nautilus_tree_view_initialize (NautilusTreeView *view) static void disconnect_model_handlers (NautilusTreeView *view) { - /* stop monitoring all the nodes, then stop monitoring the - whole */ + NautilusTreeNode *node; + + node = nautilus_tree_model_get_node (view->details->model, + "file:///"); + + if (node != NULL) { + nautilus_tree_model_stop_monitoring_node_recursive (view->details->model, + node, + view); + } } diff --git a/libnautilus-extensions/nautilus-link.c b/libnautilus-extensions/nautilus-link.c index d3130a503..c22a80ba1 100644 --- a/libnautilus-extensions/nautilus-link.c +++ b/libnautilus-extensions/nautilus-link.c @@ -288,7 +288,7 @@ make_local_path (const char *image_uri) /* We must create the directory if it doesn't exist. */ /* FIXME bugzilla.eazel.com 2494: Is it OK to ignore the error here? */ - /* FIXME: This needs to make the path into a URI if it's going to use gnome_vfs. */ + /* FIXME bugzilla.eazel.com 2737: This needs to make the path into a URI if it's going to use gnome_vfs. */ gnome_vfs_make_directory (local_directory_path, REMOTE_ICON_DIR_PERMISSIONS); local_file_path = nautilus_make_path (local_directory_path, escaped_uri); diff --git a/libnautilus-extensions/nautilus-search-bar-criterion.c b/libnautilus-extensions/nautilus-search-bar-criterion.c index b28fa5d56..3c15f0390 100644 --- a/libnautilus-extensions/nautilus-search-bar-criterion.c +++ b/libnautilus-extensions/nautilus-search-bar-criterion.c @@ -699,7 +699,7 @@ make_emblem_value_menu (NautilusSearchBarCriterion *criterion) GtkWidget *value_option_menu, *value_menu; /* Add the items to the emblems menu here */ - /* FIXME: What are the variables for thumbnail icon height and width */ + /* FIXME bugzilla.eazel.com 2738: What are the variables for thumbnail icon height and width */ value_option_menu = gtk_option_menu_new (); value_menu = gtk_menu_new (); customization_data = nautilus_customization_data_new ("emblems", diff --git a/libnautilus-private/nautilus-link.c b/libnautilus-private/nautilus-link.c index d3130a503..c22a80ba1 100644 --- a/libnautilus-private/nautilus-link.c +++ b/libnautilus-private/nautilus-link.c @@ -288,7 +288,7 @@ make_local_path (const char *image_uri) /* We must create the directory if it doesn't exist. */ /* FIXME bugzilla.eazel.com 2494: Is it OK to ignore the error here? */ - /* FIXME: This needs to make the path into a URI if it's going to use gnome_vfs. */ + /* FIXME bugzilla.eazel.com 2737: This needs to make the path into a URI if it's going to use gnome_vfs. */ gnome_vfs_make_directory (local_directory_path, REMOTE_ICON_DIR_PERMISSIONS); local_file_path = nautilus_make_path (local_directory_path, escaped_uri); diff --git a/libnautilus-private/nautilus-search-bar-criterion.c b/libnautilus-private/nautilus-search-bar-criterion.c index b28fa5d56..3c15f0390 100644 --- a/libnautilus-private/nautilus-search-bar-criterion.c +++ b/libnautilus-private/nautilus-search-bar-criterion.c @@ -699,7 +699,7 @@ make_emblem_value_menu (NautilusSearchBarCriterion *criterion) GtkWidget *value_option_menu, *value_menu; /* Add the items to the emblems menu here */ - /* FIXME: What are the variables for thumbnail icon height and width */ + /* FIXME bugzilla.eazel.com 2738: What are the variables for thumbnail icon height and width */ value_option_menu = gtk_option_menu_new (); value_menu = gtk_menu_new (); customization_data = nautilus_customization_data_new ("emblems", diff --git a/src/file-manager/fm-directory-view.c b/src/file-manager/fm-directory-view.c index 3ff2b8b3f..c66378865 100644 --- a/src/file-manager/fm-directory-view.c +++ b/src/file-manager/fm-directory-view.c @@ -2448,7 +2448,7 @@ append_selection_menu_subtree (FMDirectoryView *view, GTK_WIDGET (child_menu)); } -/* FIXME: John, you bozo, explain this confusing function in a comment +/* FIXME bugzilla.eazel.com 2734: John, you bozo, explain this confusing function in a comment * or redesign it out of existence. */ void @@ -2578,7 +2578,7 @@ add_open_with_gtk_menu_item (GtkMenu *menu, const char *label) { GtkWidget *menu_item; - /* FIXME: This is only called to add a separator? */ + /* FIXME bugzilla.eazel.com 2735: This is only called to add a separator? */ if (label != NULL) { menu_item = gtk_menu_item_new_with_label (label); } else { diff --git a/src/nautilus-search-bar-criterion.c b/src/nautilus-search-bar-criterion.c index fe215d849..7df2f0947 100644 --- a/src/nautilus-search-bar-criterion.c +++ b/src/nautilus-search-bar-criterion.c @@ -712,7 +712,7 @@ make_emblem_value_menu (NautilusSearchBarCriterion *criterion) GtkWidget *value_menu; /* Add the items to the emblems menu here */ - /* FIXME: What are the variables for thumbnail icon height and width */ + /* FIXME bugzilla.eazel.com 2738: What are the variables for thumbnail icon height and width */ value_menu = gtk_menu_new (); customization_data = nautilus_customization_data_new ("emblems", @@ -751,7 +751,7 @@ emblems_changed_callback (GtkObject *signaller, NautilusSearchBarCriterion *criterion; GtkWidget *menu_widget; - /* FIXME: check type here in some way */ + /* FIXME bugzilla.eazel.com 2739: check type here in some way */ criterion = NAUTILUS_SEARCH_BAR_CRITERION (data); if (criterion->details->type == NAUTILUS_EMBLEM_SEARCH_CRITERION) { |