summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUjjwal Kumar <ujjwalkumar0501@gmail.com>2020-04-06 21:46:21 +0530
committerAntónio Fernandes <antoniojpfernandes@gmail.com>2020-05-10 14:12:35 +0000
commit12b0e55ee99257d43165eb77ea5f13e97ba6e62d (patch)
tree9b838bf6589606de563ed1294bb7af33fdb342d6
parent26950288239b7c2dbfa90469b903439e09350bf7 (diff)
downloadnautilus-12b0e55ee99257d43165eb77ea5f13e97ba6e62d.tar.gz
files-view: Disable select-all while directory is loading
In the current state, it is possible to perform selection while the directory is loading which in some cases, may not select all the items. Performing select-all only selects the items that are loaded, till the point of performing the action. Since the loading state is already maintained, we can put a check for an on-going directory load while updating actions state. Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1389
-rw-r--r--src/nautilus-files-view.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/nautilus-files-view.c b/src/nautilus-files-view.c
index fa6156fec..5be047781 100644
--- a/src/nautilus-files-view.c
+++ b/src/nautilus-files-view.c
@@ -7766,7 +7766,8 @@ real_update_actions_state (NautilusFilesView *view)
action = g_action_map_lookup_action (G_ACTION_MAP (view_action_group),
"select-all");
g_simple_action_set_enabled (G_SIMPLE_ACTION (action),
- !nautilus_files_view_is_empty (view));
+ !nautilus_files_view_is_empty (view) &&
+ !priv->loading);
/* Toolbar menu actions */
g_action_group_change_action_state (view_action_group,