summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntónio Fernandes <antoniojpfernandes@gmail.com>2020-04-10 16:57:29 +0000
committerAntónio Fernandes <antoniojpfernandes@gmail.com>2020-04-10 16:57:29 +0000
commite0032461538bb054daba2749fe880bb62f7d30bb (patch)
treeb376162e349cddaba3e14390cb54c6511711212a
parent94386981209a26e02cb2d3d6edd75c3776a8f341 (diff)
downloadnautilus-e0032461538bb054daba2749fe880bb62f7d30bb.tar.gz
.desktop: Include traditional name as search keyword
Based on patches from Felipe Borges for other apps. Quoting him: The GNOME Shell search results are forwarded from the results of GLib's g_desktop_app_info_search() function, which matches the Name, Exec, Keywords, GenericName, X_GNOME_FullName, and Comment keys from desktop files[0]. Since Totem is now named "Videos", a query for "totem" would match the "Exec" key and present the application in the search results as expected. Unfortunately that doesn't happen for Flaptaked Totem, which would get its desktop file "Exec" key overwritten to something such as Exec=/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=totem org.gnome.Totem --new-document This way, searching for "totem" when only the Flatpaked version of it is installed returns no results. Searching for "Videos" presents the application as expected. Its been proposed in GLib to parse the "Exec" key for searches but that was rejected[1] because it would imply establishing an API which assumes that the command line behavior of Flatpak would be stable/never-change. A fix was proposed in Flatpak directly[2] but it was rejected, leaving us with the only option of adding the historical/legacy application names to the "Keywords" key in their desktop files. Many users, such as myself, have the "muscle memory" of search for the old application's name, such as "totem", "gedit", "evince". Although I agree that the new names should be presented to new users and that the old ones shouldn't be visible in UI, it makes sense and little effort to support the search for the old names IMO. [0] https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gdesktopappinfo.c#L378 [1] glib#1706 [2] https://github.com/flatpak/flatpak/issues/2749
-rw-r--r--data/org.gnome.Nautilus.desktop.in.in2
1 files changed, 1 insertions, 1 deletions
diff --git a/data/org.gnome.Nautilus.desktop.in.in b/data/org.gnome.Nautilus.desktop.in.in
index 32bcab5c5..42e0c2794 100644
--- a/data/org.gnome.Nautilus.desktop.in.in
+++ b/data/org.gnome.Nautilus.desktop.in.in
@@ -2,7 +2,7 @@
Name=Files
Comment=Access and organize files
# Translators: Search terms to find this application. Do NOT translate or localize the semicolons! The list MUST also end with a semicolon!
-Keywords=folder;manager;explore;disk;filesystem;
+Keywords=folder;manager;explore;disk;filesystem;nautilus;
Exec=nautilus --new-window %U
# Translators: Do NOT translate or transliterate this text (this is an icon file name)!
Icon=@icon@