diff options
| author | Gary Li <gary.li1@uwaterloo.ca> | 2022-10-16 20:43:38 -0400 |
|---|---|---|
| committer | António Fernandes <antoniof@gnome.org> | 2022-12-24 15:38:01 +0000 |
| commit | 166ad014f38478b468da41cf45a842a8329bf2b9 (patch) | |
| tree | 25579dee0d9e8378cc06f460926e7bc35d59a849 | |
| parent | 90d995453f0aa213ba5a01b1c72a0f9a023a31fc (diff) | |
| download | nautilus-166ad014f38478b468da41cf45a842a8329bf2b9.tar.gz | |
progress-info-manager: Don't leak finished & cancelled infos
NautilusProgressInfoManager aquires a reference for every progress info
and keeps these references in a list. Upon destruction, it releases the
reference while unreffing each progress info.
However, when it removes finished and cancelled infos from the list, it
doesn't release the reference, effectively leaking it.
This bug is a old as the manager: a0f89473830575ae39a568608bc58f3f92c6f4a4
| -rw-r--r-- | src/nautilus-progress-info-manager.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/nautilus-progress-info-manager.c b/src/nautilus-progress-info-manager.c index 88e76cfb3..208285b8b 100644 --- a/src/nautilus-progress-info-manager.c +++ b/src/nautilus-progress-info-manager.c @@ -159,6 +159,7 @@ nautilus_progress_info_manager_remove_finished_or_cancelled_infos (NautilusProgr if (nautilus_progress_info_get_is_finished (l->data) || nautilus_progress_info_get_is_cancelled (l->data)) { + g_object_unref (l->data); self->progress_infos = g_list_remove (self->progress_infos, l->data); } |