diff options
author | Carlos Soriano <csoriano@gnome.org> | 2016-01-27 20:52:57 +0100 |
---|---|---|
committer | Carlos Soriano <csoriano@gnome.org> | 2016-02-02 22:22:37 +0100 |
commit | 0bb0e846492caa2cdf417d13cddc4f2782a4152e (patch) | |
tree | a5ca8cd5d215b5a3547cf44519feb60d01cc9fe7 | |
parent | 27590823d6d6783ef4ab0b3593d7d22494080f7e (diff) | |
download | nautilus-0bb0e846492caa2cdf417d13cddc4f2782a4152e.tar.gz |
search-directory: don't reload search
I know that it looks like it makes sense, but don't do it :)
Basically, all the logic for when a the query changes and to
load a new search directory (and therefore reload) is done outside
of the engines or the query. So basically don't touch it here.
What I believe is that reload should start the search again, not only
stop it and invalidate the file attributes of the search directory,
because as you could see it actually stops the search but doesn't
restart it.
I think this change of logic that makes reload not work properly on all
cases was introduced by me when I introduced the concept of restarting
the search engine internally, not only start and stop.
I will take a deeper look in future.
-rw-r--r-- | libnautilus-private/nautilus-search-directory.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/libnautilus-private/nautilus-search-directory.c b/libnautilus-private/nautilus-search-directory.c index 769de1dd0..b6c3ea6de 100644 --- a/libnautilus-private/nautilus-search-directory.c +++ b/libnautilus-private/nautilus-search-directory.c @@ -946,16 +946,10 @@ nautilus_search_directory_set_query (NautilusSearchDirectory *search, g_clear_pointer (&search->details->binding, g_binding_unbind); - /* Disconnect from the previous query changes */ - if (old_query) { - g_signal_handlers_disconnect_by_func (old_query, search_force_reload, search); - } - if (query) { search->details->binding = g_object_bind_property (search->details->engine, "running", query, "searching", G_BINDING_DEFAULT | G_BINDING_SYNC_CREATE); - g_signal_connect_swapped (query, "notify", G_CALLBACK (search_force_reload), search); } g_object_notify_by_pspec (G_OBJECT (search), properties[PROP_QUERY]); |