summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarlos Soriano <csoriano@gnome.org>2017-03-29 16:17:25 +0200
committerCarlos Soriano <csoriano@gnome.org>2017-04-22 17:16:33 +0200
commit60cc1ee6ef34c93bf826810e855de00bdd503119 (patch)
tree2afedef909e805d875eed6f501129cc73c21f336
parent8d6c3591d13ed35b9c673fdd9af35721a0d617ed (diff)
downloadnautilus-60cc1ee6ef34c93bf826810e855de00bdd503119.tar.gz
files-view: Remove directory parameter from add_files signal
It's not longer necessary. This patch removes it and also fixes a compiler warning.
-rw-r--r--src/nautilus-canvas-view.c5
-rw-r--r--src/nautilus-files-view.c4
-rw-r--r--src/nautilus-files-view.h3
-rw-r--r--src/nautilus-list-view.c12
-rw-r--r--src/nautilus-view-icon-controller.c3
5 files changed, 15 insertions, 12 deletions
diff --git a/src/nautilus-canvas-view.c b/src/nautilus-canvas-view.c
index a1a1bc762..b3a062f85 100644
--- a/src/nautilus-canvas-view.c
+++ b/src/nautilus-canvas-view.c
@@ -455,15 +455,12 @@ nautilus_canvas_view_remove_file (NautilusFilesView *view,
static void
nautilus_canvas_view_add_files (NautilusFilesView *view,
- GList *files,
- NautilusDirectory *directory)
+ GList *files)
{
NautilusCanvasView *canvas_view;
NautilusCanvasContainer *canvas_container;
GList *l;
- g_assert (directory == nautilus_files_view_get_model (view));
-
canvas_view = NAUTILUS_CANVAS_VIEW (view);
canvas_container = get_canvas_container (canvas_view);
diff --git a/src/nautilus-files-view.c b/src/nautilus-files-view.c
index a305ef873..a33c9517f 100644
--- a/src/nautilus-files-view.c
+++ b/src/nautilus-files-view.c
@@ -4106,7 +4106,7 @@ process_old_files (NautilusFilesView *view)
if (files_added != NULL)
{
g_signal_emit (view,
- signals[ADD_FILES], 0, pending_additions, pending->directory);
+ signals[ADD_FILES], 0, pending_additions);
}
for (node = files_changed; node != NULL; node = node->next)
@@ -9359,7 +9359,7 @@ nautilus_files_view_class_init (NautilusFilesViewClass *klass)
G_STRUCT_OFFSET (NautilusFilesViewClass, add_files),
NULL, NULL,
g_cclosure_marshal_generic,
- G_TYPE_NONE, 2, G_TYPE_POINTER, NAUTILUS_TYPE_DIRECTORY);
+ G_TYPE_NONE, 1, G_TYPE_POINTER);
signals[BEGIN_FILE_CHANGES] =
g_signal_new ("begin-file-changes",
G_TYPE_FROM_CLASS (klass),
diff --git a/src/nautilus-files-view.h b/src/nautilus-files-view.h
index f7f25257d..aff0133a7 100644
--- a/src/nautilus-files-view.h
+++ b/src/nautilus-files-view.h
@@ -61,8 +61,7 @@ struct _NautilusFilesViewClass {
* It must be replaced by each subclass.
*/
void (* add_files) (NautilusFilesView *view,
- GList *files,
- NautilusDirectory *directory);
+ GList *files);
void (* remove_file) (NautilusFilesView *view,
NautilusFile *file,
NautilusDirectory *directory);
diff --git a/src/nautilus-list-view.c b/src/nautilus-list-view.c
index 2d4a34a1e..30b0e02ad 100644
--- a/src/nautilus-list-view.c
+++ b/src/nautilus-list-view.c
@@ -2063,8 +2063,7 @@ create_and_set_up_tree_view (NautilusListView *view)
static void
nautilus_list_view_add_files (NautilusFilesView *view,
- GList *files,
- NautilusDirectory *directory)
+ GList *files)
{
NautilusListModel *model;
GList *l;
@@ -2072,7 +2071,16 @@ nautilus_list_view_add_files (NautilusFilesView *view,
model = NAUTILUS_LIST_VIEW (view)->details->model;
for (l = files; l != NULL; l = l->next)
{
+ NautilusFile *parent;
+ NautilusDirectory *directory;
+
+ parent = nautilus_file_get_parent (NAUTILUS_FILE (l->data));
+ directory = nautilus_directory_get_for_file (parent);
+ g_print ("file %s parent %s directory %s\n", nautilus_file_get_uri (l->data), nautilus_file_get_uri (parent), nautilus_directory_get_uri (directory));
nautilus_list_model_add_file (model, NAUTILUS_FILE (l->data), directory);
+
+ nautilus_file_unref (parent);
+ nautilus_directory_unref (directory);
}
}
diff --git a/src/nautilus-view-icon-controller.c b/src/nautilus-view-icon-controller.c
index b4323633d..6f43631dc 100644
--- a/src/nautilus-view-icon-controller.c
+++ b/src/nautilus-view-icon-controller.c
@@ -742,8 +742,7 @@ action_sort_order_changed (GSimpleAction *action,
static void
real_add_files (NautilusFilesView *files_view,
- GList *files,
- NautilusDirectory *directory)
+ GList *files)
{
NautilusViewIconController *self = NAUTILUS_VIEW_ICON_CONTROLLER (files_view);
g_autoptr (GQueue) files_queue;