window-slot: fix activate on search entry

The issue is that when pressing enter in search while the search entry
has the focus, right after the callback to activate the selection is
called, Nautilus also tries to activate the location corresponding to
the base of the search, as the view is still searching.

This occurs because in the activated signal the search is set as not
visible manually, which will make Nautilus check immediatly if it should
go back to the base of the search location, without waiting for the view
to update.

To fix this, don't set the search as not visible in the activated callback,
as when the search-mode-enabled property changes, if necessarry, the
cancel signal will be emitted which will set the search as not visible,
which will happen only after the view is updated. This is the behavior for
activating the selection in other ways, so activation with focus on the
entry should behave the same.

https://bugzilla.gnome.org/show_bug.cgi?id=764981

1 files changed, 0 insertions, 2 deletions

diff --git a/src/nautilus-window-slot.c b/src/nautilus-window-slot.c
index c5c94e103..a738ad1a2 100644
--- a/src/nautilus-window-slot.c
+++ b/src/nautilus-window-slot.c
@@ -362,8 +362,6 @@ query_editor_activated_callback (NautilusQueryEditor *editor,
         {
             nautilus_files_view_activate_selection (NAUTILUS_FILES_VIEW (priv->content_view));
         }
-
-        nautilus_window_slot_set_search_visible (self, FALSE);
     }
 }