summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarlos Soriano <csoriano@gnome.org>2015-02-02 14:15:52 +0100
committerCosimo Cecchi <cosimoc@gnome.org>2015-02-03 09:37:32 -0800
commit982469e3ae060885b271ef193ca60dfc28e66749 (patch)
tree506fa433fa5ac6e074f276dc75f006718f1d5de7
parentbd27ef5b2caba6b9c2eacab90ec19df7c4eff076 (diff)
downloadnautilus-982469e3ae060885b271ef193ca60dfc28e66749.tar.gz
nautilus-window-slot: Don't grab focus on view change
We were grabbing the focus on view mode change, so if the user changed the view mode with keyboard he could continue using it. But it makes the problem that with the new popover menu in the toolbar where you can choose between different views while the menu is open, grabbing the focus to another widget dismiss the menu, which is against the behavior of the GtkMenuPopover. To fix that, don't grab focus on view changes. In the tests I have done, you can still focus the view just using the arrows after the view changes, so I don't think it will be a problem for keyboard users. https://bugzilla.gnome.org/show_bug.cgi?id=743591
-rw-r--r--src/nautilus-window-slot.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/nautilus-window-slot.c b/src/nautilus-window-slot.c
index 93ea872ad..c037cf306 100644
--- a/src/nautilus-window-slot.c
+++ b/src/nautilus-window-slot.c
@@ -2348,11 +2348,6 @@ nautilus_window_slot_switch_new_content_view (NautilusWindowSlot *slot)
widget = GTK_WIDGET (slot->details->content_view);
gtk_container_add (GTK_CONTAINER (slot->details->view_overlay), widget);
gtk_widget_show (widget);
-
- if (!NAUTILUS_IS_SEARCH_DIRECTORY (nautilus_view_get_model (slot->details->content_view)) &&
- slot == nautilus_window_get_active_slot (window)) {
- nautilus_view_grab_focus (slot->details->content_view);
- }
}
}