summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorErnestas Kulik <ekulik@redhat.com>2019-05-08 13:57:12 +0200
committerErnestas Kulik <ekulik@redhat.com>2019-05-27 11:02:24 +0200
commita6ce1d1e65fc8af88fcf65aec681375b08cff4f7 (patch)
tree00cb11a58924c7d01cd660f80f20c0c5513a2b33
parent326fa60685f165ab74a09ac9c53f53a5b30fd66d (diff)
downloadnautilus-a6ce1d1e65fc8af88fcf65aec681375b08cff4f7.tar.gz
window: Don’t hide undo notifications after destruction
In-app undo notifications are removed after a timeout, regardless of whether the window is alive or not, which can cause criticals to be thrown. Removing the event source before chaining up in the destroy() vfunc fixes this. Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/1026
-rw-r--r--src/nautilus-window.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/nautilus-window.c b/src/nautilus-window.c
index 18959598d..b039940fa 100644
--- a/src/nautilus-window.c
+++ b/src/nautilus-window.c
@@ -2288,6 +2288,8 @@ nautilus_window_destroy (GtkWidget *object)
window->bookmarks_id = 0;
}
+ g_clear_handle_id (&window->in_app_notification_undo_timeout_id, g_source_remove);
+
GTK_WIDGET_CLASS (nautilus_window_parent_class)->destroy (object);
}