diff options
author | Alexander Larsson <alexl@redhat.com> | 2003-05-05 07:28:48 +0000 |
---|---|---|
committer | Alexander Larsson <alexl@src.gnome.org> | 2003-05-05 07:28:48 +0000 |
commit | b503e4fe8f0e40b964a68c0c57a97cd44998aaee (patch) | |
tree | bab04ee9b57b532fd4d68786f70a6113340213ad /HACKING | |
parent | cf4f3a7cb8db6d5a5b1a25a6449ec4bf8cb9dcf4 (diff) | |
download | nautilus-b503e4fe8f0e40b964a68c0c57a97cd44998aaee.tar.gz |
Add some text about patch submission.
2003-05-05 Alexander Larsson <alexl@redhat.com>
* HACKING:
Add some text about patch submission.
Diffstat (limited to 'HACKING')
-rw-r--r-- | HACKING | 40 |
1 files changed, 33 insertions, 7 deletions
@@ -10,14 +10,40 @@ CVS version. The CVS version can be checked from the GNOME cvs server. See http://developer.gnome.org/tools/cvs.html for details on how to get started with GNOME CVS. -If you want to contribute patches, please send mail to the nautilus -mailing list: <nautilus-list@gnome.org>. Archives and subscription -information are available at +If you want to contribute in development discussions, please send mail +to the nautilus mailing list: <nautilus-list@gnome.org>. Archives and +subscription information are available at http://mail.gnome.org/mailman/listinfo/nautilus-list -You can also attach patches to individual bugs in bugzilla -(http://bugzilla.gnome.org, product 'nautilus'). + +Submitting Patches +------------------ + +If you've been working on a change to Nautilus and want to propose it +for inclusion, you have to generate a patch and submit it for review +by the maintainers. Patches should be made with 'cvs diff -pu >patch' and should conform to -Nautilus coding style as described in docs/style-guide.html Please -read other relevant documents in the docs directory too. +Nautilus coding style as described in docs/style-guide.html. We are +pretty strict about coding style, so please make sure you follow the +style guide to avoid unnecessary work on both sides when reviewing the +patch. + +The best way to submit a patch for review is to post it on the mailing +list. That way everyone sees it and can take part in the following +discussion about it. Sometimes people also attach patches to bugs in +bugzilla (http://bugzilla.gnome.org, product 'nautilus'). If you do +this, please send a mail to the list saying you did so, because it is +very easy for the bugzilla email to get lost in all the bugzilla +reports, and only the people CCd on the bug can partake in the +discussion. + +The Nautilus maintainers do their best to review patches and help +developers that want to work on something, however we are often +swamped in work and can miss an email or just forget to answer +it. Don't be afraid of reposting your patches after a while, or poking +us about the status of them. + +Also, if you're planning to do large changes, please take them up for +discussion on the list first. If you get feedback early it is much +easier to integrate it into your work. |