Updated code affected by destroy-notify addition to bonobo. Requires new

	Updated code affected by destroy-notify addition to bonobo.
	Requires new bonobo.

	* libnautilus-extensions/nautilus-bonobo-extensions.c:
	(nautilus_bonobo_ui_handler_menu_set_toggle_appearance):
	Save and restore the destroy notify function as well as the
	callback. This requires using the new function
	bonobo_ui_handler_menu_remove_callback_no_notify to do right.

	* src/file-manager/fm-directory-view.c:
	(application_launch_parameters_new),
	(application_launch_parameters_free): Ref and unref the directory
	view object now that we correctly free this as needed.
	(viewer_launch_parameters_new), (viewer_launch_parameters_free):
	Ref and unref the directory view object now that we correctly free
	this as needed.
	(add_open_with_bonobo_menu_item): Add a destroy-notify function
	parameters and apply it using bonobo_ui_handler_menu_set_callback.
	(add_application_to_bonobo_menu): Free the launch parmaeters using
	a destroy-notify function.
	(add_component_to_bonobo_menu): Free the launch parmaeters using
	a destroy-notify function.

	* src/nautilus-window-menus.c: (append_bookmark_to_menu): Use a
	destroy-notify function to destroy the bookmark holder.
	(clear_appended_bookmark_items): Get rid of the code that gets
	the callback data and destroys it explicitly.

	* libnautilus/nautilus-clipboard.c: (add_menu_item):
	* src/file-manager/fm-directory-view.c: (insert_bonobo_menu_item),
	(fm_directory_view_real_merge_menus):
	* src/file-manager/fm-icon-view.c: (append_bonobo_menu_item),
	(fm_icon_view_merge_menus):
	Rename BonoboUIHandlerCallbackFunc -> BonoboUIHandlerCallback.

	* HACKING: Some reformatting.

1 files changed, 23 insertions, 23 deletions

diff --git a/HACKING b/HACKING
index 6a31d3f26..4b8c4062d 100644
--- a/HACKING
+++ b/HACKING
@@ -41,36 +41,33 @@ Nautilus currently requires the following modules from GNOME CVS
 	medusa:            HEAD
 	nautilus:          HEAD
 
-Below are some more requirements, for Red Hat and Debian
-
-Development Libraries Needed, Here is what has been tested.
-You will also need the library package that is associated with each development package, these
-versions are for RedHat 6.2 an Debian potato
-
-library         RedHat                  Debian                          Implied Version
---------------  ----------------------  ------------------------------  ------------------
-
-audiofile       audiofile-devel-0.1.9-3 libaudiofile-dev (0.1.9-0.1)    0.1.9
-libc            glibc-devel-2.1.3-15    libc6-dev (2.1.3-10)            2.1.3
-libc++          egcs-c++-1.1.2-30       libstdc++2.10-dev (2.95.2-12)   2.9.0, 2.10
-libjpeg         libjpeg-devel-6b-10     libjpeg62-dev (6b-1.2)          6b 1.0-1.2
-libpng          libpng-devel-1.0.5-3    libpng2-dev (1.0.5-1)           1.0.5
-libtiff         libtiff-devel-3.5.4-5   libtiff3g-dev (3.5.4-5)         3.5.4
-libungif        libungif-devel-4.1.0-4  libungif3g-dev (3.0-3)          3.0 or 4.1.0
-w3c-libwww      w3c-libwww-devel-5.2.8-4 libw3c-libwww-dev (5.2.8-1)    5.2.8
-Xlib            XFree86-devel-3.3.6-20  xlib6g-dev (3.3.6-7)            3.3.6
-zlib            zlib-devel-1.1.3-6      zlib1g-dev (1.1.3-5)            1.1.3
-
+Other libraries needed:
+
+Here is what has been tested
+You will also need the library package that is associated with each development package,
+these versions are for RedHat 6.2 and Debian "potato":
+
+library         RedHat                   Debian                          Implied Version
+--------------  ----------------------   ------------------------------  ------------------
+audiofile       audiofile-devel-0.1.9-3  libaudiofile-dev (0.1.9-0.1)    0.1.9
+libc            glibc-devel-2.1.3-15     libc6-dev (2.1.3-10)            2.1.3
+libc++          egcs-c++-1.1.2-30        libstdc++2.10-dev (2.95.2-12)   2.9.0, 2.10
+libjpeg         libjpeg-devel-6b-10      libjpeg62-dev (6b-1.2)          6b 1.0-1.2
+libpng          libpng-devel-1.0.5-3     libpng2-dev (1.0.5-1)           1.0.5
+libtiff         libtiff-devel-3.5.4-5    libtiff3g-dev (3.5.4-5)         3.5.4
+libungif        libungif-devel-4.1.0-4   libungif3g-dev (3.0-3)          3.0 or 4.1.0
+w3c-libwww      w3c-libwww-devel-5.2.8-4 libw3c-libwww-dev (5.2.8-1)     5.2.8
+Xlib            XFree86-devel-3.3.6-20   xlib6g-dev (3.3.6-7)            3.3.6
+zlib            zlib-devel-1.1.3-6       zlib1g-dev (1.1.3-5)            1.1.3
 
 Other modules for Red Hat users: either 6.1 or 6.2
 
-	- For other modules, the versions in Red Hat 6.1 or 6.2 will do.
+	- For most modules, the versions in Red Hat 6.1 or 6.2 will do (listed above).
 	- ORBit requires popt-1.5, which can be fetched from:
 
 	ftp://ftp.valinux.com/pub/mirrors/redhat/rawhide/i386/RedHat/RPMS/popt-1.5-0.45.i386.rpm
 	ftp://ftp.valinux.com/pub/mirrors/redhat/redhat/redhat-6.2/i386/RedHat/RPMS/popt-1.5-0.48.i386.rpm
 
-
 Other modules for Debian users: using potato, or possibly woody
 
 	- You'll need libwww, which can be found at:
@@ -79,10 +76,12 @@ Other modules for Debian users: using potato, or possibly woody
 	ftp://ftp.internatif.org/pub/debian/UNOFFICIAL/libw3c-libwww-dev_5.2.8-1_i386.deb
 
 If you need to get a copy of popt from source: 
+
 	CVSROOT=:pserver:anonymous@cvs.rpm.org:/cvs/devel
 	The default passwd is a carriage return.  You should do a cvs co popt
 
 m4 macro issues:
+
 	m4 macros have issues.  Trying to install multiple versions of them on you system can be very tricky.
 	While building these libraries you will place following m4 macros into "your prefix"/share/aclocal
 	directory.  Note you will generally get errors with -I
@@ -124,4 +123,5 @@ Also, you need to do a "killall oafd; killall gconfd" before
 running Nautilus if OAF, GConf, or any of the .oafinfo files
 in any module changed.
 
-All patches should go through nautilus-list@lists.eazel.com
+* All patches should go through nautilus-list@lists.eazel.com.
+