summaryrefslogtreecommitdiff
path: root/components/loser
diff options
context:
space:
mode:
authorDarin Adler <darin@bentspoon.com>2002-03-07 19:36:18 +0000
committerDarin Adler <darin@src.gnome.org>2002-03-07 19:36:18 +0000
commit136742e4efa2af350b1303469b69113f39443490 (patch)
tree41e11442b391712ff49a2eee762f8ad22535c86a /components/loser
parent6b5798037c6df519b12adb45ff919ea796856034 (diff)
downloadnautilus-136742e4efa2af350b1303469b69113f39443490.tar.gz
Because lots of recent bugs were due to "signal handler called after
* Tons of files: Because lots of recent bugs were due to "signal handler called after object gone" problems, switched many calls of g_signal_connect and g_signal_connect_swapped to use g_signal_connect_object instead. Also did other signal-related cleanup and changed some destroys to finalizes. * libnautilus/nautilus-view-standard-main.h: We no longer need to include nautilus-view.h in here. So include it in the files that use this instead. Did merges from stable branch: 2001-10-25 Darin Adler <darin@bentspoon.com> * libnautilus-private/nautilus-directory.c: (call_files_changed_common), (call_files_changed_free_list), (call_files_changed_unref_free_list), (nautilus_directory_notify_files_changed): Move call to nautilus_directory_add_file_to_work_queue into a better bottleneck; now it catches all the notify cases, not just changed. Also tell it to re-get top-left text and link info too when we get a changed notice. * src/file-manager/fm-directory-view.c: (queue_pending_files): Don't use the timeout (and the hysteresis) when queuing files once the initial directory load is complete. Doing this was causing delays processing changes that came in later, which we don't want. * src/nautilus-sidebar-title.c: (item_count_ready), (monitor_add), (update_all), (nautilus_sidebar_title_set_file): Monitor the directory count once we get it the first time. This makes sure that changes in the directory count get reflected in the sidebar without creating a race with the main view to see who calculates it first. 2001-10-25 Alex Larsson <alexl@redhat.com> * libnautilus-private/nautilus-directory.c (nautilus_directory_notify_files_changed): Call nautilus_directory_add_file_to_work_queue() when file_info is invalidated. Otherwise it will not be read again.
Diffstat (limited to 'components/loser')
-rw-r--r--components/loser/content/nautilus-content-loser.c13
-rw-r--r--components/loser/sidebar/nautilus-sidebar-loser.c16
2 files changed, 11 insertions, 18 deletions
diff --git a/components/loser/content/nautilus-content-loser.c b/components/loser/content/nautilus-content-loser.c
index 5b2ca5ac2..59b3b7cb1 100644
--- a/components/loser/content/nautilus-content-loser.c
+++ b/components/loser/content/nautilus-content-loser.c
@@ -77,18 +77,15 @@ nautilus_content_loser_init (NautilusContentLoser *view)
view->details->nautilus_view = nautilus_view_new (GTK_WIDGET (view));
- g_signal_connect (view->details->nautilus_view,
- "load_location",
- G_CALLBACK (loser_load_location_callback),
- view);
+ g_signal_connect_object (view->details->nautilus_view, "load_location",
+ G_CALLBACK (loser_load_location_callback), view, 0);
/* Get notified when our bonobo control is activated so we
* can merge menu & toolbar items into Nautilus's UI.
*/
- g_signal_connect (nautilus_view_get_bonobo_control (view->details->nautilus_view),
- "activate",
- G_CALLBACK (loser_merge_bonobo_items_callback),
- view);
+ g_signal_connect_object (nautilus_view_get_bonobo_control (view->details->nautilus_view),
+ "activate",
+ G_CALLBACK (loser_merge_bonobo_items_callback), view, 0);
gtk_widget_show (GTK_WIDGET (view));
}
diff --git a/components/loser/sidebar/nautilus-sidebar-loser.c b/components/loser/sidebar/nautilus-sidebar-loser.c
index 1ac18d880..49cd00c8f 100644
--- a/components/loser/sidebar/nautilus-sidebar-loser.c
+++ b/components/loser/sidebar/nautilus-sidebar-loser.c
@@ -79,19 +79,15 @@ nautilus_sidebar_loser_init (NautilusSidebarLoser *view)
view->details->nautilus_view = nautilus_view_new (GTK_WIDGET (view));
- g_signal_connect (view->details->nautilus_view,
- "load_location",
- G_CALLBACK (loser_load_location_callback),
- view);
+ g_signal_connect_object (view->details->nautilus_view, "load_location",
+ G_CALLBACK (loser_load_location_callback), view, 0);
- /*
- * Get notified when our bonobo control is activated so we
+ /* Get notified when our bonobo control is activated so we
* can merge menu & toolbar items into Nautilus's UI.
*/
- g_signal_connect (nautilus_view_get_bonobo_control (view->details->nautilus_view),
- "activate",
- G_CALLBACK (loser_merge_bonobo_items_callback),
- view);
+ g_signal_connect_object (nautilus_view_get_bonobo_control (view->details->nautilus_view),
+ "activate",
+ G_CALLBACK (loser_merge_bonobo_items_callback), view, 0);
gtk_widget_show (GTK_WIDGET (view));
}