diff options
author | Darin Adler <darin@src.gnome.org> | 2001-01-05 02:03:34 +0000 |
---|---|---|
committer | Darin Adler <darin@src.gnome.org> | 2001-01-05 02:03:34 +0000 |
commit | 47b25905a00ccf16630c8e0987f8e8b4a4d238c0 (patch) | |
tree | b3eaef06ac54b715c8fa6f3571950676a8076d49 /docs | |
parent | f3af9f5462ef546d5b50f58cd910533e98b25c6b (diff) | |
download | nautilus-47b25905a00ccf16630c8e0987f8e8b4a4d238c0.tar.gz |
Some FIXME cleanup.
* components/help/converters/gnome-db2html2/sect-elements.c:
(sect_article_end_element), (sect_inlinegraphic_start_element):
* components/help/converters/gnome-db2html2/toc-elements.c:
(toc_sect_end_element):
* components/mozilla/mozilla-events.cpp:
* components/mozilla/nautilus-mozilla-content-view.c:
(make_full_uri_from_relative), (eazel_services_scheme_translate):
* components/music/nautilus-music-view.c:
(nautilus_music_view_initialize),
(music_view_set_selected_song_title), (reset_playtime),
(play_status_display), (slider_moved_callback),
(add_play_controls):
* components/notes/nautilus-notes.c: (notes_load_metainfo):
* components/services/install/lib/eazel-install-logic.c:
(eazel_install_check_for_file_conflicts),
(eazel_install_do_transaction_all_files_check),
(eazel_install_prune_packages_helper),
(eazel_install_check_existing_packages):
* libnautilus-extensions/nautilus-string.c: (nautilus_strcmp),
(nautilus_strcasecmp), (nautilus_strcmp_case_breaks_ties),
(nautilus_strcoll), (nautilus_str_is_equal),
(nautilus_istr_is_equal), (nautilus_strcmp_compare_func),
(nautilus_strcoll_compare_func),
(nautilus_strcasecmp_compare_func):
* src/file-manager/fm-directory-view.c: (open_location):
* src/nautilus-first-time-druid.c: (make_anti_aliased_label),
(make_hbox_user_level_radio_button), (set_up_user_level_page):
Added bug numbers to FIXMEs. At one point Josh made some bugs for
FIXMEs but never got around to checking in the bug numbers in the
source code. And I wrote one bug report.
* components/music/nautilus-music-view.c:
(nautilus_music_view_initialize): Removed a fixed FIXME. Also got
rid of a hard-coded constant and took excess spaces out of some
string constants.
* components/services/install/lib/eazel-install-object.c:
(eazel_install_emit_dependency_check_default): Changed a FIXME
into a non-FIXME comment, now the the bug is fixed.
* components/services/install/lib/eazel-package-system-rpm3.c:
(rpm_packagedata_fill_from_file): Removed an incorrect bug number
from a FIXME.
* components/services/install/nautilus-view/nautilus-service-install-view.h:
* components/services/install/nautilus-view/nautilus-service-install-view.c:
(nautilus_service_install_installing): Removed the FIXME from a
comment that's about how a bug was fixed.
* components/services/trilobite/libtrilobite/trilobite-md5-tools.h:
* components/services/trilobite/libtrilobite/trilobite-md5-tools.c:
* docs/style-guide.html:
Removed FIXME and corrected misunderstanding about whether use of
the guchar typedef is recommended in Nautilus coding style.
* libnautilus-extensions/nautilus-gdk-font-extensions.h:
* libnautilus-extensions/nautilus-gdk-font-extensions.c:
Removed misguided use of const in here. Gdk and Gtk object types
just aren't suitable for const, and you end up doing type casts
that defeat the purpose.
* src/nautilus-window-manage-views.c: (load_underway_callback):
Remove a FIXME for a fixed bug.
Diffstat (limited to 'docs')
-rw-r--r-- | docs/style-guide.html | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/docs/style-guide.html b/docs/style-guide.html index e58923f15..d0881c5ed 100644 --- a/docs/style-guide.html +++ b/docs/style-guide.html @@ -45,11 +45,12 @@ to avoid this. Also, we prefer to cast data pointers, rather than casting function pointers, since there's so much more to get wrong with function pointer casts.</p> -<p><b>We use typedefs from <glib.h> for things like guint and gpointer, +<p><b>We use typedefs from <glib.h> for things like guint, guchar and gpointer, but not gint, gchar, or gdouble.</b> Using these gives a false sense of portability. In all three cases, using system calls like printf requires knowing that these are the "real" int, char, and double, so there's no reason -to use a typedef that's non-standard.</p> +to use a typedef that's non-standard unless it's a shorter name or clearer +in some way.</p> <p><b>We avoid in-band signaling.</b> This means that we avoid using special values to indicate errors, for example. This can lead to subtle bugs when a valid |