reviewed by: Rebecca Shulman <rebecka@eazel.com>

	Fixed bug 2155 (type-selected icon is not successfully scrolled
	into view). The code was using the wrong coordinate system.

	* libnautilus-extensions/nautilus-icon-container.c: (reveal_icon):
	Do the icon revealing with the
	nautilus_gnome_canvas_item_get_current_canvas_bounds instead of
	icon_get_bounding_box. The old code used item coordinates instead
	of canvas coordinates.
	(match_best_name): Added (guchar) casts to make tolower work
	right, since it takes int parameters, not char.
	(select_matching_name): Added (guchar) casts to make tolower work
	right, since it takes int parameters, not char.
	(undo_stretching): Broke out this function -- work was in-line in
	key_press_event before.
	(handle_typeahead): Renamed, added (guchar) casts to make isprint
	work right, since it takes int parameters, not char.
	(key_press_event): Use undo_stretching helper function.
	(nautilus_icon_container_set_label_font_for_zoom_level): Remove
	redundant NULL check.
	(nautilus_icon_container_set_smooth_label_font): Ref new
	font before unref'ing the old one in case they are the same.
	(nautilus_icon_container_set_single_click_mode) Remove redundant
	NULL check.
	(nautilus_icon_container_get_is_fixed_size): Remove redundant
	NULL check.
	(nautilus_icon_container_set_is_fixed_size): Remove redundant
	NULL check.
	(check_compute_stretch), (nautilus_self_check_icon_container):
	Renamed.

	* libnautilus-extensions/nautilus-string.c:
	(nautilus_istr_has_prefix), (nautilus_istr_has_suffix),
	(nautilus_str_capitalize): Added (guchar) casts to make tolower
	and toupper work right, since it they take int parameters, not
	char. Removed unnecessary checks of isupper before calling tolower
	and islower before calling toupper. We did the research a while
	back and discovered that broken platforms like that where toupper
	can munge non-lower-case-letter characters don't really exist in
	practice any more.

	* libnautilus-extensions/nautilus-file.c: (update_link),
	(update_info_internal): Added FIXMEs to remind me to come back
	here when I go fix bug 2044.

	* libnautilus-extensions/nautilus-gnome-extensions.c:
	(nautilus_gnome_canvas_draw_pixbuf_helper),
	(nautilus_gnome_canvas_draw_pixbuf_helper_alpha): Tweak
	formatting.

1 files changed, 8 insertions, 0 deletions

diff --git a/libnautilus-private/nautilus-file.c b/libnautilus-private/nautilus-file.c
index 4417aa81d..d8a2aa93a 100644
--- a/libnautilus-private/nautilus-file.c
+++ b/libnautilus-private/nautilus-file.c
@@ -1092,6 +1092,10 @@ update_link (NautilusFile *link_file, NautilusFile *target_file)
 	g_assert (NAUTILUS_IS_FILE (link_file));
 	g_assert (NAUTILUS_IS_FILE (target_file));
 	g_assert (!info_missing (link_file, GNOME_VFS_FILE_INFO_FIELDS_SYMLINK_NAME));
+
+	/* FIXME bugzilla.eazel.com 2044: If we don't put any code
+	 * here then the hash table is a waste of time.
+	 */
 }
 
 static GList *
@@ -1147,6 +1151,10 @@ update_info_internal (NautilusFile *file,
 		return FALSE;
 	}
 
+	/* FIXME bugzilla.eazel.com 2044: Need to let links that
+	 * point to the old name know that the file has been renamed.
+	 */
+
 	remove_from_link_hash_table (file);
 
 	info_copy = gnome_vfs_file_info_dup (info);