diff options
author | Carlos Soriano <csoriano@gnome.org> | 2016-04-22 17:02:38 +0200 |
---|---|---|
committer | Carlos Soriano <csoriano@gnome.org> | 2016-04-25 16:31:42 +0200 |
commit | 7e24f1b2a2b3b7860ee29820d69f5a1511fee994 (patch) | |
tree | a2ee175c5f9cd05ab518e768a073ef4a31fe8376 /src/nautilus-lib-self-check-functions.h | |
parent | 2774b8552dcc89ae744700af5832dbf76c138a9e (diff) | |
download | nautilus-7e24f1b2a2b3b7860ee29820d69f5a1511fee994.tar.gz |
general: merge libnautilus-private to srcwip/csoriano/private-to-src
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
Diffstat (limited to 'src/nautilus-lib-self-check-functions.h')
-rw-r--r-- | src/nautilus-lib-self-check-functions.h | 47 |
1 files changed, 47 insertions, 0 deletions
diff --git a/src/nautilus-lib-self-check-functions.h b/src/nautilus-lib-self-check-functions.h new file mode 100644 index 000000000..c326c60fd --- /dev/null +++ b/src/nautilus-lib-self-check-functions.h @@ -0,0 +1,47 @@ +/* + nautilus-lib-self-check-functions.h: Wrapper and prototypes for all + self-check functions in libnautilus. + + Copyright (C) 2000 Eazel, Inc. + + This program is free software; you can redistribute it and/or + modify it under the terms of the GNU General Public License as + published by the Free Software Foundation; either version 2 of the + License, or (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + General Public License for more details. + + You should have received a copy of the GNU General Public + License along with this program; if not, see <http://www.gnu.org/licenses/>. + + Author: Darin Adler <darin@bentspoon.com> +*/ + +#include <eel/eel-self-checks.h> + +void nautilus_run_lib_self_checks (void); + +/* Putting the prototypes for these self-check functions in each + header file for the files they are defined in would make compiling + the self-check framework take way too long (since one file would + have to include everything). + + So we put the list of functions here instead. + + Instead of just putting prototypes here, we put this macro that + can be used to do operations on the whole list of functions. +*/ + +#define NAUTILUS_LIB_FOR_EACH_SELF_CHECK_FUNCTION(macro) \ + macro (nautilus_self_check_file_utilities) \ + macro (nautilus_self_check_file_operations) \ + macro (nautilus_self_check_directory) \ + macro (nautilus_self_check_file) \ + macro (nautilus_self_check_canvas_container) \ +/* Add new self-check functions to the list above this line. */ + +/* Generate prototypes for all the functions. */ +NAUTILUS_LIB_FOR_EACH_SELF_CHECK_FUNCTION (EEL_SELF_CHECK_FUNCTION_PROTOTYPE) |