summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCarlos Soriano <csoriano@gnome.org>2015-11-13 18:43:44 +0100
committerCarlos Soriano <csoriano@gnome.org>2015-11-13 18:58:18 +0100
commitf101c34c3dfe555d237c0a67876fc478ca8772a9 (patch)
treeeadb81d24e12fbdf4e6adbdcde87f7004c9fe172 /src
parent558845a9945606f0430d569f29c4903fe6eca045 (diff)
downloadnautilus-f101c34c3dfe555d237c0a67876fc478ca8772a9.tar.gz
window-slot: don't ref all views on creation
This was leaking and making that no view was finalized, leading to all kind of problems and crashes due to signals and files updating the dangling view, and not letting files to be released. This was creating multiple non-related reports on Fedora Tracker making nautilus one of the top crashers. Downstream tracker bug: https://bugzilla.redhat.com/show_bug.cgi?id=1277625 The upcoming patch is also necessary for a complete fix.
Diffstat (limited to 'src')
-rw-r--r--src/nautilus-window-slot.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nautilus-window-slot.c b/src/nautilus-window-slot.c
index c32bde298..d005eee6d 100644
--- a/src/nautilus-window-slot.c
+++ b/src/nautilus-window-slot.c
@@ -228,7 +228,7 @@ nautilus_window_slot_get_view_for_location (NautilusWindowSlot *slot,
nautilus_file_unref (file);
- return g_object_ref (view);
+ return view;
}
static gboolean