diff options
35 files changed, 132 insertions, 72 deletions
@@ -1,4 +1,44 @@ 2000-12-07 Rebecca Schulman <rebecka@eazel.com> + Bug numbers for the FIXMEs in libnautilus-extensions. + + * libnautilus-extensions/nautilus-customization-data.c: + (format_name_for_display): + * libnautilus-extensions/nautilus-directory-async.c: + (dequeue_pending_idle_callback), (cancel_loading_attributes), + (nautilus_directory_cancel_loading_file_attributes): + * libnautilus-extensions/nautilus-directory.c: + (nautilus_directory_handle_directory_moved), + (nautilus_directory_notify_files_moved), + (nautilus_self_check_directory): + * libnautilus-extensions/nautilus-file-utilities.c: + (nautilus_make_uri_canonical), + (pthread_nautilus_read_file_thread_entry), + (pthread_nautilus_read_file_async), (nautilus_read_file_cancel), + (nautilus_self_check_file_utilities): + * libnautilus-extensions/nautilus-file.c: (get_description), + (nautilus_file_forget_attributes_internal): + * libnautilus-extensions/nautilus-gdk-extensions.c: + * libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c: + * libnautilus-extensions/nautilus-icon-container.c: + (nautilus_icon_container_start_renaming_selected_item): + * libnautilus-extensions/nautilus-icon-dnd.c: + (receive_dropped_uri_list): + * libnautilus-extensions/nautilus-icon-factory.c: + * libnautilus-extensions/nautilus-label.c: + (nautilus_label_size_allocate), (label_recompute_line_geometries): + * libnautilus-extensions/nautilus-merged-directory.c: + (nautilus_merged_directory_add_real_directory): + * libnautilus-extensions/nautilus-mime-actions.c: + (nautilus_mime_get_default_application_for_file_internal): + * libnautilus-extensions/nautilus-scalable-font.c: + (nautilus_text_layout_paint): + * libnautilus-extensions/nautilus-search-uri.c: + (nautilus_self_check_search_uri): + * libnautilus-extensions/nautilus-string.c: + * libnautilus-extensions/nautilus-undo-signal-handlers.c: + (editable_key_press_event), (nautilus_undo_editable_set_undo_key): + +2000-12-07 Rebecca Schulman <rebecka@eazel.com> Added bug numbers to FIXMEs for the src subdirectory. If I can stomach it, I'll try and do a few more today. diff --git a/libnautilus-extensions/nautilus-customization-data.c b/libnautilus-extensions/nautilus-customization-data.c index 00814b124..0f8e38cf9 100644 --- a/libnautilus-extensions/nautilus-customization-data.c +++ b/libnautilus-extensions/nautilus-customization-data.c @@ -376,7 +376,7 @@ format_name_for_display (const char* name) formatted_str = strip_extension (name); - /* FIXME: Not appropriate to upper-case the letter of the name + /* FIXME bugzilla.eazel.com 5046: Not appropriate to upper-case the letter of the name * after a space for all languages. A potential translation * nightmare. */ diff --git a/libnautilus-extensions/nautilus-directory-async.c b/libnautilus-extensions/nautilus-directory-async.c index 7ee6a7de5..dc25425fc 100644 --- a/libnautilus-extensions/nautilus-directory-async.c +++ b/libnautilus-extensions/nautilus-directory-async.c @@ -1218,7 +1218,7 @@ dequeue_pending_idle_callback (gpointer callback_data) file_info = node->data; /* Update the file count. */ - /* FIXME: This could count a file twice if we get it + /* FIXME bugzilla.eazel.com 5063: This could count a file twice if we get it * from both load_directory and from * new_files_callback. Not too hard to fix by moving * this into the actual callback instead of waiting @@ -3214,7 +3214,7 @@ cancel_loading_attributes (NautilusDirectory *directory, file_info_cancel (directory); } - /* FIXME: implement cancelling metadata when we + /* FIXME bugzilla.eazel.com 5064: implement cancelling metadata when we implement forgetting metadata */ } @@ -3247,6 +3247,6 @@ nautilus_directory_cancel_loading_file_attributes (NautilusDirectory *directory, cancel_activation_uri_for_file (directory, file); } - /* FIXME: implement cancelling metadata when we + /* FIXME bugzilla.eazel.com 5064: implement cancelling metadata when we implement forgetting metadata */ } diff --git a/libnautilus-extensions/nautilus-directory.c b/libnautilus-extensions/nautilus-directory.c index 4a6834d5c..7f3b9c26f 100644 --- a/libnautilus-extensions/nautilus-directory.c +++ b/libnautilus-extensions/nautilus-directory.c @@ -976,7 +976,7 @@ nautilus_directory_handle_directory_moved (NautilusDirectory *directory, directory->details->private_metafile_vfs_uri = construct_private_metafile_vfs_uri (to_uri); - /* FIXME: we also need to rename the private metafile, if it + /* FIXME bugzilla.eazel.com 5065: we also need to rename the private metafile, if it exists, don't we. */ if (directory->details->vfs_uri != NULL) { @@ -998,7 +998,7 @@ nautilus_directory_handle_directory_moved (NautilusDirectory *directory, directory->details->uri, directory); - /* FIXME: need to handle updating child directories as well */ + /* FIXME bugzilla.eazel.com 5066: need to handle updating child directories as well */ } void @@ -1085,7 +1085,7 @@ nautilus_directory_notify_files_moved (GList *uri_pairs) * it from the get_parent_directory * function so we don't have to ref. */ - /* FIXME: Doesn't update the link hash table. */ + /* FIXME bugzilla.eazel.com 5067: Doesn't update the link hash table. */ file->details->directory = new_directory; /* Add to new directory. */ @@ -1510,7 +1510,7 @@ nautilus_self_check_directory (void) NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("http://le-hackeur.org/"), "http://le-hackeur.org"); NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("http://le-hackeur.org/dir"), "http://le-hackeur.org/dir"); NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("http://le-hackeur.org/dir/"), "http://le-hackeur.org/dir"); - /* FIXME: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ + /* FIXME bugzilla.eazel.com 5068: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("search://[file://]file_name contains stuff"), "search://[file/]file_name contains stuff"); #ifdef EAZEL_SERVICES NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("eazel-services:/~turtle"), "eazel-services:///~turtle"); diff --git a/libnautilus-extensions/nautilus-file-utilities.c b/libnautilus-extensions/nautilus-file-utilities.c index ac58afdc2..dca503d23 100644 --- a/libnautilus-extensions/nautilus-file-utilities.c +++ b/libnautilus-extensions/nautilus-file-utilities.c @@ -324,7 +324,8 @@ nautilus_make_uri_canonical (const char *uri) old_uri = canonical_uri; if (old_uri[0] != '/') { - /* FIXME: bandaid alert. Is this really the right thing to do? + /* FIXME bugzilla.eazel.com 5069: + * bandaid alert. Is this really the right thing to do? * * We got what really is a relative path. We do a little bit of * a stretch here and assume it was meant to be a cryptic absolute path, @@ -984,7 +985,7 @@ pthread_nautilus_read_file_thread_entry (void *cast_to_data) } buffer = g_realloc (buffer, total_bytes_read + READ_CHUNK_SIZE); - /* FIXME: + /* FIXME bugzilla.eazel.com 5070: * For a better cancellation granularity we should use gnome_vfs_read_cancellable * here, adding a GnomeVFSContext to NautilusAsyncReadFileData. */ @@ -1066,7 +1067,7 @@ pthread_nautilus_read_file_async(const char *uri, NautilusReadFileCallback callb pthread_attr_init (&thread_attr); pthread_attr_setdetachstate (&thread_attr, PTHREAD_CREATE_DETACHED); if (pthread_create (&thread, &thread_attr, pthread_nautilus_read_file_thread_entry, data) != 0) { - /* FIXME: + /* FIXME bugzilla.eazel.com 5071: * Would be cleaner to call through an idle callback here. */ (*callback) (GNOME_VFS_ERROR_INTERNAL, 0, NULL, NULL); @@ -1141,6 +1142,7 @@ nautilus_read_file_cancel (NautilusReadFileHandle *handle) g_free (handle->buffer); g_free (handle); #else + pthread_nautilus_read_file_async_cancel (handle); #endif } @@ -1267,7 +1269,7 @@ nautilus_self_check_file_utilities (void) /* nautilus_make_uri_canonical */ - /* FIXME: this is a bizarre result from an empty string */ + /* FIXME bugzilla.eazel.com 5072: this is a bizarre result from an empty string */ NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical (""), "file:///"); NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("file:/"), "file:///"); @@ -1281,7 +1283,7 @@ nautilus_self_check_file_utilities (void) NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("http://le-hackeur.org/dir"), "http://le-hackeur.org/dir"); NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("http://le-hackeur.org/dir/"), "http://le-hackeur.org/dir/"); - /* FIXME: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ + /* FIXME bugzilla.eazel.com 5068: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("search://[file://]file_name contains stuff"), "search://[file/]file_name contains stuff"); #ifdef EAZEL_SERVICES NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("eazel-services:/~turtle"), "eazel-services:///~turtle"); diff --git a/libnautilus-extensions/nautilus-file.c b/libnautilus-extensions/nautilus-file.c index 04b24dcb2..9c051b4b7 100644 --- a/libnautilus-extensions/nautilus-file.c +++ b/libnautilus-extensions/nautilus-file.c @@ -3630,14 +3630,16 @@ get_description (NautilusFile *file) mime_type = file->details->info->mime_type; } - /* FIXME: When this code was originally written, unknown types + /* FIXME bugzilla.eazel.com 5073: When this code was originally written, + * unknown types * were represented by NULL, but now they are represented by * "application/octet-string". Perhaps we want to check for * that here, so "program" will appear more often. */ if (nautilus_strlen (mime_type) == 0) { /* No MIME type, anything else interesting we can say about this? */ - /* FIXME: Maybe we should always return NULL when the + /* FIXME bugzilla.eazel.com 5074: Maybe we should always return NULL + * when the * MIME type is unknown. */ /* If it's a directory, call it "folder" before @@ -4358,7 +4360,7 @@ nautilus_file_forget_attributes_internal (NautilusFile *file, forget_activation_uri (file); } - /* FIXME: implement forgetting metadata */ + /* FIXME bugzilla.eazel.com 5075: implement forgetting metadata */ } diff --git a/libnautilus-extensions/nautilus-gdk-extensions.c b/libnautilus-extensions/nautilus-gdk-extensions.c index eb9821a93..faf92585c 100644 --- a/libnautilus-extensions/nautilus-gdk-extensions.c +++ b/libnautilus-extensions/nautilus-gdk-extensions.c @@ -269,7 +269,8 @@ nautilus_gradient_parse_one_color_spec (const char *spec, int *percent, const ch return result; } -/* FIXME anyone using nautilus_gradient_get_start_color_spec or +/* FIXME bugzilla.eazel.com 5076: + * anyone using nautilus_gradient_get_start_color_spec or * nautilus_gradient_get_end_color_spec is assuming the gradient * is 2 colors which is questionable. * diff --git a/libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c b/libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c index c6b967694..ef5b10a91 100644 --- a/libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c +++ b/libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c @@ -265,7 +265,7 @@ nautilus_cancel_gdk_pixbuf_load (NautilusPixbufLoadHandle *handle) free_pixbuf_load_handle (handle); } -/* FIXME +/* FIXME bugzilla.eazel.com 5077: * This fn is only used by some test code, it should probably be removed */ void diff --git a/libnautilus-extensions/nautilus-icon-container.c b/libnautilus-extensions/nautilus-icon-container.c index 39c58c78f..dfebe8d3c 100644 --- a/libnautilus-extensions/nautilus-icon-container.c +++ b/libnautilus-extensions/nautilus-icon-container.c @@ -4662,7 +4662,7 @@ nautilus_icon_container_start_renaming_selected_item (NautilusIconContainer *con editable_text, /* text */ TRUE); /* allocate local copy */ - /* FIXME: These callbacks don't have any side effects. + /* FIXME bugzilla.eazel.com 5078: These callbacks don't have any side effects. They should be removed */ /* Set up the signals */ gtk_signal_connect (GTK_OBJECT (details->rename_widget), "editing_started", @@ -4712,7 +4712,8 @@ end_renaming_mode (NautilusIconContainer *container, gboolean commit) hide_rename_widget (container, icon); } -/* FIXME: We're not exactly hiding this widget, we're destroying it! +/* FIXME bugzilla.eazel.com 5079: We're not exactly hiding this widget, + we're destroying it! Perhaps hide_rename_widget isn't the right name */ static void hide_rename_widget (NautilusIconContainer *container, NautilusIcon *icon) diff --git a/libnautilus-extensions/nautilus-icon-dnd.c b/libnautilus-extensions/nautilus-icon-dnd.c index f9b7e01d5..473ff79e7 100644 --- a/libnautilus-extensions/nautilus-icon-dnd.c +++ b/libnautilus-extensions/nautilus-icon-dnd.c @@ -591,7 +591,7 @@ receive_dropped_keyword (NautilusIconContainer *container, char* keyword, int x, static void receive_dropped_uri_list (NautilusIconContainer *container, char *uri_list, int x, int y) { - /* FIXME: + /* FIXME bugzilla.eazel.com 5080: * this needs a better name - it's link/desktop specific */ GList *li, *files; diff --git a/libnautilus-extensions/nautilus-icon-factory.c b/libnautilus-extensions/nautilus-icon-factory.c index c40f00316..4d2083432 100644 --- a/libnautilus-extensions/nautilus-icon-factory.c +++ b/libnautilus-extensions/nautilus-icon-factory.c @@ -107,7 +107,7 @@ static const char *icon_file_name_suffixes[] = /* Images are used themselves as thumbnails when they are below this * threshold size. */ -/* FIXME: Later we might have to have a more complex rule about when +/* FIXME bugzilla.eazel.com 5081: Later we might have to have a more complex rule about when * to use an image for itself. */ #define SELF_THUMBNAIL_SIZE_THRESHOLD 16384 @@ -115,7 +115,8 @@ static const char *icon_file_name_suffixes[] = /* Extremely large images can eat up hundreds of megabytes of memory, so we * shouldn't automatically thumbnail when larges are too large. */ -/* FIXME: Eventually, we want this threshold to be user-settable, but +/* FIXME bugzilla.eazel.com 5082: Eventually, we want this + * threshold to be user-settable, but * for now it's hard-wired. */ #define INHIBIT_THUMBNAIL_SIZE_THRESHOLD (1024 * 1024) diff --git a/libnautilus-extensions/nautilus-label.c b/libnautilus-extensions/nautilus-label.c index ac931e183..e7a983802 100644 --- a/libnautilus-extensions/nautilus-label.c +++ b/libnautilus-extensions/nautilus-label.c @@ -333,7 +333,7 @@ nautilus_label_size_allocate (GtkWidget *widget, GtkAllocation *allocation) label = NAUTILUS_LABEL (widget); - /* FIXME: + /* FIXME bugzilla.eazel.com 5083: * this never happens */ if ((int) label->detail->line_wrap_width == -1) { @@ -571,7 +571,7 @@ label_recompute_line_geometries (NautilusLabel *label) /* determine the width to use for wrapping. A wrap width of -1 means use all of the available space. */ /* Don't use it if the widget is too small, since we won't be able to fit any words in */ - /* FIXME: + /* FIXME bugzilla.eazel.com 5083: * the -1 case never happens */ if ((int) label->detail->line_wrap_width == -1 && clipped_widget_width > 32) { diff --git a/libnautilus-extensions/nautilus-merged-directory.c b/libnautilus-extensions/nautilus-merged-directory.c index 8259d7c24..e0a50f1eb 100644 --- a/libnautilus-extensions/nautilus-merged-directory.c +++ b/libnautilus-extensions/nautilus-merged-directory.c @@ -496,7 +496,7 @@ nautilus_merged_directory_add_real_directory (NautilusMergedDirectory *merged, done_loading_callback, merged); - /* FIXME: The done_loading part won't work for the case where + /* FIXME bugzilla.eazel.com 5084: The done_loading part won't work for the case where * we have no directories in our list. */ diff --git a/libnautilus-extensions/nautilus-mime-actions.c b/libnautilus-extensions/nautilus-mime-actions.c index 166fdf074..52d91b0d4 100644 --- a/libnautilus-extensions/nautilus-mime-actions.c +++ b/libnautilus-extensions/nautilus-mime-actions.c @@ -213,7 +213,8 @@ nautilus_mime_get_default_application_for_file_internal (NautilusFile *file, default_application_string = nautilus_file_get_metadata (file, NAUTILUS_METADATA_KEY_DEFAULT_APPLICATION, NULL); - /* FIXME: should fall back to normal default if user-specified default is bogus */ + /* FIXME bugzilla.eazel.com 5085: should fall back to normal default + if user-specified default is bogus */ if (default_application_string == NULL) { mime_type = nautilus_file_get_mime_type (file); @@ -623,7 +624,7 @@ nautilus_mime_get_short_list_components_for_file (NautilusFile *file) return result; } -/* FIXME: we should disable this for 1.0 I think */ +/* FIXME bugzilla.eazel.com 5086: we should disable this for 1.0 I think */ char * nautilus_mime_get_short_list_methods_for_file (NautilusFile *file) diff --git a/libnautilus-extensions/nautilus-scalable-font.c b/libnautilus-extensions/nautilus-scalable-font.c index 7475d5ccb..f62e6aa02 100644 --- a/libnautilus-extensions/nautilus-scalable-font.c +++ b/libnautilus-extensions/nautilus-scalable-font.c @@ -1656,7 +1656,7 @@ nautilus_text_layout_paint (const NautilusTextLayout *text_layout, g_return_if_fail (destination_pixbuf != NULL); g_return_if_fail (justification >= GTK_JUSTIFY_LEFT && justification <= GTK_JUSTIFY_FILL); - /* FIXME: Make sure the color we are fed is opaque. The real solution is + /* FIXME bugzilla.eazel.com 5087: Make sure the color we are fed is opaque. The real solution is * to fix the callers. */ color = NAUTILUS_RGBA_COLOR_PACK (NAUTILUS_RGBA_COLOR_GET_R (color), diff --git a/libnautilus-extensions/nautilus-search-uri.c b/libnautilus-extensions/nautilus-search-uri.c index f0d215856..0ae0c2771 100644 --- a/libnautilus-extensions/nautilus-search-uri.c +++ b/libnautilus-extensions/nautilus-search-uri.c @@ -677,15 +677,15 @@ nautilus_self_check_search_uri (void) /* make sure all the code paths work */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains stuff"), _("Items with \"stuff\" in the name")); - /* FIXME: This may be what the function calls "human", but it's bad grammar. */ + /* FIXME bugzilla.eazel.com 5088: This may be what the function calls "human", but it's bad grammar. */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains stuff & file_type is file"), _("Items with \"stuff\" in the name and are regular files")); - /* FIXME: This may be what the function calls "human", but it's bad grammar. */ + /* FIXME bugzilla.eazel.com 5088: This may be what the function calls "human", but it's bad grammar. */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains stuff & file_type is file" " & size smaller_than 2000"), _("Items with \"stuff\" in the name, are regular files and " "smaller than 2000 bytes")); - /* FIXME: This may be what the function calls "human", but it's bad grammar. */ + /* FIXME bugzilla.eazel.com 5088: This may be what the function calls "human", but it's bad grammar. */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains medusa & file_type is directory"), _("Items with \"medusa\" in the name and are " "folders")); diff --git a/libnautilus-extensions/nautilus-string.c b/libnautilus-extensions/nautilus-string.c index da4b63f0d..c1ce968a6 100644 --- a/libnautilus-extensions/nautilus-string.c +++ b/libnautilus-extensions/nautilus-string.c @@ -464,7 +464,7 @@ nautilus_str_capitalize (const char *string) /* Note: nautilus_string_ellipsize_* that use a length in pixels * rather than characters can be found in nautilus_gdk_extensions.h * - * FIXME: + * FIXME bugzilla.eazel.com 5089: * we should coordinate the names of nautilus_string_ellipsize_* * and nautilus_str_*_truncate so that they match better and reflect * their different behavior. diff --git a/libnautilus-extensions/nautilus-undo-signal-handlers.c b/libnautilus-extensions/nautilus-undo-signal-handlers.c index 23c189418..e55efb140 100644 --- a/libnautilus-extensions/nautilus-undo-signal-handlers.c +++ b/libnautilus-extensions/nautilus-undo-signal-handlers.c @@ -291,7 +291,7 @@ restore_editable_from_undo_snapshot_callback (GtkObject *target, gpointer callba /* FIXME bugzilla.eazel.com 3515: Undo doesn't work */ #ifdef UNDO_ENABLED -/* FIXME: This needs a return value of gboolean. */ +/* FIXME bugzilla.eazel.com 5090: This needs a return value of gboolean. */ static void editable_key_press_event (GtkEditable *editable, GdkEventKey *event, gpointer user_data) { @@ -300,7 +300,8 @@ editable_key_press_event (GtkEditable *editable, GdkEventKey *event, gpointer us case 'z': if ((event->state & GDK_CONTROL_MASK) != 0) { nautilus_undo (GTK_OBJECT (editable)); - /* FIXME: Need to stop the signal to prevent + /* FIXME bugzilla.eazel.com 5091: Need to stop the + signal to prevent * re-handling the same event. */ return; @@ -332,7 +333,8 @@ nautilus_undo_editable_set_undo_key (GtkEditable *editable, gboolean value) GTK_SIGNAL_FUNC (editable_key_press_event), NULL); } else { - /* FIXME: This warns if the handler is already connected. */ + /* FIXME bugzilla.eazel.com 5092: This warns if + the handler is already connected. */ gtk_signal_disconnect_by_func (GTK_OBJECT (editable), GTK_SIGNAL_FUNC (editable_key_press_event), NULL); diff --git a/libnautilus-private/nautilus-customization-data.c b/libnautilus-private/nautilus-customization-data.c index 00814b124..0f8e38cf9 100644 --- a/libnautilus-private/nautilus-customization-data.c +++ b/libnautilus-private/nautilus-customization-data.c @@ -376,7 +376,7 @@ format_name_for_display (const char* name) formatted_str = strip_extension (name); - /* FIXME: Not appropriate to upper-case the letter of the name + /* FIXME bugzilla.eazel.com 5046: Not appropriate to upper-case the letter of the name * after a space for all languages. A potential translation * nightmare. */ diff --git a/libnautilus-private/nautilus-directory-async.c b/libnautilus-private/nautilus-directory-async.c index 7ee6a7de5..dc25425fc 100644 --- a/libnautilus-private/nautilus-directory-async.c +++ b/libnautilus-private/nautilus-directory-async.c @@ -1218,7 +1218,7 @@ dequeue_pending_idle_callback (gpointer callback_data) file_info = node->data; /* Update the file count. */ - /* FIXME: This could count a file twice if we get it + /* FIXME bugzilla.eazel.com 5063: This could count a file twice if we get it * from both load_directory and from * new_files_callback. Not too hard to fix by moving * this into the actual callback instead of waiting @@ -3214,7 +3214,7 @@ cancel_loading_attributes (NautilusDirectory *directory, file_info_cancel (directory); } - /* FIXME: implement cancelling metadata when we + /* FIXME bugzilla.eazel.com 5064: implement cancelling metadata when we implement forgetting metadata */ } @@ -3247,6 +3247,6 @@ nautilus_directory_cancel_loading_file_attributes (NautilusDirectory *directory, cancel_activation_uri_for_file (directory, file); } - /* FIXME: implement cancelling metadata when we + /* FIXME bugzilla.eazel.com 5064: implement cancelling metadata when we implement forgetting metadata */ } diff --git a/libnautilus-private/nautilus-directory.c b/libnautilus-private/nautilus-directory.c index 4a6834d5c..7f3b9c26f 100644 --- a/libnautilus-private/nautilus-directory.c +++ b/libnautilus-private/nautilus-directory.c @@ -976,7 +976,7 @@ nautilus_directory_handle_directory_moved (NautilusDirectory *directory, directory->details->private_metafile_vfs_uri = construct_private_metafile_vfs_uri (to_uri); - /* FIXME: we also need to rename the private metafile, if it + /* FIXME bugzilla.eazel.com 5065: we also need to rename the private metafile, if it exists, don't we. */ if (directory->details->vfs_uri != NULL) { @@ -998,7 +998,7 @@ nautilus_directory_handle_directory_moved (NautilusDirectory *directory, directory->details->uri, directory); - /* FIXME: need to handle updating child directories as well */ + /* FIXME bugzilla.eazel.com 5066: need to handle updating child directories as well */ } void @@ -1085,7 +1085,7 @@ nautilus_directory_notify_files_moved (GList *uri_pairs) * it from the get_parent_directory * function so we don't have to ref. */ - /* FIXME: Doesn't update the link hash table. */ + /* FIXME bugzilla.eazel.com 5067: Doesn't update the link hash table. */ file->details->directory = new_directory; /* Add to new directory. */ @@ -1510,7 +1510,7 @@ nautilus_self_check_directory (void) NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("http://le-hackeur.org/"), "http://le-hackeur.org"); NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("http://le-hackeur.org/dir"), "http://le-hackeur.org/dir"); NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("http://le-hackeur.org/dir/"), "http://le-hackeur.org/dir"); - /* FIXME: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ + /* FIXME bugzilla.eazel.com 5068: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("search://[file://]file_name contains stuff"), "search://[file/]file_name contains stuff"); #ifdef EAZEL_SERVICES NAUTILUS_CHECK_STRING_RESULT (nautilus_directory_make_uri_canonical ("eazel-services:/~turtle"), "eazel-services:///~turtle"); diff --git a/libnautilus-private/nautilus-file-utilities.c b/libnautilus-private/nautilus-file-utilities.c index ac58afdc2..dca503d23 100644 --- a/libnautilus-private/nautilus-file-utilities.c +++ b/libnautilus-private/nautilus-file-utilities.c @@ -324,7 +324,8 @@ nautilus_make_uri_canonical (const char *uri) old_uri = canonical_uri; if (old_uri[0] != '/') { - /* FIXME: bandaid alert. Is this really the right thing to do? + /* FIXME bugzilla.eazel.com 5069: + * bandaid alert. Is this really the right thing to do? * * We got what really is a relative path. We do a little bit of * a stretch here and assume it was meant to be a cryptic absolute path, @@ -984,7 +985,7 @@ pthread_nautilus_read_file_thread_entry (void *cast_to_data) } buffer = g_realloc (buffer, total_bytes_read + READ_CHUNK_SIZE); - /* FIXME: + /* FIXME bugzilla.eazel.com 5070: * For a better cancellation granularity we should use gnome_vfs_read_cancellable * here, adding a GnomeVFSContext to NautilusAsyncReadFileData. */ @@ -1066,7 +1067,7 @@ pthread_nautilus_read_file_async(const char *uri, NautilusReadFileCallback callb pthread_attr_init (&thread_attr); pthread_attr_setdetachstate (&thread_attr, PTHREAD_CREATE_DETACHED); if (pthread_create (&thread, &thread_attr, pthread_nautilus_read_file_thread_entry, data) != 0) { - /* FIXME: + /* FIXME bugzilla.eazel.com 5071: * Would be cleaner to call through an idle callback here. */ (*callback) (GNOME_VFS_ERROR_INTERNAL, 0, NULL, NULL); @@ -1141,6 +1142,7 @@ nautilus_read_file_cancel (NautilusReadFileHandle *handle) g_free (handle->buffer); g_free (handle); #else + pthread_nautilus_read_file_async_cancel (handle); #endif } @@ -1267,7 +1269,7 @@ nautilus_self_check_file_utilities (void) /* nautilus_make_uri_canonical */ - /* FIXME: this is a bizarre result from an empty string */ + /* FIXME bugzilla.eazel.com 5072: this is a bizarre result from an empty string */ NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical (""), "file:///"); NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("file:/"), "file:///"); @@ -1281,7 +1283,7 @@ nautilus_self_check_file_utilities (void) NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("http://le-hackeur.org/dir"), "http://le-hackeur.org/dir"); NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("http://le-hackeur.org/dir/"), "http://le-hackeur.org/dir/"); - /* FIXME: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ + /* FIXME bugzilla.eazel.com 5068: the "nested" URI loses some characters here. Maybe that's OK because we escape them in practice? */ NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("search://[file://]file_name contains stuff"), "search://[file/]file_name contains stuff"); #ifdef EAZEL_SERVICES NAUTILUS_CHECK_STRING_RESULT (nautilus_make_uri_canonical ("eazel-services:/~turtle"), "eazel-services:///~turtle"); diff --git a/libnautilus-private/nautilus-file.c b/libnautilus-private/nautilus-file.c index 04b24dcb2..9c051b4b7 100644 --- a/libnautilus-private/nautilus-file.c +++ b/libnautilus-private/nautilus-file.c @@ -3630,14 +3630,16 @@ get_description (NautilusFile *file) mime_type = file->details->info->mime_type; } - /* FIXME: When this code was originally written, unknown types + /* FIXME bugzilla.eazel.com 5073: When this code was originally written, + * unknown types * were represented by NULL, but now they are represented by * "application/octet-string". Perhaps we want to check for * that here, so "program" will appear more often. */ if (nautilus_strlen (mime_type) == 0) { /* No MIME type, anything else interesting we can say about this? */ - /* FIXME: Maybe we should always return NULL when the + /* FIXME bugzilla.eazel.com 5074: Maybe we should always return NULL + * when the * MIME type is unknown. */ /* If it's a directory, call it "folder" before @@ -4358,7 +4360,7 @@ nautilus_file_forget_attributes_internal (NautilusFile *file, forget_activation_uri (file); } - /* FIXME: implement forgetting metadata */ + /* FIXME bugzilla.eazel.com 5075: implement forgetting metadata */ } diff --git a/libnautilus-private/nautilus-gdk-extensions.c b/libnautilus-private/nautilus-gdk-extensions.c index eb9821a93..faf92585c 100644 --- a/libnautilus-private/nautilus-gdk-extensions.c +++ b/libnautilus-private/nautilus-gdk-extensions.c @@ -269,7 +269,8 @@ nautilus_gradient_parse_one_color_spec (const char *spec, int *percent, const ch return result; } -/* FIXME anyone using nautilus_gradient_get_start_color_spec or +/* FIXME bugzilla.eazel.com 5076: + * anyone using nautilus_gradient_get_start_color_spec or * nautilus_gradient_get_end_color_spec is assuming the gradient * is 2 colors which is questionable. * diff --git a/libnautilus-private/nautilus-gdk-pixbuf-extensions.c b/libnautilus-private/nautilus-gdk-pixbuf-extensions.c index c6b967694..ef5b10a91 100644 --- a/libnautilus-private/nautilus-gdk-pixbuf-extensions.c +++ b/libnautilus-private/nautilus-gdk-pixbuf-extensions.c @@ -265,7 +265,7 @@ nautilus_cancel_gdk_pixbuf_load (NautilusPixbufLoadHandle *handle) free_pixbuf_load_handle (handle); } -/* FIXME +/* FIXME bugzilla.eazel.com 5077: * This fn is only used by some test code, it should probably be removed */ void diff --git a/libnautilus-private/nautilus-icon-container.c b/libnautilus-private/nautilus-icon-container.c index 39c58c78f..dfebe8d3c 100644 --- a/libnautilus-private/nautilus-icon-container.c +++ b/libnautilus-private/nautilus-icon-container.c @@ -4662,7 +4662,7 @@ nautilus_icon_container_start_renaming_selected_item (NautilusIconContainer *con editable_text, /* text */ TRUE); /* allocate local copy */ - /* FIXME: These callbacks don't have any side effects. + /* FIXME bugzilla.eazel.com 5078: These callbacks don't have any side effects. They should be removed */ /* Set up the signals */ gtk_signal_connect (GTK_OBJECT (details->rename_widget), "editing_started", @@ -4712,7 +4712,8 @@ end_renaming_mode (NautilusIconContainer *container, gboolean commit) hide_rename_widget (container, icon); } -/* FIXME: We're not exactly hiding this widget, we're destroying it! +/* FIXME bugzilla.eazel.com 5079: We're not exactly hiding this widget, + we're destroying it! Perhaps hide_rename_widget isn't the right name */ static void hide_rename_widget (NautilusIconContainer *container, NautilusIcon *icon) diff --git a/libnautilus-private/nautilus-icon-dnd.c b/libnautilus-private/nautilus-icon-dnd.c index f9b7e01d5..473ff79e7 100644 --- a/libnautilus-private/nautilus-icon-dnd.c +++ b/libnautilus-private/nautilus-icon-dnd.c @@ -591,7 +591,7 @@ receive_dropped_keyword (NautilusIconContainer *container, char* keyword, int x, static void receive_dropped_uri_list (NautilusIconContainer *container, char *uri_list, int x, int y) { - /* FIXME: + /* FIXME bugzilla.eazel.com 5080: * this needs a better name - it's link/desktop specific */ GList *li, *files; diff --git a/libnautilus-private/nautilus-icon-factory.c b/libnautilus-private/nautilus-icon-factory.c index c40f00316..4d2083432 100644 --- a/libnautilus-private/nautilus-icon-factory.c +++ b/libnautilus-private/nautilus-icon-factory.c @@ -107,7 +107,7 @@ static const char *icon_file_name_suffixes[] = /* Images are used themselves as thumbnails when they are below this * threshold size. */ -/* FIXME: Later we might have to have a more complex rule about when +/* FIXME bugzilla.eazel.com 5081: Later we might have to have a more complex rule about when * to use an image for itself. */ #define SELF_THUMBNAIL_SIZE_THRESHOLD 16384 @@ -115,7 +115,8 @@ static const char *icon_file_name_suffixes[] = /* Extremely large images can eat up hundreds of megabytes of memory, so we * shouldn't automatically thumbnail when larges are too large. */ -/* FIXME: Eventually, we want this threshold to be user-settable, but +/* FIXME bugzilla.eazel.com 5082: Eventually, we want this + * threshold to be user-settable, but * for now it's hard-wired. */ #define INHIBIT_THUMBNAIL_SIZE_THRESHOLD (1024 * 1024) diff --git a/libnautilus-private/nautilus-label.c b/libnautilus-private/nautilus-label.c index ac931e183..e7a983802 100644 --- a/libnautilus-private/nautilus-label.c +++ b/libnautilus-private/nautilus-label.c @@ -333,7 +333,7 @@ nautilus_label_size_allocate (GtkWidget *widget, GtkAllocation *allocation) label = NAUTILUS_LABEL (widget); - /* FIXME: + /* FIXME bugzilla.eazel.com 5083: * this never happens */ if ((int) label->detail->line_wrap_width == -1) { @@ -571,7 +571,7 @@ label_recompute_line_geometries (NautilusLabel *label) /* determine the width to use for wrapping. A wrap width of -1 means use all of the available space. */ /* Don't use it if the widget is too small, since we won't be able to fit any words in */ - /* FIXME: + /* FIXME bugzilla.eazel.com 5083: * the -1 case never happens */ if ((int) label->detail->line_wrap_width == -1 && clipped_widget_width > 32) { diff --git a/libnautilus-private/nautilus-merged-directory.c b/libnautilus-private/nautilus-merged-directory.c index 8259d7c24..e0a50f1eb 100644 --- a/libnautilus-private/nautilus-merged-directory.c +++ b/libnautilus-private/nautilus-merged-directory.c @@ -496,7 +496,7 @@ nautilus_merged_directory_add_real_directory (NautilusMergedDirectory *merged, done_loading_callback, merged); - /* FIXME: The done_loading part won't work for the case where + /* FIXME bugzilla.eazel.com 5084: The done_loading part won't work for the case where * we have no directories in our list. */ diff --git a/libnautilus-private/nautilus-mime-actions.c b/libnautilus-private/nautilus-mime-actions.c index 166fdf074..52d91b0d4 100644 --- a/libnautilus-private/nautilus-mime-actions.c +++ b/libnautilus-private/nautilus-mime-actions.c @@ -213,7 +213,8 @@ nautilus_mime_get_default_application_for_file_internal (NautilusFile *file, default_application_string = nautilus_file_get_metadata (file, NAUTILUS_METADATA_KEY_DEFAULT_APPLICATION, NULL); - /* FIXME: should fall back to normal default if user-specified default is bogus */ + /* FIXME bugzilla.eazel.com 5085: should fall back to normal default + if user-specified default is bogus */ if (default_application_string == NULL) { mime_type = nautilus_file_get_mime_type (file); @@ -623,7 +624,7 @@ nautilus_mime_get_short_list_components_for_file (NautilusFile *file) return result; } -/* FIXME: we should disable this for 1.0 I think */ +/* FIXME bugzilla.eazel.com 5086: we should disable this for 1.0 I think */ char * nautilus_mime_get_short_list_methods_for_file (NautilusFile *file) diff --git a/libnautilus-private/nautilus-scalable-font.c b/libnautilus-private/nautilus-scalable-font.c index 7475d5ccb..f62e6aa02 100644 --- a/libnautilus-private/nautilus-scalable-font.c +++ b/libnautilus-private/nautilus-scalable-font.c @@ -1656,7 +1656,7 @@ nautilus_text_layout_paint (const NautilusTextLayout *text_layout, g_return_if_fail (destination_pixbuf != NULL); g_return_if_fail (justification >= GTK_JUSTIFY_LEFT && justification <= GTK_JUSTIFY_FILL); - /* FIXME: Make sure the color we are fed is opaque. The real solution is + /* FIXME bugzilla.eazel.com 5087: Make sure the color we are fed is opaque. The real solution is * to fix the callers. */ color = NAUTILUS_RGBA_COLOR_PACK (NAUTILUS_RGBA_COLOR_GET_R (color), diff --git a/libnautilus-private/nautilus-search-uri.c b/libnautilus-private/nautilus-search-uri.c index f0d215856..0ae0c2771 100644 --- a/libnautilus-private/nautilus-search-uri.c +++ b/libnautilus-private/nautilus-search-uri.c @@ -677,15 +677,15 @@ nautilus_self_check_search_uri (void) /* make sure all the code paths work */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains stuff"), _("Items with \"stuff\" in the name")); - /* FIXME: This may be what the function calls "human", but it's bad grammar. */ + /* FIXME bugzilla.eazel.com 5088: This may be what the function calls "human", but it's bad grammar. */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains stuff & file_type is file"), _("Items with \"stuff\" in the name and are regular files")); - /* FIXME: This may be what the function calls "human", but it's bad grammar. */ + /* FIXME bugzilla.eazel.com 5088: This may be what the function calls "human", but it's bad grammar. */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains stuff & file_type is file" " & size smaller_than 2000"), _("Items with \"stuff\" in the name, are regular files and " "smaller than 2000 bytes")); - /* FIXME: This may be what the function calls "human", but it's bad grammar. */ + /* FIXME bugzilla.eazel.com 5088: This may be what the function calls "human", but it's bad grammar. */ NAUTILUS_CHECK_STRING_RESULT (nautilus_search_uri_to_human ("search:[][]file_name contains medusa & file_type is directory"), _("Items with \"medusa\" in the name and are " "folders")); diff --git a/libnautilus-private/nautilus-string.c b/libnautilus-private/nautilus-string.c index da4b63f0d..c1ce968a6 100644 --- a/libnautilus-private/nautilus-string.c +++ b/libnautilus-private/nautilus-string.c @@ -464,7 +464,7 @@ nautilus_str_capitalize (const char *string) /* Note: nautilus_string_ellipsize_* that use a length in pixels * rather than characters can be found in nautilus_gdk_extensions.h * - * FIXME: + * FIXME bugzilla.eazel.com 5089: * we should coordinate the names of nautilus_string_ellipsize_* * and nautilus_str_*_truncate so that they match better and reflect * their different behavior. diff --git a/libnautilus-private/nautilus-undo-signal-handlers.c b/libnautilus-private/nautilus-undo-signal-handlers.c index 23c189418..e55efb140 100644 --- a/libnautilus-private/nautilus-undo-signal-handlers.c +++ b/libnautilus-private/nautilus-undo-signal-handlers.c @@ -291,7 +291,7 @@ restore_editable_from_undo_snapshot_callback (GtkObject *target, gpointer callba /* FIXME bugzilla.eazel.com 3515: Undo doesn't work */ #ifdef UNDO_ENABLED -/* FIXME: This needs a return value of gboolean. */ +/* FIXME bugzilla.eazel.com 5090: This needs a return value of gboolean. */ static void editable_key_press_event (GtkEditable *editable, GdkEventKey *event, gpointer user_data) { @@ -300,7 +300,8 @@ editable_key_press_event (GtkEditable *editable, GdkEventKey *event, gpointer us case 'z': if ((event->state & GDK_CONTROL_MASK) != 0) { nautilus_undo (GTK_OBJECT (editable)); - /* FIXME: Need to stop the signal to prevent + /* FIXME bugzilla.eazel.com 5091: Need to stop the + signal to prevent * re-handling the same event. */ return; @@ -332,7 +333,8 @@ nautilus_undo_editable_set_undo_key (GtkEditable *editable, gboolean value) GTK_SIGNAL_FUNC (editable_key_press_event), NULL); } else { - /* FIXME: This warns if the handler is already connected. */ + /* FIXME bugzilla.eazel.com 5092: This warns if + the handler is already connected. */ gtk_signal_disconnect_by_func (GTK_OBJECT (editable), GTK_SIGNAL_FUNC (editable_key_press_event), NULL); |