diff options
-rw-r--r-- | ChangeLog | 14 | ||||
-rw-r--r-- | src/nautilus-applicable-views.c | 22 | ||||
-rw-r--r-- | src/nautilus-bookmarks-window.c | 3 | ||||
-rw-r--r-- | src/nautilus-location-bar.c | 4 | ||||
-rw-r--r-- | src/nautilus-main.c | 6 | ||||
-rw-r--r-- | src/nautilus-navigation-window-menus.c | 4 | ||||
-rw-r--r-- | src/nautilus-window-menus.c | 4 | ||||
-rw-r--r-- | src/nautilus-zoom-control.c | 4 | ||||
-rw-r--r-- | src/ntl-main.c | 6 | ||||
-rw-r--r-- | src/ntl-uri-map.c | 22 |
10 files changed, 68 insertions, 21 deletions
@@ -1,6 +1,20 @@ 2000-04-26 John Sullivan <sullivan@eazel.com> More FIXME-to-bug work. + + * src/nautilus-bookmarks-window.c, + * src/nautilus-location-bar.c, + * src/nautilus-window-menus.c, + * src/nautilus-zoom-control.c, + * src/ntl-main.c, + * src/ntl-uri-map.c: + + Wrote bug reports for all FIXMEs in these files. Down to + 71 in Nautilus with no bug report. + +2000-04-26 John Sullivan <sullivan@eazel.com> + + More FIXME-to-bug work. * src/nautilus-index-title.c, * libnautilus-extensions/nautilus-gdk-extensions.h, diff --git a/src/nautilus-applicable-views.c b/src/nautilus-applicable-views.c index 43768713d..9b4b27e07 100644 --- a/src/nautilus-applicable-views.c +++ b/src/nautilus-applicable-views.c @@ -226,7 +226,9 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, } else if (nautilus_str_has_prefix (navinfo->navinfo.requested_uri, "hardware:")) { navinfo->navinfo.content_type = g_strdup ("special/hardware"); vfs_result_code = GNOME_VFS_OK; - /* FIXME: This mozilla-hack should be short lived until http issues are solved */ + /* FIXME bugzilla.eazel.com 522: + * This mozilla-hack should be short lived until http issues are solved + */ } else if (nautilus_str_has_prefix (navinfo->navinfo.requested_uri, "moz:")) { navinfo->navinfo.content_type = g_strdup ("special/mozilla-hack"); vfs_result_code = GNOME_VFS_OK; @@ -302,7 +304,10 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, /* besides the information in OAF/GConf, we also want to offer components that are specifically refered to in the metadata, so we ask the metadata for content views here and add them accordingly. */ - /* FIXME: for now, we just do this for directories but it should apply to all places with available metadata */ + /* FIXME bugzilla.eazel.com 673: + * for now, we just do this for directories but it should apply to + * all places with available metadata + */ add_components_from_metadata (navinfo); } else if (strcmp (navinfo->navinfo.content_type, "special/webdav-directory") == 0) { fallback_iid = "OAFIID:ntl_web_browser:0ce1a736-c939-4ac7-b12c-19d72bf1510b"; @@ -322,7 +327,10 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, /* besides the information in OAF/GConf, we also want to offer components that are specifically refered to in the metadata, so we ask the metadata for content views here and add them accordingly. */ - /* FIXME: for now, we just do this for directories but it should apply to all places with available metadata */ + /* FIXME bugzilla.eazel.com 673: + * for now, we just do this for directories but it should apply to + * all places with available metadata + */ add_components_from_metadata (navinfo); } else if (strcmp (navinfo->navinfo.content_type, "application/x-rpm") == 0 || nautilus_str_has_suffix (navinfo->navinfo.requested_uri, ".rpm")) { @@ -341,7 +349,9 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, navinfo->content_identifiers = g_slist_append (navinfo->content_identifiers, nautilus_view_identifier_new ("OAFIID:nautilus_hardware_view:20000422-2250", "Hardware")); - /* FIXME: This mozilla-hack should be short lived until http issues are solved */ + /* FIXME bugzilla.eazel.com 522: + * This mozilla-hack should be short lived until http issues are solved + */ } else if (strcmp(navinfo->navinfo.content_type, "special/mozilla-hack") == 0) { fallback_iid = "OAFIID:nautilus_mozilla_content_view:1ee70717-57bf-4079-aae5-922abdd576b1"; navinfo->content_identifiers = g_slist_append @@ -359,7 +369,9 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, goto out; } - /* FIXME: Should do this only when in some special testing mode or something. */ + /* FIXME bugzilla.eazel.com 674: + * Should do this only when in some special testing mode or something. + */ navinfo->content_identifiers = g_slist_append (navinfo->content_identifiers, nautilus_view_identifier_new ("OAFIID:nautilus_sample_content_view:45c746bd-7d64-4346-90d5-6410463b43ae", "Sample")); diff --git a/src/nautilus-bookmarks-window.c b/src/nautilus-bookmarks-window.c index 9173b903a..1ea7558ea 100644 --- a/src/nautilus-bookmarks-window.c +++ b/src/nautilus-bookmarks-window.c @@ -336,7 +336,8 @@ nautilus_bookmarks_window_restore_geometry (GtkWidget *window) height = CLAMP (height, BOOKMARKS_WINDOW_MIN_HEIGHT, gdk_screen_height()); top = CLAMP (top, 0, gdk_screen_height() - MINIMUM_ON_SCREEN_HEIGHT); - /* FIXME: If window has negative left coordinate, set_uposition sends it + /* FIXME bugzilla.eazel.com 669: + * If window has negative left coordinate, set_uposition sends it * somewhere else entirely. Not sure what level contains this bug (XWindows?). * Hacked around by pinning the left edge to zero. */ diff --git a/src/nautilus-location-bar.c b/src/nautilus-location-bar.c index f2b149029..1baab5404 100644 --- a/src/nautilus-location-bar.c +++ b/src/nautilus-location-bar.c @@ -102,7 +102,9 @@ drag_data_received_cb (GtkWidget *widget, return; } - /* FIXME: When more than one URI is dragged here, should we make windows? */ + /* FIXME bugzilla.eazel.com 670: + * When more than one URI is dragged here, should we make windows? + */ if (nautilus_g_list_more_than_one_item (names)) { g_warning ("Should we make more windows?"); } diff --git a/src/nautilus-main.c b/src/nautilus-main.c index 17c78140d..19924dc7b 100644 --- a/src/nautilus-main.c +++ b/src/nautilus-main.c @@ -75,8 +75,10 @@ main(int argc, char *argv[]) options, 0, &ctx); orb = oaf_init (argc, argv); - /* FIXME: Need better error reporting if this fails. BUT, is it too - * early to post a dialog here ? */ + /* FIXME bugzilla.eazel.com 672: + * Need better error reporting if this fails. BUT, is it too + * early to post a dialog here ? Also, shouldn't put non-debug + * code inside an assert! */ g_assert (nautilus_preferences_initialize (argc, argv)); bonobo_init (orb, CORBA_OBJECT_NIL, CORBA_OBJECT_NIL); diff --git a/src/nautilus-navigation-window-menus.c b/src/nautilus-navigation-window-menus.c index 381ca4ce6..a6faf2ea4 100644 --- a/src/nautilus-navigation-window-menus.c +++ b/src/nautilus-navigation-window-menus.c @@ -123,8 +123,8 @@ static GnomeUIInfo file_menu_info[] = { GNOMEUIINFO_END }; -/* FIXME: These all need implementation, though we might end up doing that - * separately for each content view (and merging with the insensitive items here) +/* These items are always present, but they're insensitive unless + * a component has merged a sensitive item over them. */ static GnomeUIInfo edit_menu_info[] = { GNOMEUIINFO_MENU_UNDO_ITEM(NULL, NULL), diff --git a/src/nautilus-window-menus.c b/src/nautilus-window-menus.c index 381ca4ce6..a6faf2ea4 100644 --- a/src/nautilus-window-menus.c +++ b/src/nautilus-window-menus.c @@ -123,8 +123,8 @@ static GnomeUIInfo file_menu_info[] = { GNOMEUIINFO_END }; -/* FIXME: These all need implementation, though we might end up doing that - * separately for each content view (and merging with the insensitive items here) +/* These items are always present, but they're insensitive unless + * a component has merged a sensitive item over them. */ static GnomeUIInfo edit_menu_info[] = { GNOMEUIINFO_MENU_UNDO_ITEM(NULL, NULL), diff --git a/src/nautilus-zoom-control.c b/src/nautilus-zoom-control.c index 9744ffca6..caf3730f9 100644 --- a/src/nautilus-zoom-control.c +++ b/src/nautilus-zoom-control.c @@ -260,7 +260,9 @@ set_zoom_level(NautilusZoomControl *zoom_control, gint new_level) zoom_control->current_zoom = new_level; zoom_control->zoom_factor = (double) nautilus_get_icon_size_for_zoom_level (zoom_control->current_zoom) / NAUTILUS_ICON_SIZE_STANDARD; - /* FIXME: tell the content view about the zoom change here soon */ + /* FIXME bugzilla.eazel.com 671: + * tell the content view about the zoom change here soon + */ } /* handle button presses */ diff --git a/src/ntl-main.c b/src/ntl-main.c index 17c78140d..19924dc7b 100644 --- a/src/ntl-main.c +++ b/src/ntl-main.c @@ -75,8 +75,10 @@ main(int argc, char *argv[]) options, 0, &ctx); orb = oaf_init (argc, argv); - /* FIXME: Need better error reporting if this fails. BUT, is it too - * early to post a dialog here ? */ + /* FIXME bugzilla.eazel.com 672: + * Need better error reporting if this fails. BUT, is it too + * early to post a dialog here ? Also, shouldn't put non-debug + * code inside an assert! */ g_assert (nautilus_preferences_initialize (argc, argv)); bonobo_init (orb, CORBA_OBJECT_NIL, CORBA_OBJECT_NIL); diff --git a/src/ntl-uri-map.c b/src/ntl-uri-map.c index 43768713d..9b4b27e07 100644 --- a/src/ntl-uri-map.c +++ b/src/ntl-uri-map.c @@ -226,7 +226,9 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, } else if (nautilus_str_has_prefix (navinfo->navinfo.requested_uri, "hardware:")) { navinfo->navinfo.content_type = g_strdup ("special/hardware"); vfs_result_code = GNOME_VFS_OK; - /* FIXME: This mozilla-hack should be short lived until http issues are solved */ + /* FIXME bugzilla.eazel.com 522: + * This mozilla-hack should be short lived until http issues are solved + */ } else if (nautilus_str_has_prefix (navinfo->navinfo.requested_uri, "moz:")) { navinfo->navinfo.content_type = g_strdup ("special/mozilla-hack"); vfs_result_code = GNOME_VFS_OK; @@ -302,7 +304,10 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, /* besides the information in OAF/GConf, we also want to offer components that are specifically refered to in the metadata, so we ask the metadata for content views here and add them accordingly. */ - /* FIXME: for now, we just do this for directories but it should apply to all places with available metadata */ + /* FIXME bugzilla.eazel.com 673: + * for now, we just do this for directories but it should apply to + * all places with available metadata + */ add_components_from_metadata (navinfo); } else if (strcmp (navinfo->navinfo.content_type, "special/webdav-directory") == 0) { fallback_iid = "OAFIID:ntl_web_browser:0ce1a736-c939-4ac7-b12c-19d72bf1510b"; @@ -322,7 +327,10 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, /* besides the information in OAF/GConf, we also want to offer components that are specifically refered to in the metadata, so we ask the metadata for content views here and add them accordingly. */ - /* FIXME: for now, we just do this for directories but it should apply to all places with available metadata */ + /* FIXME bugzilla.eazel.com 673: + * for now, we just do this for directories but it should apply to + * all places with available metadata + */ add_components_from_metadata (navinfo); } else if (strcmp (navinfo->navinfo.content_type, "application/x-rpm") == 0 || nautilus_str_has_suffix (navinfo->navinfo.requested_uri, ".rpm")) { @@ -341,7 +349,9 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, navinfo->content_identifiers = g_slist_append (navinfo->content_identifiers, nautilus_view_identifier_new ("OAFIID:nautilus_hardware_view:20000422-2250", "Hardware")); - /* FIXME: This mozilla-hack should be short lived until http issues are solved */ + /* FIXME bugzilla.eazel.com 522: + * This mozilla-hack should be short lived until http issues are solved + */ } else if (strcmp(navinfo->navinfo.content_type, "special/mozilla-hack") == 0) { fallback_iid = "OAFIID:nautilus_mozilla_content_view:1ee70717-57bf-4079-aae5-922abdd576b1"; navinfo->content_identifiers = g_slist_append @@ -359,7 +369,9 @@ my_notify_when_ready (GnomeVFSAsyncHandle *ah, goto out; } - /* FIXME: Should do this only when in some special testing mode or something. */ + /* FIXME bugzilla.eazel.com 674: + * Should do this only when in some special testing mode or something. + */ navinfo->content_identifiers = g_slist_append (navinfo->content_identifiers, nautilus_view_identifier_new ("OAFIID:nautilus_sample_content_view:45c746bd-7d64-4346-90d5-6410463b43ae", "Sample")); |