| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
This pointer may be NULL. Usually this may happen only during window
initialization and destruction. However, for robustness, make sure
every use either handles a NULL pointer or asserts it's non-NULL.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to explicitly set the active slot when closing a tab. However,
we now let GtkNotebook pick the next tab, and wait for ::switch-tab to
set the active_slot field to the one GtkNotebook picked, thanks to
commit 475684ac9e556b144da594bf25581560d4fa5a7f.
However, if the closed tab was the only tab in this window, then
::switch-tab is never called, so active_slot becomes a dangling
pointer, crashing the application when trying to close the window.
Use a weak reference to ensure the pointer is set to NULL in that case.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1759
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
The CI currently fails because the latest libhandly release is not yet
in rawhide. Let's add libhandy master to our image to fix the pipeline.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
We can't use HdyStatusPage right now because it would break DnD, as
reported in https://gitlab.gnome.org/GNOME/gtk/-/issues/808
So, update the styling instead.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Currently, gtk_builder_add_from_resource silently fails with old libhandy
version which leads to weird crashes. Let's print the returned error to
be obvious what is going on.
|
| |
|
|
|
| |
Nautilus currenlty crashes with libhandy version older than 1.1.90.
Let's bump the dependency to prevent that.
|
| |
|
|
|
|
|
|
|
|
| |
We have been matching the Star column by it's title, ever since it was
first introduced by commit a9c446afe262b7989bc17ef1f9ab19931db8dede
Worse: we have been using an untranslated string. This means that if
the string is localized clicking the star icons does nothing.
Match the column by its key in the hash table instead.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While "Star" is 4 chars long in English, it's longer in other languages.
This means the column may become much wider than needed for displaying
a small star icon, which both looks bad and takes away space from other
columns.
Since this is a column of star symbols, we don't really need a title.
But setting an empty title makes the columns too narrow (16px), which
gets covered by the overlay scrollbar.
So, in addition to removing the title label, set a 48 fixed width for
the column, which provides enough gutter for the overlay scrollbar.
|
| | |
|
| | |
|
| |
|
|
| |
Or, rather, dim the dirnames so the basenames stand out.
|
| |
|
|
|
|
|
|
| |
If the user enters a relative path, we get absolute paths as in the
completion popover, which is quite jarring and makes it less useful.
Instead, truncate the prefix, such that the completions dropdown text
aligns with the entry text.
|
| |
|
|
| |
Replace g_strchomp and g_strchug with g_strstrip, for simplicity.
|
| |
|
|
|
|
|
|
|
| |
Improves tab completion in the location entry. GtkEntryCompletion
shows a popup when there are multiple matches, so you can choose one
or continue typing. The completion's tree model is populated
dynamically as you type using a GFilenameCompleter.
https://gitlab.gnome.org/GNOME/nautilus/-/issues/1171
|
| |
|
|
|
|
|
| |
When you press Tab in the location entry and there's no autocomplete
suggestion, play an error bell instead of closing the location entry.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1171
|
| |
|
|
|
| |
It hasn't been useful for quite a while, and messes with the visual alignment
of the GtkEntryCompletion.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
The suggested name is in the form "original (1).txt", if the the
conflicting name was "original.txt".
The user may want to replace the "(1)" bits with something more
meaningful, so select this region for convenience.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
When "Select new name for the destination" expander is selected, the
users must type a new name in order to proceed.
This makes them go and look at the destination to see what would even
make a unique name.
Let's be more helpful and suggest a unique name based on the original.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/1344
|
| |
|
|
|
|
|
| |
.nautilus_directory holds a reference to a NautilusFile.
Rename it to .nautilus_directory_file, so that the existing name can
be reused to store a NautilusDirectory reference in the next commit.
|
| |
|
|
|
|
|
|
|
|
|
| |
The default action "Replace" is changed to "Rename" if a different name
is set in the entry inside the "Select a new name..." expander.
This means we have inconsistent UI states:
* "Select a new name..." is expanded but the action is "Replace",
* or it's collapsed but the default action is "Rename".
Instead, let's tie the default action to the expander's state.
|
| |
|
|
|
| |
This is needed to prevent the "signal 'request-passphrase' is invalid
for instance '0x1e41340' of type 'AutoarExtractor'" warnings.
|
| |
|
|
|
| |
The CI currently fails because the gnome-autoar 0.3.0 is not yet in rawhide.
Let's add gnome-autoar master to our image to fix the pipeline.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This implementation launches a GtkDialog for users to enter a password
when gnome-autoar reports that a given archive is password protected.
We use an additional GMainContext to block the execution until a password
string can be passed to AutoarExtractor's "passphrase-request" signal. This
solution is an alternative to gtk_dialog_run(), which is not available
in GTK4. See https://ondrej.holych.net/how-to-call-asynchronous-function-synchronously/
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/327
|
| | |
|
| | |
|
| | |
|
