| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "Apply this action to all files and folders" checkbox works only
with the "Replace" action, not the "Rename" action. Indeed, if the
rename field is expanded, the checkbox is greyed out.
However, if the checkbox is checked, when unchecking it changes the
main action to Rename, despite the rename field being obviously
hidden (otherwise the checkbox wouldn't be checked). That's wrong.
It's a regression from 15d59cd18de13b1c09dae1fe07102e213cdd9fd4
When the checkbox is unchecked, the action is already "Replace", so
there is no need to change it.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1889
|
| | |
|
| |
|
|
|
| |
I think that this code is a quite stable after 13 years of production,
so this TODO statement can be probably removed :-D
|
| |
|
|
|
| |
The progress is wrong when extracting multiple files and some of them
are skipped. Let's try to fix this.
|
| |
|
|
|
|
|
|
| |
In case of extraction failure, the "Skip" and "Cancel" actions are offered
everytime, but skipping doesn't make sense when extracting one file only.
Let's use the same approach as it is used also for other operations, which
is based on total number of files and remaining files. Also the "Skip All"
action will be offered as a side-effect of this change.
|
| |
|
|
|
|
|
| |
Currently, output files are checked for existence. But the files are
explicitely deleted in the case of extraction failure, so this extra
check is no more needed. Let's drop the redundant check and just update
the list when deleting the files.
|
| |
|
|
|
|
|
|
|
| |
Empty, or corrupted files are left in the output directory in the case
of extraction failure, e.g. when wrong password is supplied. This is
in most cases undesired. Let's recursively delete all the leftover
files in the case of extraction failure.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1954
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
For some reason, "buildah login" is not enough with fedora:latest
and "buildah push --creds" needs to be used to make it work again.
|
| |
|
|
|
|
|
| |
The lineup-parameters.c is hard to use with meson. Let's use the python
rewrite from
https://gitlab.gnome.org/GNOME/epiphany/-/blob/master/data/lineup-parameters
instead.
|
| |
|
|
|
|
| |
The fedora job was there before the flatpak job. But now we relies on
flatpak job and the fedora job doesn't really give much benefits. It is
rather waste of runners and maintainers time. Let's remove it.
|
| |
|
|
|
|
|
| |
The flatpak master job seems to be redundant currently. It uses the same
image as flatpak devel and their .yml files are equal. The two flatpak jobs
are relict from the times when GNOME SDK was unstable and broke CI often,
which is no more true. Let's remove the flatpak master job.
|
| |
|
|
|
|
|
|
| |
The style check job currently fails on stable branches since the recent
uncrustify change. We could use older image on stable, or backport the code
changes, but I think that the style check job on stable branches is not
actually needed. Let's disable the style check job on stable branches to
fix pipeline there and avoid this situation in the future.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Currently the keyboard focus for the type of archive choice is always on
the first element.
This patch allows the focus to be on the currently selected item instead.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1944
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The flatpak build currently fails because of gexiv2 build failure, which is
a problem for our contributors and among others breaks our CI pipeline. The
potential fix is available already for a couple of days on
https://gitlab.gnome.org/GNOME/gexiv2/-/merge_requests/63 but not yet merged.
Let's temporarily pin the gexiv2 and exiv2 dependencies to the stable branches
to fix those issues.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when an image was selected as wallpaper it would
be copied unconditionally into the "Wallpapers" directory.
The image would be copied even if it was already in the "Wallpapers"
directory, resulting in copies of the image being created in
the same directory. This made it incovenient to potentially store
multiple backgrounds in the "Wallpapers" directory and switch
between them due to the fact that each wallpaper change would
result in the selected image being copied.
To avoid this, introduce a check, and only copy the image
if its parent is not the "Wallpapers" directory (as determined
by `g_file_equal()`).
For local files, `g_file_equal()` only compares the absolute
paths - at least at the moment. Comparing paths is not enough
to decide whether two entities are really the same in the presence
of e.g. bind mounts. However, such configuration is arguably a
very rare (if not non-existent). Nonetheless, users should not
experience any regressions even in that case since when
`g_file_equal()` returns a false negative, the old behaviour
applies.
|
| |
|
|
|
|
|
| |
Use `g_file_new_build_filename()` to create the file object
for the "Wallpapers" directory instead of the previously
used `g_file_new_for_path()` + `g_file_get_child()` in
`set_wallpaper_fallback()`.
|
| |
|
|
|
|
| |
Instead of manually calling `g_object_unref()` and `g_free()`,
use `g_auto{free,ptr}` to (mostly) do away with the need
of manually managing the resources.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Clicking the "Properties" option in the right-click menu during
a search causes Nautilus to crash since the Properties dialog
handles files and directories, not search-view-directories.
Lets disable the "Properties" option when in search view.
Fixes #1491
|
| | |
|
| | |
|
