| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
|
|
| |
So they can be accessed easily from outside the view or window-slot.
This is useful for preventing layer violation, as we had in the past.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
And buttons in two sections, left and right.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
The new NautilusActionBar class handles everything
needed to be an usable actionbar as envisioned by
the available mockups.
|
| |
|
|
|
| |
This action will be consumed by the actionbar, to simplify
the development of the stop button.
|
| |
|
|
|
|
|
|
|
|
| |
Currently we don't have any way to track selection
changes, although NautilusView exposes selection. This
is an inconsistency in code, and should be avoided.
Fix that by adding a NautilusView::selection property
and deprecating the NautilusFilesView::selection-changed
signal.
|
| |
|
| |
This reverts commit d08d4c8fe1282085d9a86f372cdeafbd632c35f7
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently we have been seeing that gsettings doesn't work inside the
Flatpak build of Nautilus.
In https://gitlab.gnome.org/GNOME/nautilus/commit/3f6cd2feb258bab75b0b8355f526331d940d8845
we gave full host access to Nautilus, so I expected that no more
--filesystem permission would be necessary.
For some reason... we still need to put that. Although it looks like a
bug somewhere.
For now, let's just explicitly allow access the desrt folder.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The selected icon views captions show up in a wrong order below
files (e.g. third, first, second option instead of first, second,
third).
This is unintuitive and not intended.
This patch fixes the issue by changing the ordering of the captions.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/343
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The use new views preference checkbox does not update the view.
In order for it to take effect, one needs to toggle view.
This behaviour is not intended, and this should work same as
for other checkbox preferences.
We're fixing this by recreating the view whenever the preference box
is ticked/unticked.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/278
|
| |
|
|
| |
(cherry picked from commit 48b177ae678870f81cd95967662179900f12a93f)
|
| |
|
|
| |
So it has some nice icon showing.
|
| |
|
|
|
|
|
| |
Forgot to change one of the get_parent calls in c0198eca65ad.
In any case, this is really bad... we should use some g_object_set
I guess.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While selection is important for the content in the view or the current
path bar location, it doesn't seem to be so important for the sidebar,
since it's used more like a shortcut place to quickly navigate to
important places.
Also, the sidebar is more about showing the current state selected, and
not a selection of items.
To address both points seems to make sense to make the "selected" color
be less prominent than blue, and instead give a neutral gray.
This works gives the sidebar selected item a gray color.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The path bar would be looking better having a lighter design, and at the
same time a bit more colorful.
Ideally we would implement the new pathbar with animations, new styling,
etc. But that requires proper responsive design support and animation
support, which won't happen soon.
The relevant mockups are at https://wiki.gnome.org/Design/OS/Breadcrumbs
Partial work by Nikita Churaev at !145, modified styling by Lapo
Calamandrei.
Closes: #281
|
| |
|
|
|
|
|
|
| |
File utilities operations need to be tested thoroughly everytime
we make changes to make sure they're fine to use further.
This patch introduces an unit test file for the
nautilus_file_selection_equal.
|
| | |
|
| |\
| |
| |
| |
| | |
freedesktop-dbus: Acquire bus connection synchronously
See merge request GNOME/nautilus!188
|
| |/
|
|
|
|
|
| |
In some cases (particularly when no I/O is performed, e.g. opening
other-locations:/// directly), the FDO FileManager1 object
OpenLocations property is set before the connection is made. This commit
makes the code defer doing that until then.
|
| |\
| |
| |
| |
| | |
Don't use eel_show_error_dialog
See merge request GNOME/nautilus!173
|
| | |
| |
| |
| |
| |
| |
| | |
Instead of using eel_show_error_dialog, use the show_error_dialog
function from nautilus-ui-utilities.h header.
https://gitlab.gnome.org/GNOME/nautilus/issues/331
|
| | |
| |
| |
| |
| |
| |
| |
| | |
NAUTILUS_PREFERENCES_FILE_THUMBNAIL_LIMIT really uses MiB as its unit,
not MB as we multiply its value by 1024*1024 (MEGA_TO_BASE_RATE) in
thumbnail_limit_changed_callback(). This commit changes
MEGA_TO_BASE_RATE and its maximum value so that it shows a number using
MB unit as advertised.
|
| |/
|
|
|
| |
find_library expects the library name without the 'lib' prefix,
otherwise it will be looking for "liblibm"
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Creating and destroying the controller each time we want to rename
something results in not being able to pop down the popover, which leads
to an inconsistent look.
The “containing-directory” in the file name widget controller parent
class needed to be made non-construct-only, as otherwise it would be
impossible to reuse the same controller.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/260
|
| |
|
|
| |
(cherry picked from commit 470a13b04abdae4818bafabb3e1f3f59a43e3ada)
|
| |
|
| |
This reverts commit 01dca52cbdb6978fa9bb759dcd7d126a497e8185
|
| |
|
|
|
|
|
|
| |
This was due to size differences between bold and regular labels. The
problems was that invisible widgets always return 0 when their size is
requested and Nautilus tried to request the width a regular label would
take from an invisible bold label with the same text. This patch fixes
this by showing the label before measuring it and hiding it afterwards.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were always showing the starred item in the sidebar, with an empty
state in the resulting view if no starred file was present.
This is usually what we want for regular items. However, in 3.28 the
feature is not working as good as we expected for those not using
the tracker directories as heavily as other users.
In order to prevent being too annoying, we can hide the sidebar item if
no starred files are present, while still providing the context menu
to be able to use the feature.
This can be reverted once we are able to star any file, once tracker has
the required API to star a file and have a sync callback for its result.
Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/338
|
| | |
|
| |
|
|
| |
When displaying an error dialog box, a string that stores the error details, is not being freed. So use g_autofree instead.
|
| |
|
|
|
|
|
|
| |
is_selected is a binary filed of NautilusCanvasIcon (thus its value is
modulo 2), while select is a gboolean, which is a typedef for gint.
We never pass integers to the icon_set_selected call as arguments, so
it's safe to remove these two g_asserts.
|
| |
|
|
| |
(cherry picked from commit 4cfba2912cba0742bb5105681d85a41f8308346a)
|
| | |
|
| |
|
|
| |
(cherry picked from commit 99b4a0d668755fb464ac35937deb9acc58d5ab0b)
|
