| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This patch adds undo tests for the copy operations.
Redo is not included as undo for copy means permanently deleting the
copied files, which renders redoing pointless.
|
|
|
|
|
| |
This patch adds undo and redo testing for each test on the synchronous
move operation.
|
|
|
|
|
|
|
| |
Since most synchronous operations rely on g_task_run_in_thread_sync and
this doesn't reach callbacks, we need to manually set the undo info.
This patch fixes this by moving the callback function content in-line.
|
|
|
|
|
|
| |
- get rid of whitespace between border and the folder.
https://gitlab.gnome.org/GNOME/nautilus/issues/548
|
|
|
|
|
| |
This is a follow-up to commit e9f039e1 which fixes all introduced
criticals and sets the undo information properly.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The view.properties action opens the current directory properties when
the selection is NULL, which we assume to be the case when opening the
background context menu.
Instead of relying on this assumption, make the background context menu
use the view.current-directory-properties action which is used by the
current location menu in the pathbar.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ee75ea771763b4a7fcef5fd61d3c790e688d88e5.
It was pushed too early, caused criticals, and broke keyboard
shortcuts.
There is value in keeping a generic "view.properties" action which
deals with both selection and no selection, because we want the
<Ctrl><i> and <Alt><Return> accelerators to do the right thing in
both cases.
|
|
|
|
|
| |
Without this, the app name comes out as "(Development)Files". No
functional issue, just ugly.
|
|
|
|
|
|
|
| |
This commit builds master Tracker with Meson and removes a redundant
finish argument.
(cherry picked from commit f42bca38528a64d92e4e7f47865bb0a0133580cd)
|
|
|
|
|
| |
Be consistent with buttons and entries and make transition from or to
search entry more seamless.
|
|
|
|
|
|
|
| |
This reverts commit 0453216b8a6731d92cfcd6405c323d76c0c1182c.
Nowadays, the view menu doesn't have a new folder action so this
is not needed anymore.
|
|
|
|
|
|
|
|
|
|
|
| |
The view.properties action opens the current directory properties when
the selection is NULL, which we assume to be the case when opening the
background context menu.
Instead of relying on this assumption, make the background context menu
use the view.current-directory-properties action which is used by the
current location menu in the pathbar. Also, rename view.properties to
view.selection-properties and specialize it.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the past, nautilus_pop_up_context_menu_at_pointer() was the common
path for popping up context menus from the view and pathbar.
However, different paths were introduced in
commit 29cf64bd7632b25dd56a275078da6130b201edeb and
commit 489d4d091e7006f0ec68849e836a52119af88959, which
share some code but couldn't use this API.
Now that the pathbar context menus are gone, this is actually
causing more code duplication while making it harder to read.
Instead, handle everything in files-view.c.
|
| |
|
| |
|
|
|
|
|
|
| |
It breaks proper centering in the header bar.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/554
|
| |
|
|
|
|
| |
And setting can_focus false by default...
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Similar problem to the previous commit.
Ideally, we should simply call it "Computer", since it is the same
location. But we currently lack an effective visual clue that the
admin: backend is in use.
For that reason, label it "Administrator root" istead.
|
|
|
|
|
|
|
|
|
|
|
|
| |
When current location is "/", the pathbar is (icon)(slash)(arrow),
which looks bad because that's 3 symbols in sequence.
Also, the slash ("/") label duplicates the pathbar separator if
current location is a child.
Instead, call it "Computer", which is the label used in Other Locations
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/414
|
|
|
|
|
|
|
| |
It was introduced in 3.14, most probably everyone is in a newer version
already...
Time to clean up!
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
And update to gtk 3.20
|
|
|
|
| |
So we get rid of deprecated properties
|
|
|
|
| |
Not so obvious in Glade.
|
|
|
|
|
|
|
| |
It went worse than I expected, it's a "break me please" setting, which
we are generally against.
It can still be enabled through dconf.
|
| |
|
|
|
|
| |
No need to keep this in the header anymore
|
|
|
|
|
|
|
|
|
|
|
| |
Using GtkRecent items as search engine source in nautilus.
The main reason for this, is being able to get fast results on recently-used
files from the shell search provider.
This is disabled when recursive searches are disabled, as there's no need to go
through for recent files if no recursive (or indexed) search is enabled as the
simple engine will be already fast enough, while running this engine could be
just a waste.
|
|
|
|
|
|
|
|
|
| |
This pins versions of most dependencies, uses quotes for strings and
removes header cleanup from GTK+ module, because CI pipelines choke on
them being absent when ninja decides to rebuild everything when running
tests.
(cherry picked from commit a9f13fc91f7319b318e75a95a89918e9cadf94cf)
|
| |
|
|
|
|
| |
Life's much better now.
|
|
|
|
|
|
|
|
| |
So we allow half sized windows in 1360px screens. This is delicatily
adjusted with the default GNOME set up: Adwaita theme, only close
button as window controls and Cantarell as font.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/425
|
|
|
|
| |
Since we want to replicate inside Nautilus what's in the app menu.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling _set_window_slot() in the window slot weak ref notification
callback isn’t a good idea, given that most of the stuff being cleaned
up there is done automagically, and results in runtime warnings or
potentially a segfault when removing a property binding.
This commit split nautilus_toolbar_set_window_slot(), so that property
bindings aren’t removed if called from the weak reference notification
function. Additionally, the same notification functions nulls out the
icon property binding, fixing the same thing happening in dispose().
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/441
|
|
|
|
| |
The view widget binding is no longer created.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a file view was loaded with a pending selection, and not all the files were
seen yet, the private pending_selection list was properly free'd, but the pointer
was not cleared, causing a crash when `nautilus_files_view_set_selection` was
called again, as it was trying to deeply copy a list pointed by this invalid
reference.
So, removing the unneeded `pending_selection` temporary pointer from the main
function scope, as it only confuses, while use it (with an autolist) when we
need to pass the previous `priv->pending_selection` (stealing its ownership)
to set_selection again.
Eventually use a g_clear_pointer to free the list and nullify its priv reference
Fixes #295
|
| |
|