| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
The updated version of uncrustify doesn't like this style.
|
|
|
|
|
| |
The updated version of uncrustify didn't like this style,
the new style doesn't look great either.
|
|
|
| |
This is what Builder uses.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's been added expecting Builder would support it, such that we could
drop the JSON manifest. 3b8f238624837a8a45cc675a954233cc46b30700
But it didn't happen so far https://gitlab.gnome.org/GNOME/gnome-builder/-/issues/520
Since then we have been maintaining both files in sync, which is a waste
of effort at best, and a risk of the product of each manifest becoming
different, at worst.
Now that the CI uses the JSON manifest, we can just drop the YAML one.
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flatpak jobs are broken currently, because the tracker-miners project
fails to build due to missing upower-glib depenedency. It is used to tweak
the behavior when running on battery. It used to be automatically disabled
until the following MR:
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1121. I suppose
it is safe to disable this functionality as our flatpak isn't meant for
production. Let's explicitely disable that to fix our pipeline.
(cherry picked from commit 1569af12df5694af3eb1e83c8e64b6f360f35520)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The commit e2969a9c29d0d171038fcb35d8baa5a7df372191 introduced an assertion
statement to ensure that the `g_file_get_basename` returned non-NULL string.
Unfortunately, the assertion has an inverted condition. This leads to crashes
in the `get_unique_target_file` function for files that don't have the
`edit-name` attribute set (i.e just a few GVfs backends). Let's fix the
inverted condition.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2825
(cherry picked from commit fcf8f9de8336549f6395c440a9be983849254b31)
|
| |
|
| |
|
|
|
|
|
| |
Fixes CI pipeline failing in stable branch due to meson build options
changes in bleeding edge libportal.
|
|
|
|
|
|
|
| |
Passing an invalid uri to create-folder also crashes nautilus.
If the parent_file is NULL, return an error instead of crashes.
(cherry picked from commit 8f989fa39fd53932597efdf9e728a88b4337fef9)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling g_utf8_validate() on a NULL string crashes Nautilus. This
can occur if performing an operation on an invalid file. If
basename is NULL, there's nothing we would do anyways, so just
return early and prevent the crash.
There's a similar issue with get_unique_target_file(), but
if a bad uri was passed to this function it should fail much
earlier, so lets just add an assertion.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2376
(cherry picked from commit e2969a9c29d0d171038fcb35d8baa5a7df372191)
|
| |
|
|
|
|
|
|
|
|
| |
I screwed up in 8c296a91c8a3e410edcb6471fa713eeaa3133d25 by flipping
the instance and data when disconnecting the signal. Let's just use
g_signal_connect_object to make this automatic.
(cherry picked from commit 7854c9895bfcf4d045444fb3d4862b583032c439)
|
| |
|
|
|
|
| |
g_set_object adds a ref, so don't use it in this case
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The commit 441124c tried to fix the cropped popover on X11 with twice the
height window. This is still not enough with some translations, or when the
larger font is used. Let's resize the window using the preferred popover
size to avoid those issues.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2018
|
|
|
|
|
|
|
|
|
|
| |
eel-debug-shutdown unrefs the trash-monitor but doesn't set it to
NULL. The nautilus_trash_monitor_get () function only creates a
new trash_monitor when the static variable nautilus_trash_monitor
is set to null. Simply set nautilus_trash_montior to NULL after
unreffing.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2064
|
|
|
|
| |
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2364
|
|
|
|
|
|
| |
The gnome-runtime-images have been recently migrated to Quay. This is already reflected in the template.
Please note this MR has been created semi-automatically. If it doesn't make sense, feel free to close it.
|
|
|
|
|
|
|
|
|
|
| |
Opening a new tab from the main view and side bar is set with
NAUTILUS_OPEN_FLAG_DONT_MAKE_ACTIVE. Prior to
022867e3d3370560f2c6c07f90ad5fdfd7916d50 this was the same for tabs opened
from the pathbar. It appears that the change was unintentional
(GTK Open Flags don't have a "don't make active" flag).
Set new tabs as not active from the path bar.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When navigating to Other Locations with "Open in New Tab" or
"Open in New Window", you are always presented with the icon view
because view_mode_before_places was never initialized. An uninitialized
gint == 0 (and NAUTILUS_VIEW_GRID_ID == 0).
Initialize view_mode_before_places in init to NAUTILUS_VIEW_INVALID_ID
so that it will follow the default behavior. For best practices,
change NAUTILUS_VIEW_INVALID_ID to 0 (which would have also prevented
this issue) and NAUTILUS_VIEW_GRID_ID to 2 (matching the keyboard
shortcut).
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2281
|
| |
|
| |
|
| |
|
|
|
| |
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2242
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to rely on gtk_dialog_run(), which would allow us to block the
execution of the current function.
But it's gone in GTK 4, so we've ported to the ::response signal.
8af45e55fcc347b05c4376128df5f248732d07d8
However, a 'goto` which relied on the blocking behavior was kept by oversight,
such that the ::response signal wasn't connected and, as a result, the dialog
didn't close on response.
Close https://gitlab.gnome.org/GNOME/nautilus/-/issues/2265
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes as part of commit 022867e3d3370560f2c6c07f90ad5fdfd7916d50
switched the handler of the pathbar signal.
The new handler raises an exception for NAUTILUS_OPEN_FLAG_NEW_WINDOW.
Use nautilus_application API should be used when handling new windows.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2208
(cherry picked from commit 493deebd50409e869a1a45d745ed46c991e4741f)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Files are flagged as remote in file->details->filesystem_remote
through directory-async as folders are browsed.
nautilus_file_get_filesystem_remote() incorrectly returns FALSE for
child directories that have not been processed by directory-async
on a remote filesystem. This causes the "Count Number of Files in
Folders" options to not work correctly when set to "On This Computer
Only". Rather than unnecessarily process all of the child folders,
check whether filesystem_info_is_up_to_date==TRUE. If not,
check whether the parent is remote instead.
This issue was introduced in 99f55748ef69a68df86b9a039998ee576d59b898.
Previously the prefix of the URI was checked to match a hardcoded list.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2035
(cherry picked from commit 2ab0fcbdad71b6a9ebf94e0f65b1cb53f6219840)
|
| |
|
| |
|
|
|
| |
Better late than never!
|
|
|
|
| |
Fix a mistake.
|
|
|
|
|
|
|
|
|
|
|
|
| |
The master branch introduces incompatible API changes in the
thumbnailing component.
The previously cherry-picked patch has been reverted because
it shouldn't have been applied to the stable branch.
Instead, in order to pass the pipeline, use stable dependency.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2237
|
|
|
| |
This reverts commit fbc9bd6ff4ef32951391d4cdf89c27f58632f492
|
| |
|
|
|
|
| |
GtkArrangement value is text-direction independant, apparently.
|
|
|
|
| |
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2201
|
|
|
|
|
|
| |
See gnome-desktop!132
Backported by António Fernandes <antoniof@gnome.org>
|
| |
|
| |
|