| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
I'm using to test that my re-implementation of NautilusTagManager
works as expected.
It brings in quite a lot of helper code to deal with Tracker and it
depends on the currentrly unmerged [FilesProcessed signal]
(https://gitlab.gnome.org/GNOME/tracker-miners/-/merge_requests/192).
|
|
|
|
|
|
| |
This is needed so that the org.freedesktop.Tracker3.Miner.Files settings
schema is available, and so that the tests that depend on Tracker can
pass as part of the CI build.
|
|
|
|
|
|
| |
This is temporary. Nautilus should use the Tracker portal when it's
ready (see
https://gitlab.gnome.org/GNOME/tracker/-/merge_requests/180).
|
|
|
|
|
| |
Tracker 3 is provded in the Flatpak SDK, see
https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/630.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until now, starred file information was stored in the tracker-miner-fs
database. This has some downsides, firstly the data is deleted if
someone runs `tracker reset --hard`, secondly it isn't possible to
do this from inside a Flatpak sandbox with Tracker 3.0.
This commit changes the NautilusTagManager to set up a private
database inside XDG_DATA_HOME/nautilus/tags. This stores the starred
file information. The database is managed with Tracker, which allows us
to continue using the rename-tracking that tracker-miner-fs provides.
The same limitations apply as before that only files in indexed
locations can be starred.
|
|
|
|
|
| |
In some cases we can TrackerSparqlStatement to avoid building queries
with printf(). This approach is also faster for local connections.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly the port is straightforward, we connect to tracker-miner-fs
explicitly over D-Bus instead of the centralized tracker-store daemon
we connected to previously.
The search-engine-tracker test is now isolated from the user's real
Tracker index using the `tracker-sandbox` script provided by Tracker.
There are more changes in nautilus-tag-manager.c because the
TrackerNotifier API changed, it no longer queries the URIs for
us so we need to query these ourselves, and maintain a table
of ID->URI mappings in addition to the URI->ID mapping that we
already maintained.
|
| |
|
|
|
|
|
| |
Previously the test could appear to succeed even if the search
didn't work as expected.
|
| |
|
|
|
|
|
| |
We were accidentally ignoring the real errors, rather than
ignoring only the cancellation errors.
|
|
|
|
|
|
|
|
| |
Use the tabular numbers (tnum) OpenType feature of PangoAttrFontFeature
to prevent numbers from jumping around as transfer progress changes.
This means that "11" occupies the same space as "44" instead of jumping
around.
|
|
|
|
|
|
|
|
|
|
| |
The flatpak template has been changed recently and MESON_ARGS variable
doesn't have any effect currently. Let's drop MESON_ARGS and move the
build options into the manifests directly (ie. -Dtests=all).
See:
https://gitlab.gnome.org/GNOME/citemplates/blob/master/flatpak/flatpak_ci_initiative.yml
https://mail.gnome.org/archives/desktop-devel-list/2020-April/thread.html
|
|
|
|
|
|
|
|
|
| |
It is required that select-all action (application wide) is disabled
while directory is loading because otherwise inappropriate selection
might happen.
Luckily, we can connect to the signal binding and stop its emission
on the instance.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the current state, it is possible to perform selection
while the directory is loading which in some cases, may not
select all the items.
Performing select-all only selects the items that are loaded,
till the point of performing the action.
Since the loading state is already maintained, we can put a
check for an on-going directory load while updating actions state.
Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1389
|
|
|
|
|
|
| |
When a new file is created, add it to the Recent files store.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1357
|
| |
|
|
|
|
|
| |
Issue templates are exposed to all users as a way to help them communicate their issues more effectively.
Epics were meant to be written by the project's contributors, so having a template for Epics serves only as a distraction.
|
| |
|
|
|
|
|
| |
This has already been fixed in 7f19a036491cb27579daa674aaf7f5353d910709
and later improved in https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/440
|
|
|
|
|
| |
As of commit 70393e321 (general: Allow to compile on Wayland-only
system) libX11 is no longer a dependency
|
| |
|
|
|
|
| |
(cherry picked from commit ad72ed31e62443b248da3fca2ab48a7eb6ccec0e)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a user opens a file of a type that no installed application can open
a dialog pops up with the option to search for a suitable application
in GNOME Software.
When the user clicks the "Search in Software" button an extra notification
pops up asking to confirm searching for the app which is unnecessary and
potentialy confusing.
The fix consists of migrating to the new org.freedesktop.PackageKit.Modify2
D-Bus API that handles this use-case without a second user prompt.
Closes #1299
|
| |
|
| |
|
|
|
|
|
| |
I made .1 release by mistake before some time. Let's make .1.1 release
now to be still in sync with the GNOME release schedule.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we change location while the view is still scrolling due to
kinetic deceleration, we get a sudden jump to the same scrolling
position as the previous location, as well as residual scrolling
movement in the new location.
This is both undesirable and unexpected from a user POV.
Workaround that by canceling deceleration when switching locations.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1452
|
| |
|
|
|
|
| |
(cherry picked from commit a87205dcb45707d78ebf487c54d2174ef0ffc7f7)
|
|
|
|
|
|
|
| |
Currently, the nightly job is skipped if fedora rawhide, or flatpak
master job fails. This is not wanted as the nightly should be published
if flatpak devel job succeeds. Let's allow failures of those jobs to
not block the deploy stage.
|
|
|
|
|
|
| |
The update image job is always shown (under the GNOME namespace),
however, fedora rawhide job is used only on master/web. So let's show
this job only on master/web as well.
|
|
|
|
|
|
|
|
| |
The fedora job is run only on schedules and tags. The job is pretty
fast now. So let's run it always on master so we know about possible
breakages immediately and not after several days.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1441
|
|
|
|
| |
(cherry picked from commit 1104e9bd17a04f26b15483c12c4397ea0926139c)
|
|
|
|
| |
(cherry picked from commit 503946a20bb3862e0c6886bc38b4a56c9621f8bf)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on patches from Felipe Borges for other apps. Quoting him:
The GNOME Shell search results are forwarded from the results of
GLib's g_desktop_app_info_search() function, which matches the
Name, Exec, Keywords, GenericName, X_GNOME_FullName, and Comment
keys from desktop files[0].
Since Totem is now named "Videos", a query for "totem" would
match the "Exec" key and present the application in the search
results as expected. Unfortunately that doesn't happen for Flaptaked
Totem, which would get its desktop file "Exec" key overwritten to
something such as Exec=/usr/bin/flatpak run --branch=stable
--arch=x86_64 --command=totem org.gnome.Totem --new-document
This way, searching for "totem" when only the Flatpaked version
of it is installed returns no results. Searching for "Videos"
presents the application as expected.
Its been proposed in GLib to parse the "Exec" key for searches
but that was rejected[1] because it would imply establishing an
API which assumes that the command line behavior of Flatpak would
be stable/never-change.
A fix was proposed in Flatpak directly[2] but it was rejected,
leaving us with the only option of adding the historical/legacy
application names to the "Keywords" key in their desktop files.
Many users, such as myself, have the "muscle memory" of search
for the old application's name, such as "totem", "gedit", "evince".
Although I agree that the new names should be presented to new
users and that the old ones shouldn't be visible in UI, it makes
sense and little effort to support the search for the old names IMO.
[0] https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gdesktopappinfo.c#L378
[1] glib#1706
[2] https://github.com/flatpak/flatpak/issues/2749
|
| |
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/504
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/504
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/504
|
|
|
|
|
|
|
| |
Add DeleteURIs method to make it possible to permanently delete
files avoiding trash.
https://gitlab.gnome.org/GNOME/nautilus/merge_requests/504
|
|
|
|
|
|
|
|
|
|
| |
Add new version of FileOperations interface. This versions adds
PlatformData argument to all methods. Currently supported arguments
are parent-handle and timestamp.
This change is necessary for proper focus handling.
https://gitlab.gnome.org/GNOME/nautilus/merge_requests/504
|
| |
|
|
|
|
|
|
|
| |
This reverts commit e7c2a0182a4ba2d6eb05fe170cc9b4d018a70feb, because
the stage name doesn't have to be explicitely defined currently as it
was changed directly in the template:
https://gitlab.gnome.org/GNOME/citemplates/-/commit/5bffac6dfbd797291a90e705925a7a3973e4cc57
|
|
|
|
|
|
|
|
| |
Fedora and style check jobs install dependencies on each run. This
causes that the pipelines take a long time. Let's use a custom docker
image to not block runners for such a long time and to get the pipeline
results faster. This commit also adds a new job to generate the docker
image for us.
|
|
|
|
|
| |
It is not easy to find out why the style check job failed. Let's expose
the style check job diff over artifacts to make it easier.
|