| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
The definitions have been removed long ago. [1]
[1] 37be3809bc0d25d28298b38bc0b893a6fd3a665f
|
|
|
|
| |
Leftover from d5a9299fc58e646bfbdb8ede8eabb0b9e786eb5e
|
|
|
|
|
|
|
|
|
|
|
| |
Exchange the adjustable GtkPaned widget for AdwFlap. We lose a
resizable sidebar, but gain an adaptive one. For windows narrower
than 600px, we fold the sidebar.
The loss of the resizable sidebar means that all settings related
to it are removed.
Fixes #2156
|
|
|
|
|
|
| |
Always show the sidebar, and remove the setting to hide it.
We are going to introduce a replacement next commit: AdwFlap.
|
|
|
|
|
| |
Get rid of the middleman; Use `g_type_ensure()` to
initialize the type.
|
|
|
|
|
| |
This style class is deprecated. See
https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#sidebar
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
They were introduced to ensure compatibility in 0e5815e95ae2f071be73b75b57925aceb23f503a
Now that we have broken the API, it's time to drop them.
|
|
|
|
|
|
|
| |
Now that we have broken the API, remove compatibility typedefs
introduced in 7e2605c681d065e6b0a3d779c30b892932597991
Also update audio-video-properies to use the new symbols.
|
|
|
|
| |
Deprecated since commit 7e2605c681d065e6b0a3d779c30b892932597991
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The GTK3 to GTK4 switch requires extensions to port their widgets too,
because 2 versions of GTK cannot be loaded in the same program.
Therefore, this is effectively an API break. We must update the
library version.
Also, we are going to introduce breaking more changes before the API
freeze.
Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2135
|
|
|
|
|
| |
Use GDK_ACTION_ALL instead of `GDK_ACTION_MOVE | GDK_ACTION_COPY |
GDK_ACTION_LINK`
|
|
|
|
|
|
| |
We had the hotspot coordinates set to 0,0 because it's not working
on wayland, but it does work for x11. Set the coordinates to
x,y to fix x11 (wayland remains unchanged).
|
|
|
|
|
|
|
|
|
| |
We are arbitrarily allowing all actions on the list-base DragSource.
The GDK_ACTION_MOVE should only be allowed if we can delete the file.
While iterating through the NautilusFile selection list, check
if any of the files cannot be deleted, and if so don't allow
GDK_ACTION_MOVE
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The begin_loading() function in list-base calculates the preferred
action for the view every time even in a current drop isn't occuring.
This is wasteful.
Check if the current drop is not NULL before calculating the
preferred aciton.
|
|
|
|
|
|
|
| |
This reverts commit ec9a7beceee648cd14fb0bf7cff27fc478caff6d.
We are going back to the previous solution, but making it less wasteful in
the next commit.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "change location on hover" feature should work on any location
you can open, but it currently only works for valid drop targets.
Move the timer to the beginning of the motion handler so the
hover timer begins for locations that aren't valid drop targets.
This may cause hover_timer to receive a NULL row or a row
that doesn't have a valid uri so check for both of those
conditions in hover_timer().
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1787
|
|
|
|
| |
Their purpose is now handled by `nautilus_dnd_get_prefered_action()`.
|
| |
|
| |
|
|
|
|
|
|
| |
GDK_ACTION_LINK is already supported and implemented on the sidebar,
tabs, and pathbar. Add GDK_ACTION_LINK to the view drop targets
in list-base. This only works in x11, not wayland.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Now that gtk4 code is in place, enable build of audio-video-properties
again. Previously disabled in 9f8d4c9e111b972acedf1dfbdd83fcb3ca20e027
However, we must still disable tests for the time being, until we port
them away from gtk_main(), together with other tests already disabled
due to gtk4 by commit 388b2cbb09a2d19eb1b948c435d8bc7cb111149d
|
|
|
|
|
|
| |
Use new functions and syntax. Minor code cleanup in order to
make debugging easier. GTK4 doesn't use border width, use margins
consistent with main properties page.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The calendar picker for search stopped working with
7063e201d43da373836cef67ee354d0e83ce3153
which removed the day_selected signal
In GTK4 the signal was renamed from day_selected to day-selected.
Reconnected the day-selected signal to calendar_day_selected
handler.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2304
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2047
|
|
|
|
|
| |
We didn't crash because G_VALUE_HOLDS() includes a check for NULL. But
it still issues a warning because we shouldn't pass it a NULL value.
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e39102ede3e4cf4c9c3a8bc28e268cae6f340838.
Stop holding a GtkDropTarget in priv and unnecessarily loading the
preferred action every time in begin_loading() (even if we aren't
in a drag). In begin_loading() flag the drag_view_action as
invalid and recalculate the preferred action in on_drag_view_motion()
when drag_view_action_invalidated is TRUE;
|
|
|
|
|
|
|
|
| |
c21904c53fc7ce53d3ecc3b9cb6a500f506ca6db introduced
on_view_drag_value_notify() and on_item_drag_value_notify()
which both update drag_item_action.
Make on_view_drag_value_notify() update drag_view_action
|
| |
|
|
|
|
|
|
| |
Get closer to mockups by not showing a separator before the menu button.
Instead, a border is added only upon scroll underflow.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to automatically set the scrolling position to the end, in order
to reveal the current folder when:
1. the path changes.
2. the window is resized.
However, this is not working as expected in the first case, maybe
because we need to wait until the next main context iteration.
Fix it by adding a scrolling animation.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to display emblems overlaid on icons. This had a few problems:
* Emblemed icons were not cached.
* If the icon was too small, some emblems could be omitted.
* Emblems would partially obstruct the visibility of thumbnails.
So, we are reintroducing them as a mere box of icons:
* vertically next to the file icon/thumbnail in grid view;
* horizontally next to the filename in list view.
This avoids all the problems of the old implementation.
Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2017
|
|
|
|
|
|
|
| |
We have been setting this margin in code depending on icon size.
But we are going to need this margin in all sizes in order to
have space for emblems.
|
|
|
|
|
| |
Emblemed icons are not implemented in GTK 4 and we don't want to
reimplement them here anyway, so let's drop this code.
|
|
|
|
|
| |
There is no need to restore emblem functionlity here, because a warning
icon works just fine. Let's cleanup.
|
| |
|
|
|
|
|
|
|
| |
Hovering on a tab would result in no available drop and logging
"NAUITLUS_IS_FILE FAILED" because the drag_info->target_file
is not set for tabs. Use the existing NautilusFile that is already
retrieved for tabs and pathbar.
|
|
|
|
|
|
|
|
|
|
| |
We've been setting the view drop action from the item drop action.
This assumes the location was switched by hovering a view item.
However, the view may get switched by hovering the pathbar or the
sidebar, where this assumption doesn't hold.
So, we must properly recompute the preferred action.
|
|
|
|
|
|
|
|
| |
If the drag_view_action is 0, gtk_drop_target_reject() is called
thereby not allowing a drag to occur when the directory is changed
via hover. Don't call gtk_drop_target_reject() on the view itself.
Instead, return FALSE on ::drop.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the sidebar is back under control of Nautilus, we
can handle hovering similar to how it's handled in the view.
While dragging across the sidebar, set a timeout when hovering over
a new row that accepts drops and is not the placeholder row
for new bookmarks. Use the existing preference
NAUTILUS_PREFERENCES_OPEN_FOLDER_ON_DND_HOVER
to determine if folders should be opened on hover.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2056
|
|
|
|
|
|
|
|
|
|
|
| |
The gtk sidebar code currently only allows G_FILE_TYPE_DIRECTORY,
G_FILE_TYPE_SHORTCUT, and G_FILE_TYPE_MOUNTABLE as acceptable drops
to create a new bookmark. Control+D successfully creates a bookmark
for a sym link because it uses nautilus code. Since sym links are
acceptable bookmarks, allow G_FILE_TYPE_SYMBOLIC_LINK as an allowed
drop for bookmarks.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1665
|
|
|
|
|
|
|
| |
Now that we have a nautilus file cached for sidebar items,
use that instead of getting a nautilus file from URI.
This resolves an issue where properties doesn't show volume
information unless the volume was previously browsed.
|