summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* take_3wip/antoniof/completion-priority-highAntónio Fernandes2022-12-251-5/+10
|
* take_2António Fernandes2022-12-251-7/+1
|
* location-entry: Increase the priority of idle completion António Fernandes2022-12-201-1/+2
| | | For testing whether it improves the situation in https://gitlab.gnome.org/GNOME/nautilus/-/issues/2673
* window-slot: Handle archive URI as regular file if not the default handler António Fernandes2022-12-201-1/+1
| | | | | | | | | | | | | When nautilus is asked to handle a regular file (e.g. its URI being passed as command line argument), we open its parent folder and select the file. But for archives, we want to extract them immediately instead (this is convenient when e.g. handling opening a downloaded file from the web browser). However, we don't actually extract the archive unless we support are the default handler for that MIME type, in which case we don't select it as a regular fiel either, which is inconsistent. So, make sure we only handle archives specially if we actually meant to extract them. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2274
* Update Russian translationAleksandr Melman2022-12-201-103/+109
|
* list-base: Don't change location in a dnd when hovering over itselfCorey Berla2022-12-201-0/+7
| | | | | | | | | | | | It doesn't make sense to change locations onto the same folder you are dragging from. The easiest way to tell if we are dragging onto the source drag is when the drag_item_action is set to 0. This has the added benefit that drag_item_action is also set to 0 when hover over a file. We have been calling `nautilus_files_view_handle_hover()` unnecessarily on file destination (which ultimately had no effect). Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2670
* dnd: Don't allow dropping an archive on itselfCorey Berla2022-12-201-25/+20
| | | | | | | | | | | | | In `nautilus_dnd_get_preferred_action()` we check if the dropped file and target file are equal, but only after the check if we are dropping onto an archive. The `g_file_equal()` check if wrapped in a `dropped != NULL` check which turns out to be unnecessary because we return in the very beginning when `dropped == NULL` Move around the drop target action checks to simplify and prevent dropping anything on itself. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2737
* list-base: Don't modify selection model's internal bitsetCorey Berla2022-12-201-6/+9
| | | | | | | | | | | | | | | In real_set_selection, we call gtk_selection_model_get_selection() to be able to efficiently update the selection (we don't care about unselected items that we aren't going to select). That bitset, per the documentation, shouldn't be modified. This bug (which made this function effective useless) went unnoticed because we were setting the selection elsewhere by poking the internals of the listbase in set_focus_item. We don't want to do that anymore, and this bug became apparent. Make a copy of the bitset, and rename the existing bitsets to clarify what we are doing. Also, set the selection after setting the focus just in case that ever conflicts in the future.
* files-view: Remove unused variableCorey Berla2022-12-201-4/+0
|
* autorun-software: Initiate libadwaitaAntónio Fernandes2022-12-191-0/+1
| | | | | | | | When moving away from GtkMessageDialog, we forgot this small program is not part of the main application. [0] Therefore, we need to initiate libadwaita here, before using any of its widgets. [0] a80aacdf2c44fd9c28a292ee599b9e74418faa10
* autorun-software: Keep running until responseAntónio Fernandes2022-12-191-0/+5
| | | | | | | | | | | | When moving away from gtk_dialog_run() [0], we forgot this small program is not part of the main application. So, without anything blocking the `main()` function, it's going to quit right away, without ever drawing the dialog. Credit goes to Will Thompson for diagnosing the issue, and GTK test suit for the while loop solution I've taken from there. Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2209 [0] d87f5be77bb4ee03e363cb560aaefb00cf56b275
* autorun: Do not require autorun.sh to be +xWill Thompson2022-12-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since 8978c6375bbe0cd26fffded25bc4606cab2c88e6, `autorun.sh` (but not `.autorun` or `autorun`) has been run via `/bin/sh`, not executed directly. The justification in that commit was as follows > nautilus-autorun-software: Use /bin/sh for autorun.sh execution > > If the autorun file is called autorun.sh it is clearly meant for > execution through a sh processor. The benefit of using /bin/sh as the > executable is that autorun will also work on FAT formatted media (which > does not allow autorun.sh to have +x permission set) However that patch was incomplete. The third argument to _check_file() is 'must_be_executable'; if set, _check_file() will return FALSE when the file does not have the executable bit set. It is possible to mount FAT media in such a way that regular files get the execute bit, but this is not the default. As a result, if you place `autorun.sh` in the root directry of a FAT device, Nautilus offers to run it, but w hen you take it up on that offer it fails, claiming: > Unable to locate the program Complete the special handling of the autorun.sh name by not requiring it to be executable. See https://gitlab.gnome.org/GNOME/nautilus/-/issues/2675
* general: Replace GtkStyleContext with GtkWidget functionsCorey Berla2022-12-1912-61/+27
| | | | | | | GtkStyleContext is deprecated in 4.10, use the corresponding GtkWidget functions. Also bump GTK version to use the new gtk_widget_get_color().
* doap: Update mailing-listCorey Berla2022-12-181-1/+1
| | | | mailman has been moved to discourse.
* README: Add link to proper commit message formatCorey Berla2022-12-181-0/+2
|
* preferences: Remove unused start-with-location-barCorey Berla2022-12-161-5/+0
| | | | This was removed over 11 years ago in 7363013201ec2950958db529ea96c0f2442b3c53
* help-overlay: Remove redundant "visible" propertySabri Ünal2022-12-151-61/+0
| | | | | | | Widgets are visible by default on GTK4. Remove visible property when setting to TRUE. Source: https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkwidget.c#L1275
* list-base: Fix non-local DnD in x11Corey Berla2022-12-151-2/+2
| | | | | | | | We are using a workaround to get the preferred action in x11 where we check the preferred action of the drag. This works for local drags, but obviously not non-local drags. The workaround is necessary because of a bug in gtk. Let's just default back to COPY for non-local drags.
* window: Disconnect NautilusBookmarkList "changed" signal on window destructionCorey Berla2022-12-151-3/+4
| | | | | | Use g_signal_connect_object to automatically disconnect the signal Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2548
* query-editor: Add placeholder textsunflowerskater2022-12-151-0/+1
| | | | | | | | | The search bar from the main window doesn't have a placeholder, which the HIG generally requires. Add the necessary placeholder. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2698
* list-base: Clear hover timeout on dropCorey Berla2022-12-151-0/+4
| | | | | | | | In a wayland session, leave is emitted on a drop or cancelled drop. In x11 that's not the case. Explicitly clear the hover timeout on drop. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2585
* Update Hebrew translationYosef Or Boczko2022-12-151-240/+246
|
* Update Turkish translationEmin Tufan Çetin2022-12-141-98/+104
|
* file-utilities: Remove unused functionBenjamin Otte2022-12-132-22/+0
| | | | | | | | | In gtk3 Nautilus used to construct the uri-list. nautilus_uri_to_native_uri() was used to ensure that apps that didn't have gvfs access could access the dropped file. Now gtk4 constructs the uri-list, so a similar process is handled on the gtk side. Related: #2632
* file: Remove unused got_custom_activation_uriBenjamin Otte2022-12-132-7/+4
| | | | The last user was NautilusLink, and that's been gone for a while.
* Update Belarusian translationVasil Pupkin2022-12-131-3627/+2027
|
* Update Interlingue translationOlga Smirnova2022-12-131-1515/+886
| | | | (cherry picked from commit 61530d7cc21f86420ede29d540b442f88da83725)
* error-reporting: Pass parent window to show_dialog()Corey Berla2022-12-101-1/+4
| | | | | | | | | | | | For a very long time, we've been passing NULL as the parent window to show_dialog() for failed rename operations. This is in a deeply nested callback, so rather than trying to pass the window all the way back just get the current active window, which very likely is the correct window given how quickly this operation will fail. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1199
* flatpak: Fix build after options changes in libportalBastien Nocera2022-12-102-2/+6
| | | | See https://github.com/flatpak/libportal/pull/104
* Add Interlingue translationOlga Smirnova2022-12-092-0/+6022
| | | | (cherry picked from commit 365411e0430b75aa4d37a98d1306df7cb3f22a12)
* properties-window: Capitalize multi-byte characters correctlyAleksandar Dezelin2022-12-042-11/+16
| | | | | | | | | | | | | | Pango library doesn't support specifying text-transform in utf8 codepoints. It instead uses positions in the raw string. This is why we have problems with, for example, the Cyrillic label in the UI file text_transform positions are specified as 0 for the start and 1 for the end and the first Cyrillic letter consist of two bytes. Remove attributes from the UI file and implement label text capitalization using the function eel_str_capitalize() which does the same but in a proper way for type_value_label and type_file_system_label. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2494
* Revert "Incorrect � letter shown for file type name in Japanese and ↵António Fernandes2022-12-042-16/+11
| | | | | | | | Cyrillic languages" This reverts commit 91f7fb675e558fb0b2c3dc5a6082386b0aef159a. The commit message was broken, missing context.
* Incorrect � letter shown for file type name in Japanese and Cyrillic languagesAleksandar Dezelin2022-12-042-11/+16
|
* properties-window: Also free list of usersAntónio Fernandes2022-12-041-0/+1
| | | | To avoid leak.
* window-slot: Make ownership transfer of pending location explicitAntónio Fernandes2022-12-041-4/+1
|
* properties-window: Fix leakIgnacy Kuchciński2022-12-041-0/+2
|
* window-slot: Unref new locationIgnacy Kuchciński2022-12-041-0/+2
| | | | | | We increase its reference count again in nautilus_window_slot_set_location (), so unref it afterwards to prevent a leak going back all the way to nautilus_application_activate ()
* window-slot: Fix leakIgnacy Kuchciński2022-12-041-3/+4
| | | | | | | | | | | Currently, if the new_selection list is NULL, then the check_select_old_location_containing_folder function sets it to a newly allocated list. Since we don't own the new_selection list, let's copy it before passing it to the check_select_old_location_containing_folder function so that it always returns a newly allocated list, which we make the pending_selection point to in order to avoid a leak.
* list-view: Fix leak and use macrosIgnacy Kuchciński2022-12-041-1/+1
|
* window-slow: Actually search in window_slot_searchCorey Berla2022-12-031-0/+1
| | | | | | | We are setting the query editor text, but not actually starting the search. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2518
* query-editor: Set position at the end of the textCorey Berla2022-12-031-0/+1
| | | | | | If we are updating the query editor's text (i.e. through the shell search provider), we should move the cursor position to the end of the text, otherwise it's at the beginning of the text.
* query-editor: Drop unused codeCorey Berla2022-12-032-23/+0
|
* Update Swedish translationAnders Jonsson2022-12-021-190/+205
|
* Update Icelandic translationSveinn í Felli2022-11-301-1669/+2046
| | | | (cherry picked from commit b89017dd1a8391cbea81e405abb094ef02046aa5)
* application: Remove excessive show-help-overlay actionSabri Ünal2022-11-292-13/+1
| | | | | | | | | We don't need an extra action to show help-overlay. It already managed by GTK. Source: https://docs.gtk.org/gtk4/class.Application.html#automatic-resources Topic: https://discourse.gnome.org/t/nautilus-unnecessary-action-to-show-help-overlay/12516
* Update Russian translationAleksandr Melman2022-11-281-141/+141
|
* general: Add trailing ellipsis to Empty TrashGotam Gorabh2022-11-263-4/+4
| | | | | | | | | Add trailing ellipsis at the end of Empty Trash to fulfill GNOME Human Interface Guidelines. Trailing ellipsis is used when further input or confirmation is required from the user before the action can be carried out. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2502
* files-view: Remove trailing ellipsis from "Visible Columns"Gotam Gorabh2022-11-261-1/+1
| | | | | | | | | Remove the trailing ellipsis from Visible Columns to fulfill the GNOME Human Interface Guidelines. Trailing ellipsis is used when further input or confirmation is required from the user before the action can be carried out. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2534
* about: Add support-urlHari Rana2022-11-241-0/+1
| | | | This adds a support URL to the Nautilus forums for easier access to ask questions
* Update Turkish translationSabri Ünal2022-11-231-168/+185
|
View Lorry Controller Status