summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* properties-window: Add created row to the basic pagewip/antoniof/creation-time-attrApoorv Sachan2020-12-232-10/+60
| | | | | | | | The NautilusFile backend now supports birth-time parameter. It is now leveraged to display the date-created for a file in properties dialogue. Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1566
* column-utilities: Add Created date columnAntónio Fernandes2020-12-222-1/+11
| | | | | | | Now that we have backend support for showing and sorting by btime, add an optional "Created" column to the list view. This enables using the attribute as caption for icon view too.
* general: Support sorting by creation dateAntónio Fernandes2020-12-226-2/+48
| | | | No user visible changes yet.
* file: Add "date_created" attributeAntónio Fernandes2020-12-224-3/+59
| | | | | | | | | GIO 2.66 introduces support for Linux statx stx_btime.[0] First, let's add support for this attribute in our file models. No user-visible changes yet. [0] https://gitlab.gnome.org/GNOME/glib/-/commit/a396fa9027bf9aaab0697789fe38efec53b09431
* properties-window: Use g_clear_*()António Fernandes2020-12-221-43/+13
| | | | They cut on boilerplate and improve readability.
* properties-window: Use modern GList code patternsAntónio Fernandes2020-12-221-102/+47
| | | | | | | | | - Use GList API instead of reimplementing it: - g_list_copy_deep() - g_list_foreach() - g_list_delete_link() - NULL-initialize fully-owned lists. - Don't reimplement nautilus_mime_get_default_application_for_file()
* properties-window: Stop multi-file GAppInfo leakAntónio Fernandes2020-12-221-2/+4
| | | | | | | | | | | | When showing the properties for multiple files with the same MIME type, The app_info variable is reassigned multiple times in a for loop to the return value of nautilus_mime_get_default_application_for_file(), which returns a caller-owned refference. So, we leak a reference on each reassignment. To fix this, declare the variable inside the loop block, to ensure autocleanup after each loop iteration.
* properties-window: Use autocleanup variables moreAntónio Fernandes2020-12-221-123/+68
| | | | | | | Also fixes a few leaks: *uri in setup_volume_usage_widget() *error in set_as_default_clicked_cb() *message in set_as_default_clicked_cb()
* properties-window: Use autocleanup variablesApoorv Sachan2020-12-221-139/+62
| | | | Use modern GLib utilities for memory management.
* properties-window: Set boolean object data correctlyAntónio Fernandes2020-12-221-2/+2
| | | | | | | | | | It's wrong to set a pointer to an object as data without incrementing its refcount. But there is actually no need to pass a real pointer as data here, as we actually want a boolean. Use a pointer conversion macros instead.
* properties-window: Instance symbol renamingApoorv Sachan2020-12-221-716/+716
| | | | | Use "self" as symbol name for the NautilusPropertiesWindow* instance in methods and signal handlers.
* properties-window: Removed unused macrosApoorv Sachan2020-12-221-2/+0
| | | | | | ROW_PAD was a macro used by code the UI creation code which has been removed in previous commits. Now It's not useful.
* global-preferences: Drop unused tracker settingsAntónio Fernandes2020-12-223-7/+0
| | | | Unused since commit bd30a21a0ce1b40ca59814f731bd761670601aaa
* Revert "search: Remove special characters from FTS searches"António Fernandes2020-12-221-29/+1
| | | | | | | This reverts commit e3031953e40b4fe067d566ac6c403127d7b6c266 It worked around an issue in tracker, which is fixed now: https://gitlab.gnome.org/GNOME/tracker/-/issues/252
* tag-manager: Inline previously shared codeAntónio Fernandes2020-12-221-44/+9
| | | | | | get_query_status() is a wrapper for tracker_sparql_cursor_next_finish() and it's weird for _finish() not to be called directly by the GAsyncReadyCallback function.
* tracker-utilities: Update copyrightsam/copyrightSam Thursfield2020-12-211-0/+1
| | | | See https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/553#note_989920
* gtkplacesview: Update to latest codewip/oholy/pathbar-default-locatonOndrej Holy2020-12-191-1/+15
| | | | Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/1319
* file-utilities: Do not use default location instead of rootOndrej Holy2020-12-191-10/+0
| | | | | | | | | | | The default location (i.e. g_mount_get_default_location) should be used when opening mounted, but we should not use it instead of the root button in the path bar. Because it is currently impossible to navigate to parent folders if default location is set. Let's change nautilus_get_mounted_mount_for_root logic and return mount only for root path so we can see the real root in the path bar. https://gitlab.gnome.org/GNOME/nautilus/issues/1319
* Update Bengali (India) translationAkarshan Biswas2020-12-181-4039/+5914
| | | | (cherry picked from commit 8e67058fb368146183f0159292fa5ab483d9c4e9)
* window: Refactor nautilus_window_save_geometryElias Projahn2020-12-171-25/+32
| | | | | Replace a guard check if/else statement with an early return and minimize unnecessary function calls.
* window: Don't save state when tiledElias Projahn2020-12-171-2/+13
| | | | | | | | | | The saved window state (whether the window is maximized and its initial size) should be the state, that the user would most likely want the next opened window to start with. As the tiled state doesn't make sense without other windows and because it's not really possible to properly restore it, it will not be saved anymore. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1685
* files-view: Use fallback in case of xdp_portal_set_wallpaper failurewip/oholy/libportal-warningOndrej Holy2020-12-171-1/+20
| | | | | | | | | Since commit ece6b825, xdg-desktop-portal is used to set wallpapers. This introduced the following build warning: "‘set_wallpaper_fallback’ defined but not used", because the fallback is used only if it is built without libportal support and it is not guraded by #ifdef. Let's use the fallback also in the case of xdp_portal_set_wallpaper portal failure, which fixes the warning as well.
* Revert "ci: Use Fedora latest instead of rawhide temporarily"Bastien Nocera2020-12-112-2/+2
| | | | | | | GNOME CI runners have been updated to the latest libseccomp so the problem should no longer happen. This reverts commit ab55380f200e5ea03116c5871607d125deff844c.
* Update Norwegian Bokmål translationKjartan Maraas2020-11-301-988/+1032
| | | | (cherry picked from commit b62f9a7422edd181c92ef0d0ccce7b8d91860497)
* ci: Use Fedora latest instead of rawhide temporarilywip/oholy/ci-buildahOndrej Holy2020-11-202-2/+2
| | | | | | | | The pipeline currently fails with Fedora rawhide, because g-ir-scanner fails with failures like: "ldd: error: you do not have read permission for `/builds/GNOME/nautilus/_build/tmp-introspectgwhh729q/Nautilus-3.0'". This obviously affects more projects:, e.g. GNOME/grilo!62. Let's use Fedora latest for now as a workaround.
* ci: Remove broken triage jobOndrej Holy2020-11-202-163/+0
| | | | | | | | | The triage job is broken, which regularly causes CI failures. I've made some attemts to fix it but I failed. I don't have capacity to spent more time on it. Let's remove the job completely for now to prevent the confusing CI failures. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1625
* ci: Use Tracker 3 dependencies from Fedora repositoryOndrej Holy2020-11-201-4/+1
| | | | | The Tracker 3 dependencies are installed currently from unofficial COPR repository. Let's use the official Fedora packages instead.
* ci: Use Buildah instead of Docker to generate imagesOndrej Holy2020-11-201-11/+14
| | | | | | The GNOME runners are no more privileged and thus it is not possible to use Docker from the pipeline. Let's use Buildah instead Docker to fix the image generation.
* tag-manager: Search for tracker3 in PATHAntoine Jacoutot2020-11-191-1/+1
| | | | | | | | | | Tracker 3 migration code tries to spawn tracker3 binary using G_SPAWN_SEARCH_PATH_FROM_ENVP flag. However, tracker3 is installed under /usr/local/bin/ on OpenBSD which isn't searched by envp. So the migration fails with the following warnings: "Tracker 2 migration: Couldn't run `tracker3`: Failed to execute child process "tracker3" (No such file or directory)." Let's use G_SPAWN_SEARCH_PATH instead of G_SPAWN_SEARCH_PATH_FROM_ENVP to fix this issue.
* ci: Add libportal-devel to DockerfileFelipe Borges2020-11-181-1/+1
| | | | https://src.fedoraproject.org/rpms/libportal
* files-view: Use xdg-desktop-portal for setting WallpaperFelipe Borges2020-11-181-24/+80
| | | | | | | | If libportal was found during build, we can use libportal to set the Wallpaper. Otherwise, we fallback to the old Nautilus behavior of directly copying the image and updating the gsetting. Fixes #795
* build, flatpak: Add libportal dependencyFelipe Borges2020-11-186-0/+45
| | | | Fixes #795
* image properties: Handle rotated imagesJames Westman2020-11-181-4/+23
| | | | | | | | Images with EXIF metadata can contain an orientation tag, which indicates the image should be rotated. In the Image tab of the Properties dialog, swap the width and height if the image is rotated by 90 or 270 degrees. Fixes #1590.
* Revert "ci: Hardcode image version for style check job"António Fernandes2020-11-181-1/+1
| | | | | | This reverts commit 831203e9512b29900e8095c91332b49bbbf97047. The previous commit fixed the issue we were working around.
* canvas-dnd: Define function type the usual wayAntónio Fernandes2020-11-181-2/+5
| | | | | | | | | | | | | Defining an function type inline as a function parameter is a awkward syntax and not used in our codebase except for this one occurence. Although valid C, it confuses our style check tools, breaking the CI style check [1] and failing to align parameters. Instead, let's define a named function type to use as parameter type, and fix parameter misalignment. [1] 831203e9512b29900e8095c91332b49bbbf97047
* batch-rename-utilities: Fix dialog crashesOndrej Holy2020-11-181-1/+0
| | | | | | | | | | | The batch rename dialog crashes when it is opened for a second time. This is because the TrackerSparqlConnection object is unreffed after the first use. However, nautilus_tracker_get_miner_fs_connection documentation clearly says that the returned should not be unreffed because it is globally shared singleton. Let's remove the problematic g_object_unref statement to fix the crashes. https://gitlab.gnome.org/GNOME/nautilus/-/issues/1651
* Update Turkish translationEmin Tufan Çetin2020-11-111-109/+109
|
* properties-window.ui: Set "use_underline" propertyBryan P2020-11-011-0/+1
| | | | | | | To correctly setup the mnemonic character following an underscore in a checkbox label. Closes #1630
* list-view: Fix double-click row check for gestureAntónio Fernandes2020-10-272-15/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before porting to a GtkMultiPressGesture [1], for every double click, we would get 2 events of type GDK_BUTTON_PRESS for each click and 1 event of type GDK_2BUTTON_PRESS after the second click [2]: 1st click: GDK_BUTTON_PRESS 2nd click: GDK_BUTTON_PRESS, followed by GDK_2BUTTON_PRESS So, in order to ensure the double click happened within the same list row, we used to save the clicked path for each GDK_BUTTON_PRESS event and compare the last two saved paths during the GDK_2BUTTON_PRESS one. However, now we only get a GtkMultiPressGEsture::pressed signal twice: 1st click: ::pressed is emited with n_press = 1 2st click: ::pressed is emited with n_press = 2 Yet, we are still saving the clicked path only when n_press = 1, so, unless the user had already clicked this row before doing a double click, the saved paths don't match and we ignore the double click. Instead, it's enough to save the row path for the 1st click, as we can compare it directly with row path on the 2nd click. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1599 [1] 13a8d3efacbe160d2cc9158ec707ab99013d7f87 [2] https://developer.gnome.org/gdk3/stable/gdk3-Events.html#GDK-2BUTTON-PRESS:CAPS
* Update Portuguese translationJuliano de Souza Camargo2020-10-231-12/+12
| | | | (cherry picked from commit c1f7f3becf78a48cab1acddf87d5fe0050eaf454)
* Update Friulian translationFabio Tomat2020-10-181-8/+8
|
* Update Portuguese translationJuliano de Souza Camargo2020-10-121-106/+106
| | | | (cherry picked from commit c31ed8fa3f330651a4006d7652325547182b9641)
* Post branch version bump to 40.alphaOndrej Holy2020-10-021-1/+1
| | | | | Let's switch to the new versioning scheme: https://discourse.gnome.org/t/new-gnome-versioning-scheme/4235
* Release version 3.38.13.38.1Ondrej Holy2020-10-023-2/+8
|
* starred-directory: Remove unused variableAntónio Fernandes2020-10-021-1/+0
| | | | Leftover from 4ef151871bef44e13e4d4cb65524284c68406956
* tag-manager: Ignore starred files ouside $HOMEAntónio Fernandes2020-10-021-1/+18
| | | | | | | | | | | | At the moment we restrict starring to within Home, but the database might include URIs from outside of it. Such may happen after a file move operation, as per the previous commit. Keeping the moved URIs in the database is useful in case the move is undone, because we change the URI back. But otherwise, the non-home URIs remain in the database indefinitely. So, let's filter them out when listing the starred files.
* tag-manager: Update starred URIs on move & renameAntónio Fernandes2020-10-024-2/+154
| | | | | | | | | | | | | | | | | We don't rely on tracker-miner-fs's rename tracking for starred files anymore, as explained in 29105fc9f6abf2eca6f986104763d21b9f22f0fb. However, losing track of starred files, when they or their containing folders are renamed or moved, is a major regression for this feature. The common case is that the operation is performed using this very app, so, we can largely restore the feature by updating URI on every rename and move operation we perform. Additionally, this allows us to finally close a couple of old issues. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/161 and fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/169
* Update Hebrew translationYosef Or Boczko2020-09-281-818/+846
|
* Update Friulian translationFabio Tomat2020-09-241-97/+97
|
* Update Russian translationStas Solovey2020-09-221-960/+1016
|
View Lorry Controller Status