| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
This unused since commit ace6d2c2170028148785f3fa87eedf883f20f1dd
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We always skip hidden and backup files when counting the number of
files in a directory, if "show-hidden-files" is turned Off. This is
done so that the item count matches which items the user sees.
However, we have been skipping them also when computing the total size
of a folder contents. This is wrong because hiding content doesn't
make the folder actually smaller in size.
So, let's decouple deep size from deep count, such that, even when
skipping files in deep count, their size is always added to the total
content size.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/638
|
| |
|
|
|
|
| |
(cherry picked from commit a87205dcb45707d78ebf487c54d2174ef0ffc7f7)
|
|
|
|
|
|
|
| |
Currently, the nightly job is skipped if fedora rawhide, or flatpak
master job fails. This is not wanted as the nightly should be published
if flatpak devel job succeeds. Let's allow failures of those jobs to
not block the deploy stage.
|
|
|
|
|
|
| |
The update image job is always shown (under the GNOME namespace),
however, fedora rawhide job is used only on master/web. So let's show
this job only on master/web as well.
|
|
|
|
|
|
|
|
| |
The fedora job is run only on schedules and tags. The job is pretty
fast now. So let's run it always on master so we know about possible
breakages immediately and not after several days.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1441
|
|
|
|
| |
(cherry picked from commit 1104e9bd17a04f26b15483c12c4397ea0926139c)
|
|
|
|
| |
(cherry picked from commit 503946a20bb3862e0c6886bc38b4a56c9621f8bf)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on patches from Felipe Borges for other apps. Quoting him:
The GNOME Shell search results are forwarded from the results of
GLib's g_desktop_app_info_search() function, which matches the
Name, Exec, Keywords, GenericName, X_GNOME_FullName, and Comment
keys from desktop files[0].
Since Totem is now named "Videos", a query for "totem" would
match the "Exec" key and present the application in the search
results as expected. Unfortunately that doesn't happen for Flaptaked
Totem, which would get its desktop file "Exec" key overwritten to
something such as Exec=/usr/bin/flatpak run --branch=stable
--arch=x86_64 --command=totem org.gnome.Totem --new-document
This way, searching for "totem" when only the Flatpaked version
of it is installed returns no results. Searching for "Videos"
presents the application as expected.
Its been proposed in GLib to parse the "Exec" key for searches
but that was rejected[1] because it would imply establishing an
API which assumes that the command line behavior of Flatpak would
be stable/never-change.
A fix was proposed in Flatpak directly[2] but it was rejected,
leaving us with the only option of adding the historical/legacy
application names to the "Keywords" key in their desktop files.
Many users, such as myself, have the "muscle memory" of search
for the old application's name, such as "totem", "gedit", "evince".
Although I agree that the new names should be presented to new
users and that the old ones shouldn't be visible in UI, it makes
sense and little effort to support the search for the old names IMO.
[0] https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gdesktopappinfo.c#L378
[1] glib#1706
[2] https://github.com/flatpak/flatpak/issues/2749
|
| |
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/504
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/504
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/504
|
|
|
|
|
|
|
| |
Add DeleteURIs method to make it possible to permanently delete
files avoiding trash.
https://gitlab.gnome.org/GNOME/nautilus/merge_requests/504
|
|
|
|
|
|
|
|
|
|
| |
Add new version of FileOperations interface. This versions adds
PlatformData argument to all methods. Currently supported arguments
are parent-handle and timestamp.
This change is necessary for proper focus handling.
https://gitlab.gnome.org/GNOME/nautilus/merge_requests/504
|
| |
|
|
|
|
|
|
|
| |
This reverts commit e7c2a0182a4ba2d6eb05fe170cc9b4d018a70feb, because
the stage name doesn't have to be explicitely defined currently as it
was changed directly in the template:
https://gitlab.gnome.org/GNOME/citemplates/-/commit/5bffac6dfbd797291a90e705925a7a3973e4cc57
|
|
|
|
|
|
|
|
| |
Fedora and style check jobs install dependencies on each run. This
causes that the pipelines take a long time. Let's use a custom docker
image to not block runners for such a long time and to get the pipeline
results faster. This commit also adds a new job to generate the docker
image for us.
|
|
|
|
|
| |
It is not easy to find out why the style check job failed. Let's expose
the style check job diff over artifacts to make it easier.
|
|
|
|
|
|
| |
The whole code was reformatted using uncrustify script, but MRs are not
checked using the script. Let's add style-check job to prevent wrongly
formated MRs to be merged.
|
|
|
|
|
| |
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
|
|
|
|
|
|
|
| |
C++ comments ("//") are converted to C comments ("/* */"), but they
are not grouped together. So, each line is enclosed by "/* */". Let's
add cmt_cpp_group and cmt_c_group options to ensure that the single
line comments are grouped together.
|
|
|
|
|
|
|
|
|
| |
Let's add "indent_ternary_operator = 1" to our uncrustify.cfg in order
to prevent the following unwanted change:
list = back ? nautilus_window_slot_get_back_history (self->window_slot) :
- nautilus_window_slot_get_forward_history (self->window_slot);
+ nautilus_window_slot_get_forward_history (self->window_slot);
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uncrustify makes the following change, which is unwanted:
gtk_widget_set_sensitive (self->view_button, new_sections->extended_section != NULL ||
- new_sections->zoom_section != NULL ||
- new_sections->supports_undo_redo);
+ new_sections->zoom_section != NULL ||
+ new_sections->supports_undo_redo);
Let's add parentheses to prevent this unwanted change.
|
|
|
|
|
|
| |
Uncrustify changes "(*pixsrc++ * *pixdest)" to "(*pixsrc++ **pixdest)"
which is unwanted. Let's add redundant parentheses around "*pixdest" to
prevent these unwanted changes.
|
|
|
|
|
| |
Skip gtk, animation and audio-video-properties subdirectories as those
codes are copy&pasted from other project.
|
|
|
|
|
| |
Triage jobs use just 2 spaces as tab size, whereas other jobs are using 4.
Let's fix this.
|
|
|
|
|
|
| |
The stage and job names can contain spaces and they are already used
in job names. Let's replace underscore in cross_environemnt stage to
make the pipeline output nicer.
|
|
|
|
|
| |
Teh review and stop_review jobs are no more needed as per flatpak_ci_initiative.yml
comments. Let't remove them to make the file more readable.
|
|
|
|
|
| |
The distro_test template is used only by one job. Let's move the code
directly to that job to make the file more readable.
|
|
|
|
|
| |
The coverage is not computed since the commit a5a405d. Let's remove
the unused gcovr module also.
|
|
|
|
|
|
| |
The coverage is not computed since the commit a5a405d, but .gitlab-ci.yml
still contains some coverage related code which is not currently used. Let's
remove that code to make it more readable.
|
|
|
|
|
|
|
|
|
|
|
|
| |
The checkbox animation was not animated earlier.Which looked inconsistent with the rest of the checkboxes in the UI.
It was happening due to the resize_mode property being present in the XML definition.
Resize modes determine weather a resize request will be passed to container's parent qued for later execution or immediate.
Resize Modes are deprecated since version 3.12 and shouldn't be used in newly written code.
If used it might cause obscure bugs, and the inconsistent animation of the checkbox was one example of that.
This bug has been fixed by removing the resize_mode property from the xml definition.
Closes : https://gitlab.gnome.org/GNOME/nautilus/-/issues/1418
|
|
|
|
|
|
|
|
|
|
|
| |
The G_FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE attribute doesn't have to be
always set. See https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/68
for more details. In that case, Nautilus fallbacks to the
"application/octet-stream" type, which causes issues when opening the
files. Let's fallback to the "standard::fast-content-type" attribute
instead to fix issues when opening such files.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1425
|
|
|
|
| |
(cherry picked from commit ad20a85a8df72f587a6e9ce5f0825b6bf5eda1bc)
|
|
|
|
| |
(cherry picked from commit 7e4fdc87601f401ee43aaaef79b518caa84d0bb8)
|
|
|
|
| |
(cherry picked from commit ee821f9ebb076f8772a47f35ca217e9310730685)
|
| |
|
|
|
|
| |
(cherry picked from commit e8c985858d7bde291751056dbd1312bda7bdcc30)
|
|
|
|
|
|
|
|
|
|
|
| |
On completion of long file transfer operation. We currently show a
notification on completion of file transfer only if there are no open
windows.
To make Files more intuitive show all operations completed notification
even if there are open windows but none of them has focus.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/998
|
|
|
|
|
|
| |
Comparison is always false because positions >= 1
Makes comparison redundant
|
| |
|
|
|
|
| |
(cherry picked from commit e451d2081258a1f7347df49cbc4cd487148945a9)
|
|
|
|
| |
(cherry picked from commit e49887609e6555c8b127463bb0ddb1909dc81eb7)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the tooltip says 'Toggle view', which isn't clear.
Usability testers had difficulty finding out how to change between
list and grid view.
Change tooltip to say 'Show list' or 'Show grid', depending on which
view it can change to.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/893
|