| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
With the new design, the main page sometimes gets very tall.
Make it scroll if it doesn't fit the screen.
|
|
|
|
|
|
|
|
|
| |
Replace the tabbed GtkNotebook view with inlined navigation rows that
link to subpages and a back button that allows navigating back.
Also, remove now-inadequate .view style class.
Part of #1258
|
|
|
|
|
|
|
|
| |
The height-for-width interaction between permission rows and the grid,
with the list box spanning two columns, is buggy.
Port the remaining element (the "Others" label) to a list row and use
the vertical GtkBox directly, with no GtkGrid interposed.
|
|
|
|
|
|
| |
Wrap the security context label in an AdwActionRow.
Part of #1326
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a simpler user interface represent the executable bit with a
GtkSwitch.
The previously used GtkCheckButton had an "inconsistent" state, which
was used when the executable bit was not set for all files or not set
for all of user/group/other. Since GtkSwitch does not have such a
special state, a separate GtkRevealer combined with a tooltip is used
to handle this case.
Part of #1326
|
|
|
|
|
|
|
|
|
|
| |
Replace group GtkComboBox with AdwComboRow. Reuse functionality
added for previous adaption of the owner row.
This implementation allows to enable the dropdown based on current
file permissions.
Part of #1326
|
|
|
|
|
|
|
|
|
|
|
| |
Replace owner GtkComboBox with AdwComboRow. The underlying model only
stores strings returned by nautilus_get_user_names, instead of
structured data. On owner changes, the user name is extracted ad-hoc.
The implementaiton uses multiple helper functions, meant to be
reused for the group ownership adaption.
Part of #1326
|
|
|
|
|
|
|
|
|
|
| |
Use a dash with spaces to separate user names and display names, rather
than line breaks and splitting and recombining the string.
For now the user name is still extracted for each entry, with the
adaption to GListModel this will only be done when needed.
Part of #1326
|
|
|
|
|
|
|
|
|
|
|
| |
When creating the drop down list of owners, store a hash value of the
used user names. Use this hash value to detect if the users of the
system have changed and the list needs to be recreated.
This removes a dependency on GtkTreeModel, easing future adaption to
GListModel.
Part of #1326
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the previous GtkComboBox widgets for permissions with
AdwComboRow. This requires changing the underlying model from a
GtkTreeModel with indexed columns, to a GListModel and a helper struct
NautilusPermissionEntry.
Additionally permission description strings are now centralized via the
permission_value_to_string helper function. This replaces the previous
approach of piecing together strings for non-default options, allowing
for simpler translations and shared strings.
Part of #1326
|
|
|
|
|
|
|
|
|
|
|
| |
Previously every call to permission_combo_update() calculated combined
permissions of all target files, independent of whether they were
actually used. With this change combined permission are only calculated
once and provided, in the form of a new TargetPermissions struct, to
each combo box.
Additionally, a new PermissionValue to represent inconsistent permission
states was added, to avoid tracking this via a separate boolean.
|
|
|
|
|
|
| |
This commit moves around some code snippets, partly to have
functions declared before their (future) usage and partly in
preparation for further changes.
|
|
|
|
|
| |
Add PERMISSION_NONE to PermissionValue enum and use it instead of `0`
for clearer naming of passed parameters.
|
|
|
|
|
|
|
|
|
| |
The gboolean "is-folder" stored as GObject data, indicates
whether a permission combo box or a checkbox refers to folders or files.
For enhanced readability and performance this is replaced with the
FilterType enum. This allows to combine checking the property window
target_files for files or folders and clarifies passed parameters to
helper functions.
|
|
|
|
|
|
|
| |
GObject data for the key "properties_window" is never read.
Similarly GObject data for the key "is-special" is never written.
This removes both keys and subsequent attempted uses.
|
|
|
|
|
|
|
|
| |
Use a GtkStack and a AdwStatusPage to indicate that permissions of the
currently selected items could not be determined, replacing the previous
behavior of hiding and showing partial snippets with a HIG pattern.
Part of #1326
|
|
|
|
|
|
|
|
|
|
| |
Convert property entries in the basic tab from a grid form into
multiple AdwActionRows, with each entry represented by a row.
The icon picker and the volume pie chart remain unchanged, with only
some placeholders used for spacing removed.
Part of #1326
|
|
|
|
|
|
|
|
| |
The funcitonality was duplicated with the rename popover. It can
potentially be brought back after the redesign by reusing the
rename popover.
Part of #1326
|
|
|
|
|
| |
The basic_grid variable was read from the .ui file but never actually
was used, only passed on. This drops the variable.
|
|
|
|
| |
We should build our own custom entry instead of doing this.
|
|
|
|
| |
It doesn't have an specific target to point to.
|
| |
|
| |
|
|
|
|
| |
Instead of .dim-label.
|
|
|
|
|
|
|
|
|
| |
GtkImage is simpler now, with only 2 available sizes. We need to use the
new GtkPicture instead to restore the expected icon sizes. It can grow
to fill the space available to fit the intrinsic size of the image.
-gtk-icon-filter CSS extensions don't work on GtkPicture. Instead, use
a filter to achieve a similar visual result.
|
|
|
|
|
| |
GtkImage no longer sets an icon size on construction.
Set a pixel size which matches the intrinsic size of the paintable.
|
|
|
|
| |
With the actual colors they are now alias for.
|
| |
|
|
|
|
|
| |
Removing redundant custom styles revealed we weren't adding this
the class to this view, as we should.
|
| |
|
|
|
|
|
|
|
|
|
| |
With libadwaita, the existing code wasn't loading the custom themes as
it should. But thanks to libadwaita, we can make assumptions on the
existing stylesheet.
In the future we may want to unify our 2 css files and maybe adopt
AdwApplication to have it load the custom styles automatically.
|
|
|
|
| |
The signal signature changed and doesn't include a GdkEvent anymore.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Generally we should be able to use any paintable.
Unfortunately GtkCellRendererPixbuf doesn't accept paintables other
than textures.
The other two usages of textures require a GIcon. We could create a
GThemedIcon using GtkIconPaintable:icon-name, but to keep changes
at a minimum short here, that's left for a later enhancement.
|
|
|
|
| |
The new method ignores maximized and tiled size, which is convenient.
|
| |
|
|
|
|
| |
As per porting guide.
|
|
|
|
| |
GDateTime-centric now.
|
| |
|
|
|
|
| |
As per migration guide.
|
| |
|
|
|
|
| |
They return an internal GDateTime pointer now, not a time_t.
|
|
|
|
| |
Now we set a function instead of listening to a signal.
|
| |
|
| |
|
|
|
|
| |
The API is GFIle-only now, and as such always supports non-local URIs.
|
|
|
|
| |
Check button is not a subclass of toggle button anymore.
|
| |
|
| |
|
| |
|