| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
| |
|
|
|
|
|
|
|
|
| |
The `--talk-name=org.gtk.vfs` statement should not be used in manifests
as there is no service with such name. The `--talk-name=org.gtk.vfs.*`
statement should be pretty enough for the GVfs access. See:
https://docs.flatpak.org/en/latest/sandbox-permissions.html#gvfs-access
Let's drop that statement.
|
| |
|
|
|
|
|
|
|
|
| |
Now that we are properly freeing all view items, it became obvious
that we were incorrectly freeing a call to get_item_from_file
which is just a hash table lookup.
See: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1101
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When renaming a file in list-view or grid-view, the renamed file keeps
its position (i.e. it isn't re-positioned into the new proper position)
until a refresh). There is actually a more generalized problem where
file changes on all attributes fail to cause the sort positions to be
updated. For example, sorting by date modified and touching a file
doesn't cause a re-sort.
The file-changes signal from nautilus-directory, simply gives us the
changed files for a given directory, without telling us what was changed
so there's not an efficient way of detecting this. We do have a
::end-file-changes signal, that is only emitted once every batch of
changes, so let's call nautilus_view_model_sort() then. If no sort
changes are required, this will finish quite fast, so it seems like
the best alternative.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2568
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The libadwaita pkg-config adds `-I/usr/include/libadwaita-1`
(or similar) to the compiler flags, which means that
#include <adwaita.h>
is sufficient, and the currently used
#include <libadwaita-1/adwaita.h>
is not necessary.
Not only is it not necessary, but it prevents nautilus from being
built with an uninstalled libadwaita build (either meson subproject
or otherwise). To fix that, remove the `libadwaita-1/` prefix.
The libadwaita test programs also only `#include <adwaita.h>`, and
according to Debian Code Search, that is the more popular version.
https://codesearch.debian.net/search?q=%23include+%3Cadwaita.h%3E&literal=1
https://codesearch.debian.net/search?q=%23include+%3Clibadwaita-1%2Fadwaita.h%3E&literal=1
|
|
|
|
|
|
|
|
|
|
|
| |
Fix critical when parsing null date string:
GLib-CRITICAL **: 12:05:52.144: g_time_val_from_iso8601: assertion 'iso_date != NULL' failed
This is possible since tracker can return NULL[1] "if the column is
not in the [0,#ncolumns] range"
[1] https://gnome.pages.gitlab.gnome.org/tracker/docs/developer/tracker-sparql-cursor.html?gi-language=c#tracker_sparql_cursor_get_string
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit c1ebea52a5f653dcd55a20c10b8f74423c0d19dd)
|
|
|
|
|
|
|
| |
Declare what sort of hardware we support and the minimum
display size Nautilus is usable on. This allows applications
like Software to display hardware information or hide the app
on incompatible hardware.
|
|
|
|
|
|
| |
List the form factors the app was designed for in the desktop
file. This is so desktop environments like Phosh and Plasma Mobile
can show or hide the app in the correct contexts.
|
|
|
|
|
|
|
|
|
|
| |
The flatpak jobs are broken currently, because the tracker-miners project
fails to build due to missing upower-glib depenedency. It is used to tweak
the behavior when running on battery. It used to be automatically disabled
until the following MR:
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1121. I suppose
it is safe to disable this functionality as our flatpak isn't meant for
production. Let's explicitely disable that to fix our pipeline.
|
|
|
|
|
|
|
|
|
|
|
| |
The commit e2969a9c29d0d171038fcb35d8baa5a7df372191 introduced an assertion
statement to ensure that the `g_file_get_basename` returned non-NULL string.
Unfortunately, the assertion has an inverted condition. This leads to crashes
in the `get_unique_target_file` function for files that don't have the
`edit-name` attribute set (i.e just a few GVfs backends). Let's fix the
inverted condition.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2825
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
The flatpak@aarch64 is not allowed on other branches than master but
is allowed on forks. It would be nice to allow manual run in those cases
to save resources, but to allow testing aarch64-specific fixes.
|
|
|
|
|
|
| |
The pages job is allowed on forks currently. It is not desired to run it
there and it is going to fail there anyway. Let's explicitly disable this
job on forks.
|
|
|
|
|
| |
The only/except keywords were deprecated in favor of rules. Let's
replace them with rules.
|
|
|
|
|
|
|
| |
The pages job is not running currently on master. This is because
`only: refs: $CI_DEFAULT_BRANCH` is not supported (e.g. see
https://gitlab.com/gitlab-org/gitlab/-/issues/29591). Let's fix that
using one of the suggestions from that issue.
|
|
|
|
|
|
|
| |
With non-local drops, when the value is initially NULL, we get
warnings because of some of the checks done on a NULL value. This was
a regression from 3d17ed252960cbc9848aea0b398a4a74ef05623c. Return
action copy before any check dependent on a dropped value.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Add a check to assert nautilus_files_view_drop_proxy_received_uris is
not called with an empty source uri list.
Make nautilus_dnd_perform_drop return whether the drop event was
actually handled. Adjust callers accordingly.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2787
|
|
|
|
|
|
| |
This change makes the rubberband to have rounded corners,
making it consistent with other elements such as buttons and text entries,
which also have rounded corners.
|
| |
|