| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
TrackerCursor returns NULL if it doesn't have information on the date.
https://gnome.pages.gitlab.gnome.org/tracker/docs/developer/method.SparqlCursor.get_string.html
We try to parse NULL as a date string. This is obviously wrong and
gets us a precondition failure warning, as it should.
So, if a string is NULL, just skip it.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2160
|
|
|
|
|
|
|
| |
This reverts commit 5f1680f9df8d6a62681a878975a1cec75a328a3d.
It avoids a warning from g_date_time_new_from_iso8601() by pushing
the code flow into another warning. A different solution is to follow.
|
|
|
|
|
|
|
|
| |
Open properties on the search directory crashes Nautilus.
Exclude search, recent, and starred from opening
current directory properties when no file is selected.
Fixes #2903
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the sidebar, when dragging to re-order bookmarks,
other bookmarked folders are automatically opening while hovering
over them as it happens during a drag-and-drop operation.
This action should not be permitted because it is inconceivable to
drag-and-drop a bookmark into another bookmark.
Implement a check to prevent automatically navigating
into the bookmarked folders if they are hovered on while dragging
a bookmark with the intent to just re-order them.
It achieves this behavior by not adding a navigation hover timeout
if we are dragging a row (bookmark) in the sidebar.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2820
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nautilus fails critical assertions if the user opens then closes a
new window in rapid succession in a large folder.
This is because the GSource created by
nautilus_path_bar_set_templates_menu to bind menu model to popover is
not removed even if the pathbar has already been finalized by the user
closing the window.
Keep track of the source id and remove source if the pathbar is
being disposed of.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2867
|
| |
|
| |
|
|
|
|
|
|
|
| |
Otherwise, due to some modular arithmetic artifacts, there is an
unsightly 1px transparent line between the picture and its css border.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2779
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the current location is marked as gone, Nautilus jumps to the
first existing parent currently (except for non-native locations and
mount roots). This is fine in most cases, but not for autofs locations
as Nautilus jumps to parent everytime autofs mount timeouted. It would
be better to stay in the same folder in this case. Let's try the current
location first even if it is marked as gone to ensure that. It would be
perhaps even better to prevent autofs locations somehow from timeouting
at all, or avoid immediate remounting at least, but those solutions
don't look easy to implement.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1514
|
| |
|
|
|
|
|
|
|
|
| |
When copying these classes from GTK the translation domain was kept.
This causes issues with translations in libadwaita widgets, so remove
them.
Fixes #2890
|
|
|
|
|
|
|
|
| |
Changes in GTK (https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5442)
require to use `gtk_switch_set_active` to flip a switch, otherwise it
ends up in an inconsistent state.
Fixes #2883
|
|
|
|
|
| |
gtk_window_get_focus can return NULL. Passing that directly into
gtk_widget_is_ancestor throws a GLib warning, so handle it explicitly.
|
|
|
|
|
|
|
|
|
| |
The `G_FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE` attribute doesn't have to
be always set. The commit 0e597803 added the
`G_FILE_ATTRIBUTE_STANDARD_FAST_CONTENT_TYPE` fallback inside the
`NautilusFile` class, but not for other places. Let's fix this oversight.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2862
|
|
|
|
|
|
|
|
|
| |
The `Deprecated pre-processor symbol: replace with "G_ADD_PRIVATE"`
warning is shown during build currently. This is caused by the usage
of the `G_TYPE_INSTANCE_GET_PRIVATE` macro. However, the statement with
this macro doesn't have any effect. This looks to be an oversight in
the commit 335eabec. Let's drop the whole statement to get rid of this
warning.
|
|
|
|
|
|
|
| |
The `‘action’ may be used uninitialized` warning is shown during build
currently. It can really happen that uninitialized value is used when
dropping something else then the `GDK_TYPE_FILE_LIST` and `G_TYPE_STRING`
on the tab bar. Let's initialize the action to prevent this.
|
|
|
|
|
|
|
| |
The `‘action’ may be used uninitialized` warning is shown during build
currently. It can really happen that uninitialized value is used when
dropping something else then `GDK_TYPE_FILE_LIST` on the pathbar. Let's
initialize the action to prevent this.
|
|
|
|
|
|
|
|
| |
Currently, the `ignoring return value of ‘g_string_free_and_steal’
declared with attribute ‘warn_unused_result’` warning is shown during
build. This is because the `str` struct member is used instead of a
return value from the `g_string_free` function. Let's update the code
to use the return value in order to avoid this warning.
|
|
|
|
|
|
|
| |
Currently, the `Nautilus: "@name" parameter unexpected at this location`
warning is shown during build. This is caused by the extra newline character
in the documentation comment for the `nautilus_column_new` function. Let's
remove this extra newline character to get rid of that warning.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c1c7ccb0e23772d8cfb509eb133d7e522706c697 as it
turned out that the workaround is still needed. I've only updated the
obsolete comment a bit. The issue was initially fixed by the
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4831 merge request,
but it has been broken later.
Related: https://gitlab.gnome.org/GNOME/gtk/-/issues/5670
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2844
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
The `G_FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE` attribute doesn't have to
be always set. This case is not handled by the `NautilusSearchEngineSimple`
class and the `NULL` pointer can be passed in the `g_content_type_is_a`
function currently. This is an error. Let's check the returned pointer
to prevent this situation.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is not guaranteed that all `GFileInfo` attributes are always set when
requested. They used to be silently set to `NULL`, `FALSE`, or `0` earlier
when they were not provided by their implementations. However, some of the
helper functions now print critical errors when the attributes are not set
by their implementations even though they were requested. See the
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3261 merge request for
more details. So Nautilus now prints tons of critical errors when started.
The unset attributes can be detected over the `g_file_info_has_attribute`
function. But Nautilus doesn't care in most cases about the reason why the
attribute is `NULL`, `FALSE`, or `0`. There are also more generic helper
functions that don't print these critical errors. Let's use them for the
attributes that may not always be set to get rid of those critical errors.
I suppose that the `name`, `display_name`, `size`, `icon`, and `file_type`
attributes don't need this special handling, although it is not clearly
stated anywhere...
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2861
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
We are already caching the preferences for thumbnailing. Since the
clock format is queried for every single file when loading a list view,
we should also cache the clock format setting.
Rename the flag from use_24 to use_24_hour for more clarity.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In nautilus_file_class_init, we are calling
thumbnail_limit_changed_callback() and show_thumbnails_changed_callback()
in order to cache the initial values for the static variables
cached_thumbnail_limit and show_file_thumbs. This has the unintended
side effect of also calling emit_change_signals_for_all_files_in_all_directories ()
which doesn't make sense at a point in time when there are no
NautilusFile's and NautilusDirectory may not even be ready.
Split out the updating of the setting from the emission of
all files changed.
|
|
|
|
|
|
|
|
|
| |
I see regularly the following debug print on Nautilus startup:
`GLib-CRITICAL **: 10:52:52.992: g_hash_table_foreach: assertion
'hash_table != NULL' failed`. This is because the
`emit_change_signals_for_all_files_in_all_directories` function is called
before the `directories` hash table is initialzed. Let's return early
to prevent usage of the uninitialized hash table.
|
|
|
|
|
|
|
|
|
|
| |
Currently, the `g_bus_own_name_on_connection` function is called for the
`org.freedesktop.FileManager1` name before exporting the
`/org/freedesktop/FileManager1` skeleton. This seemingly works fine in most
cases, but occasionally the name is acquired too early and D-Bus clients
can get `No such interface` error. This is regression caused by the commit
2293e813d3cd1cc47b2b8750f7140647aa066fc8. Let's try to own the nam until
after exporting the skeleton to avoid this error.
|
|
|
|
|
|
| |
This reverts commit d45b820d4a082287ef52f538fc001009ad5204e1.
This commit causes a crash.
|
|
|
|
|
|
|
| |
This reverts commit 16c0a9b102e99ec7aa3c880e034d8aa7b9c5b4f7.
This commit builds on commit d45b820d4a082287ef52f538fc001009ad5204e1
which causes a crash.
|
|
|
|
|
|
|
|
| |
There are two error messages that may be shown when the delete operation
fails. One message is generic and the another one mentions insuffient
permissions. However, the generic one is now shown in the case of the
`G_IO_ERROR_PERMISSION_DENIED` error. Let's exchange the messages to
use the second one in this case.
|
| |
|
| |
|