summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* [Commit message is WIP]wip/antoniof/try-admin-backend-for-file-opsSachin Daluja2021-11-278-51/+635
| | | | | | | | | file-operations: Try admin backend for file ops When the user does not have sufficient permissions. Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1282 Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/257
* file-operations: Use g_file_enumerator_get_childAntónio Fernandes2021-11-271-4/+2
| | | | | | | | | | As documented, this is a convenience method that's equivalent to our existing code, assuming the directory at hand is the enumerator container. Also, this convenience method remains correct if the enumerator container is different, which is going to be the case soon, as we introduce support for retrying with admin:// URIs.
* file-operations: Store op kind at job creationAntónio Fernandes2021-11-272-9/+15
| | | | | | | | This is going to be useful for admin operations. Existing uses of OpKind are left unchanged because they may represent a sub-operation (e.g.: delete fallback path of a trashing operation), not the main operation.
* file-operations: Move job structs to private headerAntónio Fernandes2021-11-273-124/+136
| | | | To be usable from a separate file for admin operations.
* file-operations: Simplify abort_jobAntónio Fernandes2021-11-271-4/+6
| | | | | | | Make finalize_common() call nautilus_file_undo_manager_set_action() only if the job hasn't been cancelled. This way, abort_job() becomes a simple wrapper for g_cancellable_cancel(), and we can just call g_cancellable_cancel() as well if needed (such as from another file).
* file-operations: Drop obsolete job structAntónio Fernandes2021-11-271-9/+0
| | | | | | Historical note: it was use to mark .desktop launchers as trusted, back when we included support for launching apps, as part of the "desktop icons" featured which was a piece of GNOME 2's shell.
* file-operations: Remove unused parameterSachin Daluja2021-11-275-23/+18
| | | | From NautilusDeleteCallback function signature.
* file-operations: Remove duplicated codeSachin Daluja2021-11-273-90/+30
| | | | | | | The outermost code for handling the "duplicate" file operation was mostly a copy of the similar code for the "copy" operation. Remove the duplicated code and add minor conditional logic in the code for "copy" operation to also handle "duplicate".
* file-operations: Adapt copy_job_setup() for duplicationAntónio Fernandes2021-11-271-15/+17
| | | | | | | The duplicate task doesn't have a *_job_setup() helper. It can reuse the 'copy' one with minor adaptaions. The duplication is still easily identified by having a NULL destination.
* file-undo-operations: Set NULL dest for duplicationAntónio Fernandes2021-11-272-10/+22
| | | | | | | | | | In src/nautilus-file-operations.c, the duplication operation is identified within the 'copy' code paths by having a NULL destination imply it's the same as the source parent dir. For consistency, adopt the same paradigm in the undo stack. Also, while we are at it, adopt autocleanup for some related strings.
* file-operations: Tweak commentAntónio Fernandes2021-11-271-1/+1
| | | | The apostroph confuses GNOME Builder's autoindentation somehow.
* nautilus-search-engine: search by creation timeNishit Patel2021-11-2710-13/+130
| | | | | | | this will let user search for the files using the crtime (creation time) of the files Closes #1761
* Updated Spanish translationDaniel Mustieles2021-11-261-382/+394
|
* progress-info-widget: Make button round again António Fernandes2021-11-251-0/+1
| | | | | | | The button currently looks like a vertical pill, not a circle. This is a regression from a2d5dafa056b7ad96747278c4bfabd178eda9547 Not using the GtkButton image API apparently requires us to add the image-button style class ourselves.
* nautilus-search-popover.ui: Drop GtkSizeGroup:ignore-hiddenErnestas Kulik2021-11-221-2/+0
| | | | | The property no longer exists, and the code acts as if it were true, anyway.
* general: Drop uses of gtk-timeout-expand settingErnestas Kulik2021-11-224-25/+7
| | | | | | | | It's deprecated. Add a hardcoded value equal to the default of gtk-timeout-expand. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* general: Don’t set xalign where unsupportedErnestas Kulik2021-11-221-4/+0
| | | | Most notably, GtkButton:xalign has been deprecated since GTK+ 3.14.
* properties-window: Stop using deprecated propertyAntónio Fernandes2021-11-221-2/+2
| | | | GtkImage:stock and GTK_STOCK_MISSING_IMAGE are deprecated.
* pathbar: Drop gtk_container_class_handle_border_width()Ernestas Kulik2021-11-221-2/+0
| | | | | It's gone in GTK4 and removing this doesn't seem to cause any visual or behavorial change at the moment.
* general: Stop setting GtkWidget:marginAntónio Fernandes2021-11-225-9/+32
| | | | | | | This is also gone in GTK4, so we should set the margin for all 4 sides. In batch-rename-dialog.ui there is a case where :margin was set to 0, which is the default, so just remove the tag in that case.
* general: Drop uses of GtkContainer:border-widthErnestas Kulik2021-11-229-16/+10
| | | | | | In preparation for porting to GTK4. Rebased and ammeded by António Fernandes <antoniof@gnome.org>
* general: Stop using GtkBox padding, fill and expand child propertiesAntónio Fernandes2021-11-2212-181/+21
| | | | | | In preparation for porting to GTK4, where child properties are no more. Based on patch by Ernestas: d4b5c02ee9b2f1870f6b2e5e5bcf6b8d65ea2b85
* tree-view-drag-dest: Stop connecting to ::drawErnestas Kulik2021-11-221-54/+0
| | | | | | | | The "treeview-drop-indicator" style class was a thing in GTK2, but not in GTK3. So, remove this old code which isn't even do anything visible anymore. Also, the ::draw signal is going away when we move to GTK4. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* pathbar: Remove event GdkWindowErnestas Kulik2021-11-221-81/+0
| | | | | | | | | This usage of GdkWindow is a X11'ism that's gone in GTK4. Removing this doesn't seem to cause any visual or behavorial change at the moment. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* pathbar: Drop gtk_widget_set_allocation()Ernestas Kulik2021-11-221-9/+0
| | | | | It's gone in GTK4 and removing this doesn't seem to cause any visual or behavorial change at the moment.
* pathbar: Drop gtk_widget_{g,s}et_clip()Ernestas Kulik2021-11-221-34/+0
| | | | | | | | | | | It's gone in GTK4 and removing this doesn't seem to cause any visual or behavorial change at the moment. Originally it was a workaround to some visual problem with button shadows. Our pathbar buttons don't have shadows nowadays, and even if testing with added shadows, there is no apparent issue nowadays. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* pathbar: Drop gtk_widget_set_redraw_on_allocate()Ernestas Kulik2021-11-221-1/+0
| | | | | | It's gone in GTK4 [1] and doesn't seem to make a difference in GTK3. [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/a8a755e5cddc0f1736cc198301088310a6e26627
* tree-view-drag-dest: Don't use gdk_window_get_position()António Fernandes2021-11-221-10/+7
| | | | | | It's gone in GTK4. Instead, translate to widget coordinates.
* files-view: Drop uses of removed GtkStyleContext APIErnestas Kulik2021-11-221-3/+0
| | | | gtk_style_context_set_junction_sides() is no more.
* autorun-software: Don't use gtk_window_set_icon()António Fernandes2021-11-221-8/+10
| | | | | | | | It's gone in GTK4. We get an icon from GMount. Assuming it's a GThemedIcon, so we can simply get its first name and use gtk_window_set_icon_name() which is still going to work in GTK4.
* properties-window: Don't use gtk_window_set_icon()António Fernandes2021-11-221-4/+0
| | | | | | | | | It's gone in GTK4. Here it's used only as a fallback to a named icon. Also, GNOME doesn't use window icons anyway. So, just drop it to ease the port to GTK4.
* icon-info: Drop gtk_icon_size_lookup()Ernestas Kulik2021-11-224-22/+5
| | | | | | | It no longer exists, and the enumeration only contains normal and large sizes, so hardcoded icon sizes are now used. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* file: Pass parent window to unmount operationAntónio Fernandes2021-11-221-2/+10
| | | | | | | It's conveniently set as a property of GtkMountOperation, so there is no reason not to pass both forward. This is necessary for the preceding commit to actually work as intended.
* file-operations: Make "trash on unmount" dialog modalAntónio Fernandes2021-11-221-23/+2
| | | | | | | | | Actually set the parent window, instead of juggling with GdkScreen, which is going away with GdkScreen. Furthermore, parentless dialogs should not exist, HIG-wise. While we are at it, also remove gtk_window_set_skip_taskbar_hint() which is going away with GTK4 too.
* properties-window: Stop using GtkButtonBoxAntónio Fernandes2021-11-221-6/+6
| | | | | | | | | It's going away with GTK4. Replace it with a GtkBox. This will result in visual changes to the dialog, but the existing visuals are outdated and a redesign is overdue anyway.
* files-view: Handle parent changes in GObject::notifyErnestas Kulik2021-11-221-12/+10
| | | | | | GtkWidget::parent-set is gone in GTK4. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* general: Drop gtk_window_has_toplevel_focus()Ernestas Kulik2021-11-222-4/+4
| | | | | It’s identical to gtk_window_is_active() as far as we are concerned. Also, it's gone in GTK4.
* files-view-dnd: Drop GDK_ACTION_DEFAULTErnestas Kulik2021-11-221-9/+2
| | | | | | It’s gone in GTK4, and its use has been discouraged in GTK3. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* file-changes-queue: Drop GdkPoint struct memberAntónio Fernandes2021-11-221-1/+0
| | | | | It's unused because we no longer handle icons on desktop. Also, the type is gone in GDK4.
* general: Stop using gtk_main_iteration()António Fernandes2021-11-223-4/+4
| | | | It's going away with GTK4. Use the recomended replacement.
* general: Replace uses of GDK thread APIErnestas Kulik2021-11-223-12/+6
| | | | | | | | | | We are doing all GTK stuff from the main thread anyway. If we are not, we are in big trouble anyway. So, drop gdk_threads* API this in preparation for GTK4, where it won't exist. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* Update Friulian translationFabio Tomat2021-11-211-266/+267
|
* Update Galician translationFran Dieguez2021-11-191-375/+378
|
* pathbar: Avoid leaking stack pagesAntónio Fernandes2021-11-191-2/+27
| | | | | | | | | | | | | | The templates submenu in the current location popover is recreated every time the menu model is updated, but the old widgetry is never destroyed. This results in a memory leak and many warnings in the terminal output. I couldn't find the root cause, after many investigations. However, I've found that unsetting the model actually removes the old widgetry. Let's do that as a workaround. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1705
* Update Croatian translationGoran Vidović2021-11-191-153/+154
|
* operations-ui-manager: Port passphrase dialog to GtkBuilderAntónio Fernandes2021-11-194-36/+71
| | | | This removes usage of the GtkContainer API, preparing for GTK4.
* file-operations: Simplify archive password dialog handlingOndrej Holy2021-11-193-109/+102
| | | | | | | | | | | | | | Our AutoarExtractor::request-passphrase handler implements in invoking the main context for the dialog from an operation thread. This duplicates existing code that caters the same use case for the file conflict dialog (using the `invoke_main_context_sync()` function). Let's move the code handling of the password dialog into the `src/nautilus-operations-ui-manager.c` file to make use of `invoke_main_context_sync()`. Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1829
* Update Persian translationDanial Behzadi2021-11-181-777/+869
|
* Update Occitan translationQuentin PAGÈS2021-11-171-180/+183
|
* file: use specific file type for Sort by TypeRajat Jain2021-11-161-0/+5
| | | | | | | | | | Adds file comparison based on actual file type, rather than generic type category. For example .jpg and .png files will now be sorted into two different groups. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1776 Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>