| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
| |
There's a regression in f88c4a2b39e4e88bf78acffdcee3555a31aaea7c
that causes the numbering label button to never get updated.
The GtkMenuButton was exposed but the api for GtkButton was used
instead. Use GtkMenuButton api
|
|
|
|
|
|
|
|
|
| |
Similar to 60b0a8ae87075374d56b5e3a766a63e5bcdd39ee in gtk4
the delete-text and insert-text should be connected to the
editable delegate of the entry as the entry does not emit those
signals.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2442
|
|
|
|
| |
Rather than displaying a broken page without any row.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generally, we want the properties window to be sized to fit the natural
height of the content of the main page.
However, the extensions subpage is propagating its natural height; in
some cases, this can lead to the properties page being the full screen
height in many cases.
The natural height propagation is set internally by AdwPreferencesPage,
so we have to drop its use here. It was probably a misuse anyway, given
this is a subpage. Internally it's just a scrolled window and a clamp,
so that's what it's gonig to be replaced with.
|
|
|
|
|
| |
For consistency with what we do in Places, use the operating system
name or "Operating System" instead of "/"
|
|
|
|
|
|
|
|
| |
Apparently this was from when Nautilus had properties windows as
independent windows. Now it breaks the ability to open the same
property window from another Nautilus window. Remove the code.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2358
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the introduction of nautilus-dbus-launcher, we made it so that
the current disk is selected in gnome-disks (when opening from the
properties window) by passing the disk identifier to --block-device.
This works fine for most mounted volumes, but breaks the ability to
open gnome-disks for the root filesystem because
g_file_find_enclosing_mount() doesn't return a mount for the root file
system (it only returns "user interesting locations").
So, use unix-specific API to handle that case (antoniof's ammendment).
As a 2nd fallback, just open Disks without selecting anything (but if
this ever happens, it's a bug: we probably shouldn't show the Disks
section in Properties in that directory).
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2447
|
| |
|
|
|
|
|
|
| |
We have a special case to set the icons for mounts, but the root
filesystem doesn't return a mount from g_file_find_enclosing_mount()
so set the icon for / separately.
|
|
|
|
|
|
|
|
|
|
|
| |
When you open a properties window on the root file system,
you'll get
g_file_has_prefix: assertion 'G_IS_FILE (file)' failed
because setup_star is checking if the parent location can be starred.
We only allow starring files in the home directory anyways, so just
return early
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2422
|
|
|
|
|
|
|
|
|
|
| |
In x11 the GtkDropTarget is not correctly setting the preferred action
on the GdkDrop. The GdkDrag is getting set correctly, so for the
meantime, until a solution is merged into Gtk, let's get the action
from the GdkDrag instead of the GdkDrop.
See: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4982
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2457
|
|
|
|
| |
In preparation for the next commit.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In gtk4, we need to set labelled-by to help a11y programs know what
it currently selected.
Unfortunately, the focus is on a GTK internal widget, so at the moment
this solution requires a hack: we mark the internal list item widget as
being labeled by our cell (which is, in turn, labeled by the filename label).
We are reporting this to GTK to work toward a better solution.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2460
|
| |
|
| |
|
|
|
|
|
|
|
| |
The Properties of these places are broken and unnecessary.
Also, disable copying the URI of these locations, because it's also
useless.
|
|
|
|
|
|
|
| |
Otherwise the pathbar still displays the submenu in locations where
creation of new files is not supported.
Resolves https://gitlab.gnome.org/GNOME/nautilus/-/issues/2455
|
|
|
|
|
|
| |
I screwed up in 8c296a91c8a3e410edcb6471fa713eeaa3133d25 by flipping
the instance and data when disconnecting the signal. Let's just use
g_signal_connect_object to make this automatic.
|
| |
|
|
|
|
| |
g_set_object adds a ref, so don't use it in this case
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
In the sidebar, bookmarking only makes sense for mounted volumes.
Hide add/remove bookmark if the action is disabled, because the
action would never make sense for locations where it's disabled.
|
|
|
|
|
|
|
| |
Menu item was set to "add-bookmark" so this was never enabled
because the action was nonexistent.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2461
|
|
|
|
|
|
|
| |
Rebase on the current flatpak-ci style/guidelines, thus enabling aarch64
builds (and publshing nautilus on gnome-nightly for aarch64)
https://gitlab.gnome.org/GNOME/Initiatives/-/wikis/DevOps-with-Flatpak
|
|
|
|
|
|
|
|
| |
xdg-user-dirs is intentionally configured to disable a special
directory when it's set to $HOME. Let's check if the file is
pointing to the home directory and return early.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2459
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
After closes the background or selection menu (by clicking out of the
menu or escape) the focus goes to the back button in the toolbar,
rather than the last focused item. It's not clear if this is a
gtk issue or because our complex configuration. Connect the "closed"
signal to simply grab back the focus to the files view. This isn't
perfect because it doesn't necessarily grab the last focussed child,
but it saves from adding too much complexity.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2433
|
|
|
|
|
|
|
| |
This reverts commit 60f40431e218964153f223026e7cc2339d445701.
It caused popovers not to resize when new menu items are enabled.
We are going to use a different workaround.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
After removing the action from the trash infobar, let's add it back
where it makes sense to be located.
|
|
|
|
|
| |
After removing the separate trash bar, let's roll it into special
location bar, as it only has 1 button now.
|