| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Part of the Adwaita fullcolor refresh.
- 512x512px for highres
- less shine
- flatter
|
|
|
|
|
|
|
|
| |
When the user toggled the Show Hidden Files option on the toolbar menu,
previously the menu disappeared - which isn't the correct behaviour. This
commit changes it so that the menu doesn't disappear.
https://bugzilla.gnome.org/show_bug.cgi?id=766952
|
|
|
|
| |
g_file_get_uri needs to return non-null.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 24dae9e0a "file-operations: avoid scanning the same files"
added a way to skip files which have already been processed
in scan_dir(). To do that, the code uses G_FILE_ATTRIBUTE_ID_FILE,
which does not seem to be widely implemented by gvfs modules.
When the file has no ID, it will not be accounted for in the SourceInfo
structure used to track copy progress, resulting in progress not being
shown, and Nautilus saying that it's copying 0 files.
This commit changes the logic to use the file URI instead of the file ID
to check if the file has already been processed.
|
|
|
|
|
|
|
|
|
|
| |
Better to give a good debug experience, seems -0g is the appropiated
one reading https://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html
Also, disable deprecation warnings for now, since it makes harder for
contributors to realize the code they did has a real warning.
When we want to port to gtk4 we will turn them on anyway.
|
|
|
|
| |
Mis hojos!
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were setting the icon position metadata for any operation in any file
due to legacy code where nautilus was able to have a
freedom-of-placement canvas in the regular windows.
However that changed and we can only have freedom-of-placement in the
desktop window.
Setting the metadata is a extremely expensive operation, and was causing
issues, outlined in https://bugzilla.gnome.org/show_bug.cgi?id=757747,
summarizing copy and move operations where really slow when using drag
and drop, operations when we need to store the icon position when using
a freedom-of-placement canvas view.
This patch tries to only set the metadata when necessary, which is when
using the desktop window. However the code is pretty integrated with the
rest of Nautilus, so the patch was able to isolate the part when the
metadata is set and only provide metadata when the target is the desktop.
However, for unsetting the metadata the patch need to check if it's
the desktop inside the file-operations, which is less than ideal.
https://bugzilla.gnome.org/show_bug.cgi?id=775910
|
|
|
|
|
|
|
|
| |
Soon we will recommend GNOME Builder as the recommended way to hack on
Nautilus, since it will become more easy with the Flatpak integration.
For that, let's add the GNOME Builder config file so GNOME Builder picks
it up automatically and contributors can start with everything set up
properly for starting contributing right away.
|
|
|
|
|
|
|
|
|
| |
At least for the time being, desktop icons are not supported on
wayland. This may or may not change, but in the meantime we can
still meet user expectations by forcing the supported backend
instead of failing with an unsupported one.
https://bugzilla.gnome.org/show_bug.cgi?id=748347
|
| |
|
|
|
|
| |
This reverts commit 171bf2a8378ac97c9b89a2cbc840bc77452352b6.
|
|
|
|
| |
This reverts commit 5f1fd258f0f900d21e77f9cfb6579d786e5f10d3.
|
|
|
|
| |
This reverts commit 3aaecdeea8dfb754cedd170ac80302281961b9f9.
|
|
|
|
| |
This reverts commit fbe174d1581f78154c587c0c1d2604ea5e6bffad.
|
|
|
|
| |
This reverts commit c3681088f6e67150297dccfd0c4e697da3f48f63.
|
|
|
|
|
|
|
| |
Although you are free to use any other IDE, we want first class
support for Builder.
https://bugzilla.gnome.org/show_bug.cgi?id=775460
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=775460
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=775460
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=775460
|
|
|
|
|
|
| |
We should ignore the same files for everyone.
https://bugzilla.gnome.org/show_bug.cgi?id=775460
|
|
|
|
|
|
|
|
|
|
| |
The future is finally here, from this commit on you can hack in Nautilus
from any distro in a matter of minutes, and from a single click if you
are using GNOME Builder.
/me dances exhaustively
https://bugzilla.gnome.org/show_bug.cgi?id=775460
|
|
|
|
| |
This reverts commit 21bc97be30c0f851134dd3cb825206daff2f8f10.
|
| |
|
|
|
|
|
| |
Some issues were fixed, and now we can rerun Uncrustify to format
correctly more part of the code.
|
|
|
|
|
|
|
|
| |
selection_not_empty_in_menu_callback was simply a verbose way to test
whether the selection GList was NULL, which is tidier to just do inline.
The call giving this function its name would be out-of-order if it were
really needed, but it's not since can_set_wallpaper already checks this.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
In the function initial_permission_state_consistent, when the check was
made to see if the files have the same permissions, the check was not
correct.
To fix this, also do & between the first_permissions and the mask.
https://bugzilla.gnome.org/show_bug.cgi?id=698955
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were scanning the sources as we do for copy and move operations,
and to count the files we were recursing inside directories.
However, the trash operation doesn't recurse at all, so the operation
progress was wrong.
Instead of that, don't recurse for counting the number of files, so the
trash progress is correct. Although is not coherent with the rest of the
operations, recursing for just showing all the files in the progress
would be extremely counterproductive.
https://bugzilla.gnome.org/show_bug.cgi?id=775094
|
|
|
|
|
|
|
|
|
|
|
| |
We were not checking whether the operations was aborted from the user
side when setting the details,so that could make a race and the info
thread setting the details to canceled and the operation thread setting
the details too afterwards before realizing the operations was canceled.
To fix it, always check whether the info progress was canceled or not.
https://bugzilla.gnome.org/show_bug.cgi?id=775094
|
|
|
|
|
|
|
| |
The item list in nautilus_clipboard_is_cut_from_selection_data () is
never freed.
https://bugzilla.gnome.org/show_bug.cgi?id=774232
|
|
|
|
|
|
|
| |
The emblem acquired in apply_emblems_to_icon () is not unreffed as it
should be, since g_emblemed_icon_add_emblem () adds a ref to it.
https://bugzilla.gnome.org/show_bug.cgi?id=774232
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That means, now we will show the grid icon when the current view is
the list view and the opposite.
This goes in similarity with gnome-boxes.
The main question to decide this is, is the button an action, and
therefore the icon should be the "target" of the action, or is more
about an information of the current state, and therefore the icon should
be about the current view type?
This patch decides the icon represents an action, although would be good
to have some user testing.
https://bugzilla.gnome.org/show_bug.cgi?id=771075
|