| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
We override the double click in nautilus-list-base but only
have a case for GDK_BUTTON_PRIMARY. If gtk_gesture_single_get_current_button()
doesn't return a button, assume it's the pimary button.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2538
|
| |
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit 69bd3c425e2dea06e833aa66565041f54f6cabf9)
|
|
|
|
| |
(cherry picked from commit ffff26ca85437eb5fc65874fc25865db3e48a339)
|
|
|
|
| |
(cherry picked from commit 3b2404dfd412b9a304439adf91f30bc9159b73a0)
|
|
|
|
|
|
|
|
|
|
| |
Currently, Nautilus crashes for redo operations after undoing a template create.
This is because we are passing the parse path, but we expect the base name for the redo operation.
To fix this, use g_file_get_basename instead of g_file_get_parse_name.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2344
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit bddda81678bcc4da59983e89db5c216a375b2fda)
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
During the switch to GTK4 (e358c2343c47aa26d568254a12f06a8431b2da42), nautilus-x-content-bar
parent was changed from GtkInfoBar to AdwBin, but the G_DEFINE_TYPE
macro wasn't updated accordingly.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2477
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to select the first search result as soon as it arives,
in order to allow keyboard shortcuts to take effect on it. This
makes search more efficient to use with keyboard.
Prior to the gtk4 port (and the introduction of list-base,
canvas view and list view set the selection directly in `select_first`
through `icon_set_selected` and `gtk_tree_selection_select_iter`.
After the port to gtk4, list-base used the existing function
`nautilus_view_set_selection` which seemed to work, except
`nautilus_files_view_set_selection` only actually sets the selection
when the view is not loading. In the meantime, it puts the selection
is a pending_selection to be set when the loading is complete.
This causes problems for search because loading generally takes
longer to complete in a search, and the user will have to wait
until the search is complete for the item to be selected.
As a matter of fact, the *only* time that select_first is used
is during a search (which was the original intention of the function
when introduced in 50711e28ba4d4c971a812a0bdef0c30516141f4e).
There's no need to add further complexity, beyond what the
GtkSelectionModel already provides. Just as `real_select_all`
simples calls `gtk_selection_model_select_all`, make
`real_select_first` call `gtk_selection_model_select_item`.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2481
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
It hardcodes a color which matches only in light mode, and only if high
contrast is not enabled.
Instead derive from currentColor to get light/dark automatic support
and double the alpha opacity on high contrast.
The alpha values were copied from libadwaita's color used by level bar.
|
|
|
|
|
|
|
| |
Remove inset borders from the former, add them to the later.
Also inset the pathbar border, to make it look look the same height as
buttons in the headerbar and overlap the secondary menu border.
|
|
|
|
| |
The patches we want are actually only available in 3.7.2 at this time.
|
|
|
|
|
|
|
| |
We rely on many DND and GtkListBase bugfixes for proper behavior or the
GTK 4 port.
Resolves: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2366
|
|
|
|
|
|
|
|
|
| |
g_file_get_parse_name() returns a string with escaped special characters
for remote locations. Use g_file_get_uri() for remote bookmarks and
unescape the string before setting the tooltip to make sure it is always
a human-readable string. Use g_file_get_path() for local bookmarks.
Fixes #2016
|
|
|
|
|
|
|
|
|
|
| |
If you change the sort order from the sort menu, the next time you
visit that location, the last sort option is remembered.
This is generally desirable behavior, but not in the case of Recent,
Search or Trash.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2472
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Format option is displayed for mtp devices even though gnome-disks
doesn't support them. Hide format option if uri starts with mtp://
This applies to MTP and PTP (gphoto2)
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1358
|
|
|
|
|
| |
Reformat should_show_format_command() to allow for additional
checks.
|
| |
|
|
|
|
|
|
|
|
| |
../libnautilus-extension/nautilus-properties-model-provider.h:61: Warning: Nautilus: nautilus_properties_model_provider_get_models: Unknown type: 'NautilusPropertyModel'
../libnautilus-extension/nautilus-properties-item.h:37: Warning: Nautilus: nautilus_properties_item_new: unknown parameter 'model' in documentation comment, should be 'value'
../libnautilus-extension/nautilus-properties-item.h:46: Warning: Nautilus: nautilus_properties_item_get_name: unknown parameter 'item' in documentation comment, should be 'self'
../libnautilus-extension/nautilus-properties-item.h:54: Warning: Nautilus: nautilus_properties_item_get_value: unknown parameter 'item' in documentation comment, should be 'self'
../libnautilus-extension/nautilus-properties-model-provider.h:45: Warning: Nautilus: NautilusPropertyModel: Unknown type: 'NautilusPropertyModel'
|
| |
|
|
|
|
| |
These were removed in https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/927
|
|
|
|
|
|
|
|
|
|
|
| |
libcloudproviders provides a menu_model that we use to build a
popover menu. It's possible (and true for nextcloud) that these
menus can have sub-menus. If the sub-menus have much longer
(or shorter) item names, the entire menu will get stretched out.
Use GTK_POPOVER_MENU_NESTED when creating the popover menu, creating
a nested menu which does not exhibit this issue.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2405
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make several improvements:
1) Max filename was too long at 128 characters, half it to 64
2) Tweak min filename to 8 characters (still meaningful)
3) Stop at the first sentence rather than last sentence. A filename
should be short and concise, multiple sentences don't make sense.
4) Start at the start_sentence (i.e. eliminate leading whitespace)
Importantly this patch eliminates the potential inclusion of newlines
which is problematic in the views (it causes more than 3 lines of the
filename to appear because of the GtkLabel behavior).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When populating a GList in a loop, we should use prepend() for best
performance, then flip it around once with reverse().
The list of pending additions to files view lacks the second part.
This used to be compensated for by the old views:
* NautilusCanvasView, through NautilusCanvasContainer, would iterate
this list to populate its own list with prepend(), effectively
reversing the order, as was necessary.
* NautilusListView, through NautilusListModel, would iterate this
list to populate its own list with insert_sorted(), once again
fixing the loading order.
The new view don't do that, and have no reason to because they don't
have their own GLists (instead, they manage GListModels). But this
means that the item which should be added last actually is added first.
GtkListBase treats the first added item as the initial focus and as
scroll anchor. The end result is that the view always scrolls to the
bottom and, on keyboard focus, the last item is selected first.
The first issue (view always scrolls to the bottom) has been worked
around with a hack, but the second one persists.
Therefore, lets just reverse the list right after it is built. This
way, the first added item is the one actual first item. It gets initial
keyboard focus and anchors the view to the top (allowing to remove the
workaround).
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2353
|