| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
(cherry picked from commit 6048dc4eb3f91352bfc896d4f678c089fba76632)
|
|
|
|
|
|
|
|
|
|
|
|
| |
The custom icon selection GtkFileChooserDialog is unresponsive when
opened. This is caused by the properties dialog window being modal,
since it is up to the window manager how to process input in such
situations.
One of the ways to ensure that the child dialog receives and processes
user input is by making it modal. This commit makes it such.
https://bugzilla.gnome.org/show_bug.cgi?id=753394
|
| |
|
|
|
|
| |
(cherry picked from commit f27588d73c4f4d579864bd29038b1097fcf37e44)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The to_delete GList* gets initialized in trash_files() and is supposed
to be filled by trash_file() so that we know which files we want to
delete directly when the call to g_file_trash() fails for some reason.
However, this GList* gets modified in place by calls to g_list_prepend()
and so those changes will only be seen by the to_delete argument inside
trash_file(), but not by the local variable defined in trash_files(), which
will continue to point to NULL regardless of those changes.
So, we simply need to pass a reference to the GList* so that any change done
to the structure of the GList* inside trash_file() is seen in trash_files().
https://bugzilla.gnome.org/show_bug.cgi?id=766030
|
|
|
|
|
|
|
|
|
|
| |
The call to gtk_message_dialog_format_secondary_text() in
show_unhandled_type_error() is missing a format argument, which causes
build failures with -Werror=format-security.
This commit adds the missing argument.
https://bugzilla.gnome.org/show_bug.cgi?id=765918
|
|
|
|
| |
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=765792
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Currently, atk_focus_tracker_notify() is used, which is deprecated as
of ATK 2.9.4. Using atk_object_notify_state_change() with
ATK_STATE_FOCUSED is recommended. The deprecated call was replaced.
- For every selection, the previous one should get unfocused.
Currently, only the keyboard focus is tracked. That was extended to
mouse focus with a flag for keyboard focus for indicator rendering.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|
|
|
|
|
|
|
|
|
| |
atk_focus_tracker_notify() has been deprecated since ATK 2.9.4 and using
atk_object_notify_state_change() is recommended.
This commit replaces the call to the deprecated function.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|
|
|
|
|
|
|
|
|
|
| |
AtkComponentIface's {add,remove}_focus_handler should not be overridden,
since ATK 2.9.4, as atk_component_{add,remove}_focus_handler() are
deprecated.
This commit removes deprecated virtual function overrides.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|
|
|
|
|
|
|
|
|
| |
atk_component_get_position() has been deprecated since ATK 2.12 and
using atk_component_get_extents() is recommended.
This commit replaces calls to the deprecated function.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|
|
|
|
|
|
|
|
|
| |
Some GdkDisplay operations have been deprecated in GDK 3.20.
This commit replaces the deprecated code in eel_canvas_item_grab() and
eel_canvas_item_ungrab() functions with new GdkSeat operations.
https://bugzilla.gnome.org/show_bug.cgi?id=762235
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Changing the theme to Adwaita was causing the Adwaita.css style provider
to get added after the nautilus.css style provider. This caused the
Adwaita.css provider to override the nautilus.css provider, because the
behavior of two style providers with the same priority is undefined and
gtk happens to prefer the style provider that got added last.
https://bugzilla.gnome.org/show_bug.cgi?id=765687
|
|
|
|
|
|
|
|
|
|
| |
GtkAlignment has been deprecated since GTK+ 3.14 and the use of
halign, valign and margin properties is encouraged.
This commit aligns widgets by use of said properties instead of the
GtkAlignment widget.
https://bugzilla.gnome.org/show_bug.cgi?id=762238
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to reveal the file that was just renamed.
In order to do that, we have to make sure the view has the icon and all
changes were acknowledge, and only then, reveal the file.
In this patch, we implement this creating a hash table that will hold
any file that needs to be revealed when the view acknowledges it.
Functions using this will be the renaming of files, the creation of
folders, and the creation of folders with selection.
https://bugzilla.gnome.org/show_bug.cgi?id=764137
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=764704
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were checking if the file is native, and if not, we request the
default applications that they must handle uris.
However, we can use FUSE in order to convert those uris to local paths
and therefore use a wider variety of applications.
This fix some default application not being available in network
locations.
https://bugzilla.gnome.org/show_bug.cgi?id=764506
|
|
|
|
|
|
|
|
|
|
|
| |
We use checks to know whether a file is local, using g_file_is_native.
However, we also need to know for some cases when a file, even if no
native, can be handled like native, using FUSE.
This will be needed for the selection of default applications on remote
locations, and will be used in a upcoming patch.
https://bugzilla.gnome.org/show_bug.cgi?id=764506
|
|
|
|
|
|
|
|
|
|
|
|
| |
If nautilus is run with --gapplication-service it has no active window
active.
We were assuming there is always a window active, and therefore nautilus
was crashing if the active window was null.
To fix it add some safe guards.
https://bugzilla.gnome.org/show_bug.cgi?id=765045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 2fa597e we select the first item even if the view didn't load
all the files.
But we were selecting the first item unconditionally.
However, it only makes sense to select the first item on the view if the
view is searching, not otherwise.
This patch makes files view to select the first item only if the view is
searching, as we had previously.
https://bugzilla.gnome.org/show_bug.cgi?id=765264
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were removing the action group when the parent is unset.
However, this removes the action group from the window unconditionally,
meaning that if the view that the parent is unset for is not the current
view it will remove the action group of the actual current view, making
the actions unreachable outside of the view.
This was causing the action menu in the toolbar to have non activatable
actions.
To fix it, make sure we remove the action group only if it matches the
current one attached to the window.
https://bugzilla.gnome.org/show_bug.cgi?id=765489
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases, the operations button doesn't get removed from every
Nautilus window. And if clicked, an empty popover will appear. One case
is when the user starts a long operation, and then closes the popovers
in all windows once the operations have completed (and before the
buttons are due to be removed).
All windows get notified that the operations have finished. But if
there's a popover open in any window at that point, the windows don't
schedule removal of the button - as the logic is to keep the buttons
visible while there are popovers open. When the user then closes the
popover in the last window, that window knows there are no popovers in
the other windows, so it removes the button from it's toolbar. But
there's nothing to notify the other windows to remove their buttons.
The fix is to implement a more robust solution; instead of the windows
checking the other windows for popovers (windows shouldn't know about
the other windows anyway), the progress info manager maintains a list of
viewers. When an popover is open or closed, the window tells the manager
to update it's list of viewers. When there are no entries in the list,
the info manager notifies all listeners (the windows), so they all know
when to schedule removal of their buttons.
https://bugzilla.gnome.org/show_bug.cgi?id=765019
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GtkStatusIcon is deprecated as of GTK+ 3.14.
The progress persistence handler still uses deprecated status icons
alongside notifications.
The fix is to remove status icon support and use notifications
exclusively. Persistence support is expected in environments where
Nautilus is used, making status icons unnecessary.
https://bugzilla.gnome.org/show_bug.cgi?id=762243
|
|
|
|
|
|
|
|
|
| |
Some GdkDisplay operations have been deprecated in GDK 3.20.
This commit replaces the deprecated code with new GdkSeat
operations.
https://bugzilla.gnome.org/show_bug.cgi?id=762235
|
|
|
|
|
|
|
|
|
| |
Some GdkDisplay operations have been deprecated in GDK 3.20.
This commit replaces the deprecated code with new GdkSeat
operations.
https://bugzilla.gnome.org/show_bug.cgi?id=762235
|
|
|
|
|
|
|
|
|
| |
Some GdkDisplay operations have been deprecated in GDK 3.20.
This commit replaces the deprecated code with new GdkSeat
operations.
https://bugzilla.gnome.org/show_bug.cgi?id=762235
|
|
|
|
|
|
|
|
|
| |
The deletion rate shown to the user is wrong, it's coming out as a
massive number. An earlier fix corrected the deletion rate used to
determine if the message should use the plural. This fix is to make the
same change to the value shown to the user.
https://bugzilla.gnome.org/show_bug.cgi?id=759986
|
|
|
|
|
|
|
|
|
|
| |
A simple operator precedence mishap prevented the deletion rate during
long deletion operations from being displayed properly. Also, the
formatting of the message is subtly different from the others of this
kind because we don't have a predefined formatting token for a file
count, and it ended up missing a space character.
https://bugzilla.gnome.org/show_bug.cgi?id=759986
|
|
|
|
|
|
|
|
|
|
| |
Since 474a6c2aa025fcd94bff50e3501a2eb41e4f0388, due to an overlook, no
error is displayed if a connection to a server fails.
This commit restores error reporting by connecting to the
NautilusPlacesView show-error-message signal.
https://bugzilla.gnome.org/show_bug.cgi?id=704872
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes we want to override the show-desktop-icons gsettings, as we
were doing before splitting the desktop.
Wrongly I assumed that since it's a different binary, once can simply
run it or not, but of course that was an oversimplification, and forgot
all what I needed to do in order to support all the cases for the
desktop handling.
This patch adds the missing command line options we had, --force-desktop
and --no-desktop, and also adds the --force-desktop to the classic
desktop file, since we needed to enable the classic mode.
https://bugzilla.gnome.org/show_bug.cgi?id=765159
|
|
|
|
|
|
|
| |
This is needed to make the desktop work, since this is started
in the DESKTOP phase of the session.
https://bugzilla.gnome.org/show_bug.cgi?id=765159
|
|
|
|
|
|
|
| |
This is only needed for the desktop since it gets started in the
DESKTOP phase.
https://bugzilla.gnome.org/show_bug.cgi?id=765159
|
| |
|
|
|
|
|
|
|
| |
So we can build nautilus without desktop support and the other way
around.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
| |
|
|
|
|
| |
(cherry picked from commit 551c2f0b7ccdb50b75f3478c61d540ca6523d111)
|