| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
We had few reports explaining that the operations button is not
noticeable enough when it appears.
In an effort to make more evident that the operations button
appeared, shine the whole toolbar with a delicate Konami effect.
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are having some problems given that the rename entry
is kind of small for some file names, and that makes the
rename popover vs inline renaming kind of a problem.
For that, increase the default entry length and adapt
for longer names with a MIN/MAX length.
https://bugzilla.gnome.org/show_bug.cgi?id=757180
https://bugzilla.gnome.org/show_bug.cgi?id=757694
|
|
|
|
|
|
|
|
|
| |
The popover was remaining persistent after you clicked
outside of the popover.
We were setting modal false and I guess that was messing up
the gtk popover management.
https://bugzilla.gnome.org/show_bug.cgi?id=757694
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So Gnome Shell is aware of it and can activate it.
Until now Gnome Shell was guessing it was able to open a new
window given the app.new-window action. However, what Gnome Shell
does in this case is just call activate of the application, which
is not the "new-window" action for nautilus, and instead only presents
the current window.
One can argue that Gnome Shell should not try to guess the available
actions to, after that, instead of using them, just activate the
application.
https://bugzilla.gnome.org/show_bug.cgi?id=756370
|
|
|
|
|
|
|
| |
We unref in unschedule, so not need to do it here, which
causes that we unref twice a file and therefore crashes
randomly after some time if the user uses the rigth click
menu of the pathbar
|
|
|
|
|
|
|
| |
It was causing problems locking up the view and they
are actually wrong and unecessary
https://bugzilla.gnome.org/show_bug.cgi?id=756978
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were relying on getting the current active window
from gtk to switch open locations, but what people found
is that some times another window change its location instead
of the current one.
I couldn't figure out the root of the problem, so I'm going
to pass explicitly the window on the callers as previous 3.18
we were doing.
Would be cool to find the root of the problem though...
https://bugzilla.gnome.org/show_bug.cgi?id=756499
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to check that all windows have the popover hidden
to remove the operations, if not, what happens is that if
one of the windows has it hidden it removes its operations
and all the other popovers become empty.
The code is not very beautiful since we have to access all
the toolbars of all the windows, which is kind of breaking
the design, but well... creating a "operations toolbar manager"
just for this looks overkill.
https://bugzilla.gnome.org/show_bug.cgi?id=756560
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=757978
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting with gtk-+3.19, gtk+ tries to compensate for the client-side
decorations when moving/resizing top level windows.
With this, the Nautilus desktop window is misplaced because at the time
it's positioned, gtk+ cannot determine it will be undecorated
eventually, as both the gtk_window_set_decorated() and the type hint
(_NET_WM_WINDOW_TYPE) are set after gtk_window_move().
To avoid this, invoke the window positioning after
gtk_window_set_decorated() so that gtk+ is aware that the window is not
decorated and doesn't apply the offset to compensate for client-side
decorations.
Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=757471
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that Nautilus doesn't permit to map shortcuts to launch
the scripts in the scripts folder.
I added a function to read from a configuration file the shortcuts to
map the scripts.
When the scripts are added to the context menu they will have associated
the shortcuts written in the config file.
https://bugzilla.gnome.org/show_bug.cgi?id=757766
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit 6e31af116aa35b01fc45993a55faa7c10041956f)
|
|
|
|
| |
(cherry picked from commit 913e9895b55c6228bcfd46993e8fbb37913f14b2)
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=757190
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=756803
|
| |
|
|
|
|
|
|
|
|
|
| |
If the name is the empty string then nautilus_file_set_display_name
won't actually set the display name. In this case we were returning
NULL from nautilus_file_peek_display_name, which some of our callers
weren't prepared to handle. This led to crashes.
https://bugzilla.gnome.org/show_bug.cgi?id=700507
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are managing all command line options in the main instance.
That works always correctly except when resolving relative paths,
which are relative the local instance, not the main one.
To fix it, set a "cwd" option in the local instance to ensure the
relative file paths are resolved in the main instance based on the local
instance.
https://bugzilla.gnome.org/show_bug.cgi?id=756688
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
When trash is not supported.
https://bugzilla.gnome.org/show_bug.cgi?id=756536
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were peeking the filesystem type synchronously since nautilus
was checking for some file infos that are only required once
synchronously. However the call for the filesystem is usually slow
which makes nautilus main thread hang.
To avoid I/O in the main thread, make the filesystem type request
asynchronously and part of all the others attributes for the file.
https://bugzilla.gnome.org/show_bug.cgi?id=756280
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were not taking into account the time the operations
takes to prepare the operation itself. That makes big
operations take more time than needed for show the toolbar
operations button feedback than expected (2 seconds).
Fix that exposing a new timer that takes into account all
the time since the start of the operation and use that
for deciding when to show the file operations toolbar button
or not.
https://bugzilla.gnome.org/show_bug.cgi?id=756096
|
|
|
|
|
|
|
|
|
|
| |
We were using as default that we can trash files, and after
we only set the if it is possible to trash or not if the filesystem
reports that has the info.
In most of schemes that the trash is not supported, the filesystem
actually don't have that info, making can_trash true and providing
the option on nautilus context menu, which does nothing.
Default to not being able to trash to avoid this situation.
|
|
|
|
|
|
|
|
|
| |
We changed the meaning of remote from being only network://
to be a lot of schemes.
Thing is, the properties action was disabled for "remote", and
now that means lot of locations.
I think there is not enough reason to disable properties altogether,
if the network:// file doesn't provide enough info, probably it should.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were disconnecting all the signals on dispose, except
the ones that comes from the widgets and are added with
gtk_widget_class_bind_template_callback. Therefore those
can be emitted after a dispose.
In the toolbar case, we connect to the toggle signal of a
button, which when the toolbar gets disposed, the buttons gets
untoggled and the signal is emitted, then the toolbar tries to
perform actions on external data that was cleared already on dispose.
To avoid that, just clear the data on finalize instead of
dispose.
|
| |
|
| |
|
|
|
|
|
|
| |
The filesystem:type attribute could be NULL, then g_strv_contains
will crash if that happens.
Just don't call it if the attribute is not set.
|
| |
|