| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
And make the style of Nautilus the same for all files.
Hopefully we can fix all the style issues we can find in the next days,
so expect a little of movement on this.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current style of nautilus is rather poor and mixes at least 3
different code styles.
Specific issues that affect the most common contributors to Nautilus
performance are:
- tabs for multiline alignment.
- mix of tabs and spaces.
- errors on no braced one liners conditionals.
- errors on non braced case statements with variable declarations.
So I would say requirements for the style is to address the previous
issues and also be a well known style. I don't want new contributors
to see a new style completely different from C books authors.
So far, I found Allman (aka BSD) style which seems the choice of most C
books authors as far as I can see on internet, and it address the
previous mentioned issues.
Since uncrustify doesn't support the aligment of parameters we do for
multiple stars "**", we also added a script made by Sebastian Wilmet
to align those.
As a matter of practicity I'm going to convert all Nautilus style to
this one, and if the next person who contributes most on Nautilus has
a different choice, please feel free to change it to whatever makes your
performance and your contributors performance the best.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=768311
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=768311
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=768311
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=768311
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renaming multiple files at once has been a missing feature in Nautilus
for a long time. This patch implements that feature in the following way:
This operation is launched in the same way as the rename one, when the
selection has more than one file.
When the batch renaming is launched, a dialog is shown, offering two
modes.
In the first mode, the user can use metadata (if available), numbering and
original file name tags to create the new names. Between the tags, there
also can be written normal text, which will be added in the new names. If
numbering is used, the order of the files can be modified by using several
criteria.
In the second mode, the user can replace an existing part of the name.
https://bugzilla.gnome.org/show_bug.cgi?id=768311
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In 26a3ab4cd5 we put recursivity to the simple search engine in order
to fix the report of some users that weren't getting files inside
folder of home directory.
However this is wrong, since it takes too long and gnome-shell search
provider doesn't have a way to get partial results or close the search
when done, which makes Nautilus not reporting results until the search
is done, and in case the user stops the shell search, nautilus keeps
searching making the CPU consumption really high.
In fact, we always made recursivity for tracker but not for the simple
engine when performing the shell search.
The issue users were experiencing seems unrelated to this, and I
actually cannot reproduce, so let's return to the regular behaviour
we had.
https://bugzilla.gnome.org/show_bug.cgi?id=766174
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=754614
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
One of the error dialog strings was statically allocated, but the dialog
function attempts to free it. In order to fix this, newly allocate a copy of the
string.
https://bugzilla.gnome.org/show_bug.cgi?id=770353
|
|
|
|
|
|
|
| |
The undo description is reassigned the description for the redo operation. Fix
this by correctly assigning the redo description.
https://bugzilla.gnome.org/show_bug.cgi?id=770305
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
The gnome-autoar pkg-config files now have a version suffix.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
The compression and extraction undo / redo strings lacked plural support.
https://bugzilla.gnome.org/show_bug.cgi?id=770270
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Each file name widget has an error label for displaying error messages. However,
when there is no error, the label just takes up space for no reason. In order to
fix this, use a revealer to display error messages.
https://bugzilla.gnome.org/show_bug.cgi?id=770199
|
|
|
|
|
|
|
|
| |
Add an context menu action for compression and a dialog for selecting the file
name and compression format. Add a controller class for managing the compression
dialog.
https://bugzilla.gnome.org/show_bug.cgi?id=770199
|
|
|
|
|
|
|
|
| |
The compression operation allows multiple formats to be selected. It would be
good to store the last choice of the user in order to select it for future
operations.
https://bugzilla.gnome.org/show_bug.cgi?id=770199
|
|
|
|
|
|
|
|
| |
Add an operation for compressing files using gnome-autoar. The operation is
similar in functionality to the one offered by file roller but comes with
integrated progress feedback and support for undoing and redoing.
https://bugzilla.gnome.org/show_bug.cgi?id=770199
|
|
|
|
|
|
|
| |
Make extraction the default action for activating selected archives and add an
option to open them instead of extracting.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
|
| |
The context menu actions are similar to the ones offered by file-roller, but
make use of the internal extract operation.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
|
|
| |
There is no hash set in GLib, so we have to use GHashTable. However there are
functions that allow to use the hash table as hash set. Use that instead of the
regular hash table functions.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
| |
Add a new operation for extracting archives using gnome-autoar.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
|
| |
The function works with strings instead of GFiles. Replace it with a function
that generates unique files in a directory using GFiles.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Nautilus, file conflicts are handled by a specific dialog. Previously, the
dialog class managed both the UI and the related nautilus files. This lead to it
being inflexible due to operation specific logic being mixed with the rest of
the functionality. In order to change this, move file logic to a separate module
and add methods for controlling the UI elements in the dialog.
Create an operation-manager module to handle dialog controlling. Move anything
related to Nautilus files from the dialog class to the new module.
https://bugzilla.gnome.org/show_bug.cgi?id=770160
|
| |
|
| |
|