summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* application: Support dark preferencewip/exalm/darkAlexander Mikhaylenko2021-12-112-1/+4
|
* file-operations: Delay FileConflictDialog activationÁlvaro Costa2021-12-085-0/+43
| | | | | | | | | Just as the error, warning and question dialogs, the FileConflictDialog may also pop up unexpectedly during a lengthier operation. The same idea of the previous commit is applied here. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1988
* file-operations: Delay dialog activationÁlvaro Costa2021-12-082-0/+28
| | | | | | | | | | | | Warning, error and question dialogs may pop up unexpectedly during lengthier operations and the user may end up selecting an unwanted action. This patch introduces a delay of 2s for dialog activation when the total elapsed time of the job that created the dialog is greater than 2s. Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1988
* search-popover: Stop using blocking dialog functionsMatthew Jakeman2021-12-071-21/+37
| | | | | | | Replaces usage of gtk_dialog_run() with the "response" signal in preparation for GTK 4 port. Part of #1992
* general: Stop overriding GtkWidget.destroy()António Fernandes2021-12-064-29/+21
| | | | | | | | It's gone in GTK4. Anything we are doing on ::destroy can be done on ::dispose(). Extra care must be taken, however, because GObject.dispose() may be run multiple times; for this reason, move some things to .finalize().
* Revert "general: Stop overriding GtkWidget.destroy()"António Fernandes2021-12-064-39/+49
| | | | | | | | | | | This reverts commit 1c83d6af8bb4890dfb279c75506fa9be2a66b6ee. It did a little to much and this introduced at least one bug: when going from a regular folder to other-locations:///, the current view menu keeps displaying invalid actions (New Folder, Properties, etc.), which, if activated, crash the application. Let's revert first and do it right in the next commit.
* extensions/image-properties: Reduce container APIAntónio Fernandes2021-12-061-2/+7
| | | | Preparing for GTK4.
* extensions/image-properties: Don't subclass widgetAntónio Fernandes2021-12-063-60/+37
| | | | | | | | GTK discourages subclassing widgets. The only reason we are subclassing here is to add struct fields. But we don't need to subclass a widget for that. We don't even need to subclass GObject. A plain data struct is enough.
* general: Stop using GtkContainer::get_children() and ::foreach()António Fernandes2021-12-064-34/+40
| | | | Add transition wrappers for needed GTK4 methods unavailable in GTK3.
* general: Stop using gtk_container_add()António Fernandes2021-12-0617-49/+152
| | | | | | | | GtkContainer is gone in GTK4. Use per-class child-adding methods. For the cases where such methods are unavailable in GTK3, introduce small wrapper functions with the same signature as the GTK4 methods, to help with the transition.
* floating-bar: Drop arbitrary multi-action APIAntónio Fernandes2021-12-063-92/+73
| | | | | | | | The only action we need is to stop loading. The code to cleanup actions relies on GtkContainer API, gone in GTK4. So, specialize the code on the stop button.
* notebook: Stop using GtkContainer methodsAntónio Fernandes2021-12-061-29/+26
| | | | | | | GtkContainer is gone in GTK4. Replace all usage of its API, except gtk_container_child_set() because there is no replacement for "tab-expand" in GTK3.
* toolbar: Use list box for operations listAntónio Fernandes2021-12-064-29/+46
| | | | | | | | | | | | Using a GtkBox to display a dynamic list requires us to manually add and remove children, relying on the GtkContainer API, gone in GTK4. Instead, we can use GtkListBox, which we can pass a model and let it take care of creating and disposing of children for us. After the GTK4 switch, we should probably replace it with GtkListView to avoid the default behaviors of GtkListBox which we are adding workarounds for.
* toolbar: Unify toolbar UI definitionsAntónio Fernandes2021-12-064-94/+40
| | | | | | | | The toolbar's UI definition is split among two files because we used to have a NautilusContainerMaxWidth between them, which is not GtkBuildable. With out custom container gone from the toolbar, we can simplify this, while also reduce the usage of GtkContainer API, which is gone in GTK4.
* toolbar: Stop using custom max width containerAntónio Fernandes2021-12-062-10/+6
| | | | | | | | | | | | | | We have been using NautilusMaxWidthContainer on the title widget in order to set a size where it stops expanding and starts centering. But we can achieve the same visual result (with default font) by setting a the location entry's :max-width-chars to 88. This is going to allow us to drop the custom container at a later point, which is going to help wtih the transition to GTK4. As a side effect, now the pathbar can grow beyond the max width if neecessary to display more of a path. I see this as a nice bonus!
* extension: Allow @tip to be NULL in nautilus_menu_item_new()Aaron Jacobs2021-12-042-2/+1
| | | | | Tooltips are currently unused, so it makes sense to allow NULL here, as with the @icon parameter.
* extension: Add some missing nullable annotationsAaron Jacobs2021-12-045-7/+7
| | | | | I've generally verified that these are nullable by looking elsewhere in the source.
* extensions/image-properties: Replace deprecated functionsNishal Kulkarni2021-12-044-5/+5
| | | | | | | | | Build log contains deprecation warnings for gexiv2 functions. Replaced `gexiv2_metadata_has_tag()` with `gexiv2_metadata_try_has_tag()` and `gexiv2_metadata_get_orientation()` with `gexiv2_metadata_try_get_orientation()` Closes: #2033
* src/nautilus-trash-bar.c: remove generic containerSuhaas2021-12-041-3/+2
| | | | | | This is to prepare for the migration to GTK4. https://gitlab.gnome.org/GNOME/nautilus/-/issues/1947
* Update Friulian translationFabio Tomat2021-12-031-3/+3
|
* extension: Mark backwards-compatibility typedefs as not introspectableAaron Jacobs2021-11-286-0/+18
| | | | | | | | | I believe these are only included to prevent breakage of existing C extensions, but as they're not intended for actual use we should mark them with `(skip)`. This has the added benefit of making the VAPI file generated from the resulting GIR file much less noisy.
* Update Russian translationAleksandr Melman2021-11-281-1177/+368
|
* extension: Mark entry points as not introspectableAaron Jacobs2021-11-281-3/+3
| | | | | | | As pointed out by Emmanuele Bassi, these are not part of the ABI and should be marked with (skip). See: https://discourse.gnome.org/t/vala-bindings-for-an-unusual-c-ownership-function-signature/8184
* extension: Fix annotation for modules's type listAaron Jacobs2021-11-281-1/+1
| | | | | | | As pointed out by Emmanuele Bassi, this should be transfer=none instead of the present transfer=full. See: https://discourse.gnome.org/t/vala-bindings-for-an-unusual-c-ownership-function-signature/8184
* nautilus-search-engine: search by creation timeNishit Patel2021-11-2710-13/+130
| | | | | | | this will let user search for the files using the crtime (creation time) of the files Closes #1761
* Updated Spanish translationDaniel Mustieles2021-11-261-382/+394
|
* progress-info-widget: Make button round again António Fernandes2021-11-251-0/+1
| | | | | | | The button currently looks like a vertical pill, not a circle. This is a regression from a2d5dafa056b7ad96747278c4bfabd178eda9547 Not using the GtkButton image API apparently requires us to add the image-button style class ourselves.
* nautilus-search-popover.ui: Drop GtkSizeGroup:ignore-hiddenErnestas Kulik2021-11-221-2/+0
| | | | | The property no longer exists, and the code acts as if it were true, anyway.
* general: Drop uses of gtk-timeout-expand settingErnestas Kulik2021-11-224-25/+7
| | | | | | | | It's deprecated. Add a hardcoded value equal to the default of gtk-timeout-expand. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* general: Don’t set xalign where unsupportedErnestas Kulik2021-11-221-4/+0
| | | | Most notably, GtkButton:xalign has been deprecated since GTK+ 3.14.
* properties-window: Stop using deprecated propertyAntónio Fernandes2021-11-221-2/+2
| | | | GtkImage:stock and GTK_STOCK_MISSING_IMAGE are deprecated.
* pathbar: Drop gtk_container_class_handle_border_width()Ernestas Kulik2021-11-221-2/+0
| | | | | It's gone in GTK4 and removing this doesn't seem to cause any visual or behavorial change at the moment.
* general: Stop setting GtkWidget:marginAntónio Fernandes2021-11-225-9/+32
| | | | | | | This is also gone in GTK4, so we should set the margin for all 4 sides. In batch-rename-dialog.ui there is a case where :margin was set to 0, which is the default, so just remove the tag in that case.
* general: Drop uses of GtkContainer:border-widthErnestas Kulik2021-11-229-16/+10
| | | | | | In preparation for porting to GTK4. Rebased and ammeded by António Fernandes <antoniof@gnome.org>
* general: Stop using GtkBox padding, fill and expand child propertiesAntónio Fernandes2021-11-2212-181/+21
| | | | | | In preparation for porting to GTK4, where child properties are no more. Based on patch by Ernestas: d4b5c02ee9b2f1870f6b2e5e5bcf6b8d65ea2b85
* tree-view-drag-dest: Stop connecting to ::drawErnestas Kulik2021-11-221-54/+0
| | | | | | | | The "treeview-drop-indicator" style class was a thing in GTK2, but not in GTK3. So, remove this old code which isn't even do anything visible anymore. Also, the ::draw signal is going away when we move to GTK4. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* pathbar: Remove event GdkWindowErnestas Kulik2021-11-221-81/+0
| | | | | | | | | This usage of GdkWindow is a X11'ism that's gone in GTK4. Removing this doesn't seem to cause any visual or behavorial change at the moment. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* pathbar: Drop gtk_widget_set_allocation()Ernestas Kulik2021-11-221-9/+0
| | | | | It's gone in GTK4 and removing this doesn't seem to cause any visual or behavorial change at the moment.
* pathbar: Drop gtk_widget_{g,s}et_clip()Ernestas Kulik2021-11-221-34/+0
| | | | | | | | | | | It's gone in GTK4 and removing this doesn't seem to cause any visual or behavorial change at the moment. Originally it was a workaround to some visual problem with button shadows. Our pathbar buttons don't have shadows nowadays, and even if testing with added shadows, there is no apparent issue nowadays. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* pathbar: Drop gtk_widget_set_redraw_on_allocate()Ernestas Kulik2021-11-221-1/+0
| | | | | | It's gone in GTK4 [1] and doesn't seem to make a difference in GTK3. [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/a8a755e5cddc0f1736cc198301088310a6e26627
* tree-view-drag-dest: Don't use gdk_window_get_position()António Fernandes2021-11-221-10/+7
| | | | | | It's gone in GTK4. Instead, translate to widget coordinates.
* files-view: Drop uses of removed GtkStyleContext APIErnestas Kulik2021-11-221-3/+0
| | | | gtk_style_context_set_junction_sides() is no more.
* autorun-software: Don't use gtk_window_set_icon()António Fernandes2021-11-221-8/+10
| | | | | | | | It's gone in GTK4. We get an icon from GMount. Assuming it's a GThemedIcon, so we can simply get its first name and use gtk_window_set_icon_name() which is still going to work in GTK4.
* properties-window: Don't use gtk_window_set_icon()António Fernandes2021-11-221-4/+0
| | | | | | | | | It's gone in GTK4. Here it's used only as a fallback to a named icon. Also, GNOME doesn't use window icons anyway. So, just drop it to ease the port to GTK4.
* icon-info: Drop gtk_icon_size_lookup()Ernestas Kulik2021-11-224-22/+5
| | | | | | | It no longer exists, and the enumeration only contains normal and large sizes, so hardcoded icon sizes are now used. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* file: Pass parent window to unmount operationAntónio Fernandes2021-11-221-2/+10
| | | | | | | It's conveniently set as a property of GtkMountOperation, so there is no reason not to pass both forward. This is necessary for the preceding commit to actually work as intended.
* file-operations: Make "trash on unmount" dialog modalAntónio Fernandes2021-11-221-23/+2
| | | | | | | | | Actually set the parent window, instead of juggling with GdkScreen, which is going away with GdkScreen. Furthermore, parentless dialogs should not exist, HIG-wise. While we are at it, also remove gtk_window_set_skip_taskbar_hint() which is going away with GTK4 too.
* properties-window: Stop using GtkButtonBoxAntónio Fernandes2021-11-221-6/+6
| | | | | | | | | It's going away with GTK4. Replace it with a GtkBox. This will result in visual changes to the dialog, but the existing visuals are outdated and a redesign is overdue anyway.
* files-view: Handle parent changes in GObject::notifyErnestas Kulik2021-11-221-12/+10
| | | | | | GtkWidget::parent-set is gone in GTK4. Rebased and ammended by António Fernandes <antoniof@gnome.org>
* general: Drop gtk_window_has_toplevel_focus()Ernestas Kulik2021-11-222-4/+4
| | | | | It’s identical to gtk_window_is_active() as far as we are concerned. Also, it's gone in GTK4.