| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases, the operations button doesn't get removed from every
Nautilus window. And if clicked, an empty popover will appear. One case
is when the user starts a long operation, and then closes the popovers
in all windows once the operations have completed (and before the
buttons are due to be removed).
All windows get notified that the operations have finished. But if
there's a popover open in any window at that point, the windows don't
schedule removal of the button - as the logic is to keep the buttons
visible while there are popovers open. When the user then closes the
popover in the last window, that window knows there are no popovers in
the other windows, so it removes the button from it's toolbar. But
there's nothing to notify the other windows to remove their buttons.
The fix is to implement a more robust solution; instead of the windows
checking the other windows for popovers (windows shouldn't know about
the other windows anyway), the progress info manager maintains a list of
viewers. When an popover is open or closed, the window tells the manager
to update it's list of viewers. When there are no entries in the list,
the info manager notifies all listeners (the windows), so they all know
when to schedule removal of their buttons.
https://bugzilla.gnome.org/show_bug.cgi?id=765019
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GtkStatusIcon is deprecated as of GTK+ 3.14.
The progress persistence handler still uses deprecated status icons
alongside notifications.
The fix is to remove status icon support and use notifications
exclusively. Persistence support is expected in environments where
Nautilus is used, making status icons unnecessary.
https://bugzilla.gnome.org/show_bug.cgi?id=762243
|
|
|
|
|
|
|
|
|
| |
Some GdkDisplay operations have been deprecated in GDK 3.20.
This commit replaces the deprecated code with new GdkSeat
operations.
https://bugzilla.gnome.org/show_bug.cgi?id=762235
|
|
|
|
|
|
|
|
|
| |
Some GdkDisplay operations have been deprecated in GDK 3.20.
This commit replaces the deprecated code with new GdkSeat
operations.
https://bugzilla.gnome.org/show_bug.cgi?id=762235
|
|
|
|
|
|
|
|
|
| |
Some GdkDisplay operations have been deprecated in GDK 3.20.
This commit replaces the deprecated code with new GdkSeat
operations.
https://bugzilla.gnome.org/show_bug.cgi?id=762235
|
|
|
|
|
|
|
|
|
| |
The deletion rate shown to the user is wrong, it's coming out as a
massive number. An earlier fix corrected the deletion rate used to
determine if the message should use the plural. This fix is to make the
same change to the value shown to the user.
https://bugzilla.gnome.org/show_bug.cgi?id=759986
|
|
|
|
|
|
|
|
|
|
| |
A simple operator precedence mishap prevented the deletion rate during
long deletion operations from being displayed properly. Also, the
formatting of the message is subtly different from the others of this
kind because we don't have a predefined formatting token for a file
count, and it ended up missing a space character.
https://bugzilla.gnome.org/show_bug.cgi?id=759986
|
|
|
|
|
|
|
|
|
|
| |
Since 474a6c2aa025fcd94bff50e3501a2eb41e4f0388, due to an overlook, no
error is displayed if a connection to a server fails.
This commit restores error reporting by connecting to the
NautilusPlacesView show-error-message signal.
https://bugzilla.gnome.org/show_bug.cgi?id=704872
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes we want to override the show-desktop-icons gsettings, as we
were doing before splitting the desktop.
Wrongly I assumed that since it's a different binary, once can simply
run it or not, but of course that was an oversimplification, and forgot
all what I needed to do in order to support all the cases for the
desktop handling.
This patch adds the missing command line options we had, --force-desktop
and --no-desktop, and also adds the --force-desktop to the classic
desktop file, since we needed to enable the classic mode.
https://bugzilla.gnome.org/show_bug.cgi?id=765159
|
|
|
|
|
|
|
| |
This is needed to make the desktop work, since this is started
in the DESKTOP phase of the session.
https://bugzilla.gnome.org/show_bug.cgi?id=765159
|
|
|
|
|
|
|
| |
This is only needed for the desktop since it gets started in the
DESKTOP phase.
https://bugzilla.gnome.org/show_bug.cgi?id=765159
|
| |
|
|
|
|
|
|
|
| |
So we can build nautilus without desktop support and the other way
around.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
|
|
|
|
| |
Having so many deprecation warnings obscure the real warnings... :/
Should run more frequently with those disabled.
|
| |
|
|
|
|
| |
(cherry picked from commit 551c2f0b7ccdb50b75f3478c61d540ca6523d111)
|
| |
|
|
|
|
|
|
| |
For a better structured hierarchy.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
| |
This reverts commit c9dcccae611e40f48024bdfeccbb081fa10b7b15.
|
|
|
|
| |
For a better structured hierarchy.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were checking for the new view instead of the old view...
Needless to say that's wrong, and we were not disconnecting at all.
It was not crashing because the view is disconnected when is going to be
destroyed, so no more signals are done.
However, when we were destroying the view, the view signals the
end-loading signal, which forces the slot to free any change data, in
middle of a change.
"Luckely" thanks to all the safe checks in window slot, this was not
crashing, but just misbehaving and not updating the window with the new
view data.
https://bugzilla.gnome.org/show_bug.cgi?id=764981
|
| |
|
|
|
|
| |
If we do we are going to access a NULL model.
|
|
|
|
|
|
| |
We were missing a flag.
https://bugzilla.gnome.org/show_bug.cgi?id=688877
|
|
|
|
|
|
|
|
|
| |
The autorun dialog uses deprecated gtk_message_dialog_set_image().
The fix is to remove the image altogether, as it doesn’t convey any
important information.
https://bugzilla.gnome.org/show_bug.cgi?id=762241
|
|
|
|
|
| |
those should rather be defined by the theme
https://bugzilla.gnome.org/show_bug.cgi?id=763768
|
|
|
|
|
|
| |
And rework the text shown to be more clear.
https://bugzilla.gnome.org/show_bug.cgi?id=763335
|
|
|
|
|
|
|
|
|
|
| |
GtkAlignment has been deprecated since GTK+ 3.14 and the use of
halign, valign and margin properties is encouraged.
This commit aligns widgets by use of said properties instead of the
GtkAlignment widget.
https://bugzilla.gnome.org/show_bug.cgi?id=762238
|
|
|
|
|
|
|
|
|
|
| |
GtkAlignment has been deprecated since GTK+ 3.14 and the use of halign,
valign and margin properties is encouraged.
This commit aligns widgets by use of said properties instead of the
GtkAlignment widget.
https://bugzilla.gnome.org/show_bug.cgi?id=762238
|
|
|
|
|
|
|
|
|
|
| |
A simple operator precedence mishap prevented the deletion rate during
long deletion operations from being displayed properly. Also, the
formatting of the message is subtly different from the others of this
kind because we don't have a predefined formatting token for a file
count, and it ended up missing a space character.
https://bugzilla.gnome.org/show_bug.cgi?id=759986
|
|
|
|
|
|
|
|
|
|
| |
Currently, the text for unhandled type message dialogs is set by
setting the associated GObject properties. That is unnecessary and
results in hardcoded property names.
The fix is to use GtkMessageDialog functions.
https://bugzilla.gnome.org/show_bug.cgi?id=627259
|
|
|
|
|
|
|
|
|
|
| |
The unhandled type message dialog and application chooser dialog for
files of unhandled type are not modal, thus allowing the user to
inadvertently spawn multiple dialogs.
This commit fixes that by making the dialogs modal.
https://bugzilla.gnome.org/show_bug.cgi?id=627259
|
|
|
|
|
|
|
| |
We moved the code to nautilus-file, but forgot to remove the files.
Remove them.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We needed to do some hackish code in order to allow types that are
not included in nautilus-directory to dispatch the correct subclass.
Instead of that, we can just create a "plugabble" system that allows
directory types to be registered in the system, and implement a class
vfunc that queries if the class handles a specific type of uri, falling
back if none can handle it to the usual nautilus-directory.
We can do this for the desktop directory and the search directory.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
|
| |
Same mistake as previous commit.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
|
| |
A mistake to chain up to the same class, creating a loop.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
|
| |
It checks the parents visibility as well.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
|
|
| |
In case we don't meet the conditions the parent function can still
deal with it.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
|
| |
Just to make it cleaner.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|
|
|
|
|
|
| |
Also, make the code cleaner.
https://bugzilla.gnome.org/show_bug.cgi?id=712620
|